drm/msm: call drm_mode_config_reset before drm_dev_register
PATCH 1/1 drm/msm: call drm_mode_config_reset before drm_dev_register
As per the documentation of drm_dev_register, all drivers should call drm_dev_register after all the initialization is completed. This also means that drm_mode_config_reset should be done before drm_dev_register.
Change the sequence to align with this documentation.
--- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_drv.c +2 -2
@@ -538,12 +538,12 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) } } +drm_mode_config_reset (ddev); + ret =drm_dev_register (ddev,0 );if (ret) goto err_msm_uninit; -drm_mode_config_reset (ddev); -#ifdef CONFIG_DRM_FBDEV_EMULATION if (kms && fbdev) priv->fbdev =msm_fbdev_init (ddev);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 9 lines · Abhinav Kumar
As per the documentation of
drm_dev_register, all drivers should calldrm_dev_registerafter all the initialization is completed. This also means thatdrm_mode_config_resetshould be done beforedrm_dev_register.Change the sequence to align with this documentation.
Signed-off-by Abhinav Kumar <[email protected]>
I assume this is just a cleanup you noticed, and not fixing a bug you are hitting (in which case I'll pick it up next merge window, rather than -fixes)
Quoted 24 lines
--- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/msm/msm_drv.c +2
-3@@ -538,12 +538,12 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) } } +drm_mode_config_reset (ddev); + ret =drm_dev_register (ddev,0 );if (ret) goto err_msm_uninit; -drm_mode_config_reset (ddev); -#ifdef CONFIG_DRM_FBDEV_EMULATION if (kms && fbdev) priv->fbdev =msm_fbdev_init (ddev); --
Quoted 3 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Rob
Thanks for the review.
Yes, this was a cleanup we noticed.
Abhinav
Quoted 49 lines · Rob Clark
Quoted 9 lines · Abhinav Kumar
As per the documentation of
drm_dev_register, all drivers should calldrm_dev_registerafter all the initialization is completed. This also means thatdrm_mode_config_resetshould be done beforedrm_dev_register.Change the sequence to align with this documentation.
Signed-off-by Abhinav Kumar <[email protected]>I assume this is just a cleanup you noticed, and not fixing a bug you are hitting (in which case I'll pick it up next merge window, rather than -fixes)
Reviewed-by Rob Clark <[email protected]>Quoted 24 lines
--- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/msm/msm_drv.c +2
-2@@ -538,12 +538,12 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) } } +drm_mode_config_reset (ddev); + ret =drm_dev_register (ddev,0 );if (ret) goto err_msm_uninit; -drm_mode_config_reset (ddev); -#ifdef CONFIG_DRM_FBDEV_EMULATION if (kms && fbdev)priv->fbdev = msm_fbdev_init(ddev);Quoted 4 lines
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel