scsi: wire up ata_scsi_dma_need_drain for SAS HBA drivers
Subsystems (5)
SCSI IBM Power Linux RAID adapter PMC sierra PM8001 driver HiSilicon SAS Controller +1 more subsystems
PATCH 1/1 scsi: wire up ata_scsi_dma_need_drain for SAS HBA drivers
We need ata_scsi_dma_need_drain for all drivers wired up to drive ATAPI devices through libata. That also includes the SAS HBA drivers in addition to native libata HBA drivers.
Fixes cc97923a5bcc ("block: move dma drain handling to scsi")
Reported-by Michael Ellerman <[email protected]>
Signed-off-by Christoph Hellwig <[email protected]>
Tested-by Michael Ellerman <[email protected]>
--- drivers/scsi/aic94xx/aic94xx_init.c | 1 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 1 + drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 + drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 + drivers/scsi/ipr.c | 1 + drivers/scsi/isci/init.c | 1 + drivers/scsi/mvsas/mv_init.c | 1 + drivers/scsi/pm8001/pm8001_init.c | 1 + 8 files changed, 8 insertions(+)
drivers/scsi/aic94xx/aic94xx_init.c +1 -0
@@ -40,6 +40,7 @@ static struct scsi_host_template aic94xx_sht = {/* .name is initialized */ .name = "aic94xx", .queuecommand = sas_queuecommand, + .dma_need_drain = ata_scsi_dma_need_drain, .target_alloc = sas_target_alloc, .slave_configure = sas_slave_configure, .scan_finished = asd_scan_finished,
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c +1 -0
@@ -1756,6 +1756,7 @@ static struct scsi_host_template sht_v1_hw = { .proc_name = DRV_NAME, .module = THIS_MODULE, .queuecommand = sas_queuecommand, + .dma_need_drain = ata_scsi_dma_need_drain, .target_alloc = sas_target_alloc, .slave_configure = hisi_sas_slave_configure, .scan_finished = hisi_sas_scan_finished,
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +1 -0
@@ -3532,6 +3532,7 @@ static struct scsi_host_template sht_v2_hw = { .proc_name = DRV_NAME, .module = THIS_MODULE, .queuecommand = sas_queuecommand, + .dma_need_drain = ata_scsi_dma_need_drain, .target_alloc = sas_target_alloc, .slave_configure = hisi_sas_slave_configure, .scan_finished = hisi_sas_scan_finished,
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +1 -0
@@ -3075,6 +3075,7 @@ static struct scsi_host_template sht_v3_hw = { .proc_name = DRV_NAME, .module = THIS_MODULE, .queuecommand = sas_queuecommand, + .dma_need_drain = ata_scsi_dma_need_drain, .target_alloc = sas_target_alloc, .slave_configure = hisi_sas_slave_configure, .scan_finished = hisi_sas_scan_finished,
drivers/scsi/ipr.c +1 -0
@@ -6731,6 +6731,7 @@ static struct scsi_host_template driver_template = { .compat_ioctl = ipr_ioctl, #endif .queuecommand = ipr_queuecommand, + .dma_need_drain = ata_scsi_dma_need_drain, .eh_abort_handler = ipr_eh_abort, .eh_device_reset_handler = ipr_eh_dev_reset, .eh_host_reset_handler = ipr_eh_host_reset,
drivers/scsi/isci/init.c +1 -0
@@ -153,6 +153,7 @@ static struct scsi_host_template isci_sht = { .name = DRV_NAME, .proc_name = DRV_NAME, .queuecommand = sas_queuecommand, + .dma_need_drain = ata_scsi_dma_need_drain, .target_alloc = sas_target_alloc, .slave_configure = sas_slave_configure, .scan_finished = isci_host_scan_finished,
drivers/scsi/mvsas/mv_init.c +1 -0
@@ -33,6 +33,7 @@ static struct scsi_host_template mvs_sht = { .module = THIS_MODULE, .name = DRV_NAME, .queuecommand = sas_queuecommand, + .dma_need_drain = ata_scsi_dma_need_drain, .target_alloc = sas_target_alloc, .slave_configure = sas_slave_configure, .scan_finished = mvs_scan_finished,
drivers/scsi/pm8001/pm8001_init.c +1 -0
@@ -87,6 +87,7 @@ static struct scsi_host_template pm8001_sht = { .module = THIS_MODULE, .name = DRV_NAME, .queuecommand = sas_queuecommand, + .dma_need_drain = ata_scsi_dma_need_drain, .target_alloc = sas_target_alloc, .slave_configure = sas_slave_configure, .scan_finished = pm8001_scan_finished,
Signature · 1 line
2.26.2
Quoted 9 lines · Christoph Hellwig
We need
ata_scsi_dma_need_drainfor all drivers wired up to drive ATAPI devices through libata. That also includes the SAS HBA drivers in addition to native libata HBA drivers.Fixes cc97923a5bcc ("block: move dma drain handling to scsi")Reported-by Michael Ellerman <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>Tested-by Michael Ellerman <[email protected]>
For pm8001, looks good to me!
Acked-by Jack Wang <[email protected]>
Quoted 8 lines · Christoph Hellwig
We need
ata_scsi_dma_need_drainfor all drivers wired up to drive ATAPI devices through libata. That also includes the SAS HBA drivers in addition to native libata HBA drivers.Fixes cc97923a5bcc ("block: move dma drain handling to scsi")Reported-by Michael Ellerman <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>Tested-by Michael Ellerman <[email protected]>
I'll need to do a v2 as this causes undefined references when libata isn't enabled.