Skip to contentSkip to conversation

env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR

PATCH New Patrick Delaunay 2 participants 3 messages Jun 10, 2020 – Jun 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR

Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated in board_r.c::initr_reloc_global_data() under the compilation flags CONFIG_SYS_RELOC_GD_ENV_ADDR

---

The current code in board_r.c is:

static int initr_reloc_global_data(void)
{
....

#ifdef CONFIG_SYS_RELOC_GD_ENV_ADDR
        /*
         * Relocate the early env_addr pointer unless we know it is not inside
         * the binary. Some systems need this and for the rest, it doesn't hurt.
         */
        gd->env_addr += gd->reloc_off;

#endif
...

 env/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
env/Kconfig +1 -1
index ca7fef682b..38e7fadbb9 100644
@@ -562,7 +562,7 @@ config ENV_UBI_VID_OFFSET
 	  UBI VID offset for environment. If 0, no custom VID offset is used.
 
 config SYS_RELOC_GD_ENV_ADDR
-	bool "Relocate gd->en_addr"
+	bool "Relocate gd->env_addr"
 	help
 	  Relocate the early env_addr pointer so we know it is not inside
 	  the binary. Some systems need this and for the rest, it doesn't hurt.
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR

Quoted 5 lines · Patrick Delaunay

Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated in board_r.c::initr_reloc_global_data() under the compilation flags CONFIG_SYS_RELOC_GD_ENV_ADDR

Pretty sure that's just a typo I introduced, thanks for digging at the code to confirm.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/f58f88a4/attachment.sig>
#2 lore raw

PATCH 1/1 env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR

In reply to Patrick Delaunay
Quoted 6 lines · Patrick Delaunay

Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated in board_r.c::initr_reloc_global_data() under the compilation flags CONFIG_SYS_RELOC_GD_ENV_ADDR

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200615/984296be/attachment.sig>