checkpatch: add check for NONNETWORKING_BLOCK_COMMENT_STYLE
PATCH v2 1/1 checkpatch: add check for NONNETWORKING_BLOCK_COMMENT_STYLE
NETWORKING_BLOCK_COMMENT_STYLE is supported by checkpatch but there doesn't seem to be any check for the standard block comment style. Add support for NONNETWORKING_BLOCK_COMMENT_STYLE to check for empty /* on first line of non-networking block comments.
Signed-off-by Scott Branden <[email protected]>
---
Changes since v1:
-----------------
Do file/patch test and used CHK on file as suggested by Joe Perches.
--- scripts/checkpatch.pl | 12 ++++++++++++ 1 file changed, 12 insertions(+)
scripts/checkpatch.pl +12 -0
@@ -3408,6 +3408,18 @@ sub process { "networking block comments don't use an empty /* line, use /* Comment...\n" . $hereprev); } +# Non-Networking with an empty initial /* + if ($realfile !~ m@^(drivers/net/|net/)@ && + $prevrawline =~ /^\+[ \t]*\/\*[ \t]/ && + $prevrawline !~ /\*\/[ \t]*$/ && #no trailing */ + $rawline =~ /^\+[ \t]*\*/ && + $realline > 2) { + my $msg_level = \&WARN; + $msg_level = \&CHK if ($file); + &{$msg_level}("NONNETWORKING_BLOCK_COMMENT_STYLE", + "non-networking block comments use an empty /* on first line\n" . $hereprev); + } + # Block comments use * on subsequent lines if ($prevline =~ /$;[ \t]*$/ && #ends in comment $prevrawline =~ /^\+.*?\/\*/ && #starting /*
Signature · 1 line
2.17.1