Skip to contentSkip to conversation

fs: Delete always true compilation define

PATCH Superseded Leon Romanovsky 1 participant 1 message Jun 11, 2020 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: Delete always true compilation define

From: Leon Romanovsky <[email protected]>

In commit 1027abe8827b ("[PATCH] merge locate_fd() and get_unused_fd()") the existing "#if 1" was moved from one place to another. Originally that compilation define was set for the sanity check and more than 12 years later it is safe to remove it.

---
 fs/file.c | 2 --
 1 file changed, 2 deletions(-)
fs/file.c +0 -2
index c8a4e4c86e55..cab9d55765dd 100644
@@ -522,13 +522,11 @@ int __alloc_fd(struct files_struct *files,
 	else
 		__clear_close_on_exec(fd, fdt);
 	error = fd;
-#if 1
 	/* Sanity check */
 	if (rcu_access_pointer(fdt->fd[fd]) != NULL) {
 		printk(KERN_WARNING "alloc_fd: slot %d not NULL!\n", fd);
 		rcu_assign_pointer(fdt->fd[fd], NULL);
 	}
-#endif
 
 out:
 	spin_unlock(&files->file_lock);

--
2.26.2