selinux: fix another double free
PATCH 1/1 selinux: fix another double free
From: Tom Rix <[email protected]>
Clang static analysis reports this double free error
security/selinux/ss/conditional.c:139:2: warning: Attempt to free released memory [unix.Malloc]
kfree(node->expr.nodes);
^~~~~~~~~~~~~~~~~~~~~~~When cond_read_node fails, it calls cond_node_destroy which frees the node but does not poison the entry in the node list. So when it returns to its caller cond_read_list, cond_read_list deletes the partial list. The latest entry in the list will be deleted twice.
So instead of freeing the node in cond_read_node, let list freeing in code_read_list handle the freeing the problem node along with all of the the earlier nodes.
--- security/selinux/ss/conditional.c | 1 - 1 file changed, 1 deletion(-)
security/selinux/ss/conditional.c +0 -1
@@ -411,7 +411,6 @@ static int cond_read_node(struct policydb *p, struct cond_node *node, void *fp) goto err;return 0 ; err: -cond_node_destroy (node);return rc; }
Signature · 1 line
2.18.1
Quoted 14 lines · On Thu, Jun 11, 2020 at 11:58 AM <[email protected]> wrote:
From: Tom Rix <[email protected]>
Clang static analysis reports this double free error
security/selinux/ss/conditional.c:139:2: warning: Attempt to free released memory [unix.Malloc]kfree(node->expr.nodes); ^~~~~~~~~~~~~~~~~~~~~~~When
cond_read_nodefails, it callscond_node_destroywhich frees the node but does not poison the entry in the node list. So when it returns to its callercond_read_list,cond_read_listdeletes the partial list. The latest entry in the list will be deleted twice.
Quoted 5 lines
So instead of freeing the node in
cond_read_node, let list freeing incode_read_listhandle the freeing the problem node along with all of the the earlier nodes.Signed-off-by Tom Rix <[email protected]>
Looks like this was introduced by 60abd3181db29ea81742106cc0ac2e27fd05b418 ("selinux: convert cond_list to array").
Hi Tom,
Quoted 8 lines · On Thu, Jun 11, 2020 at 5:58 PM <[email protected]> wrote:
From: Tom Rix <[email protected]>
Clang static analysis reports this double free error
security/selinux/ss/conditional.c:139:2: warning: Attempt to free released memory [unix.Malloc]kfree(node->expr.nodes); ^~~~~~~~~~~~~~~~~~~~~~~
Quoted 7 lines
When
cond_read_nodefails, it callscond_node_destroywhich frees the node but does not poison the entry in the node list. So when it returns to its callercond_read_list,cond_read_listdeletes the partial list. The latest entry in the list will be deleted twice.So instead of freeing the node in
cond_read_node, let list freeing incode_read_listhandle the freeing the problem node along with all of the the
There is an extra "the" before "freeing".
Quoted 12 lines
earlier nodes.
Signed-off-by Tom Rix <[email protected]>--- security/selinux/ss/conditional.c | 1 - 1 file changed, 1 deletion(-)security/selinux/ss/conditional.c +0
-0
security/selinux/ss/conditional.c static int cond_read_node(struct policydb *p, struct cond_node *node, void *fp) · line 414
Quoted 5 lines
security/selinux/ss/conditional.c +0
-1@@ -411,7 +411,6 @@ static int cond_read_node(struct policydb *p, struct cond_node *node, void *fp) goto err;return 0 ; err: -cond_node_destroy (node);return rc;
Since there is now just "return rc" in the error path, can you please replace all the gotos with plain return statements? And please also add a Fixes: tag pointing to the commit that introduced the bug (see Stephen's reply).
Thanks,
Signature · 3 lines
Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc.