Skip to contentSkip to conversation

gpiolib: cdev: fixes for split from gpiolib.c

PATCH In review Kent Gibson 2 participants 5 messages Jun 12, 2020

Subsystems (2)
GPIO GPIO uapi
lore
Share & tools
lore

Kent Gibson

author reviewer
#0 lore raw

cover gpiolib: cdev: fixes for split from gpiolib.c

A couple of minor fixes for the recent split from gpiolib.c:
The first fixes a couple of W=1 build warnings by including the module's own header.
The second fixes the file comment. This was in v3 of the split patch, but v2 got merged...

Kent Gibson (2):
gpiolib: cdev: fix -Wmissing-prototypes warnings
gpiolib: cdev: fix file comment

 drivers/gpio/gpiolib-cdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

base-commit: f6d984418ffde19322fd149105200224ac2bc089

Signature · 1 line
2.27.0
author reviewer
#1 lore raw

PATCH 1/2 gpiolib: cdev: fix -Wmissing-prototypes warnings

Fix -Wmissing-prototypes warnings by including module's header.

Fixes f6d984418ffd (gpiolib: split character device into gpiolib-cdev)
Reported-by kernel test robot <[email protected]>
Signed-off-by Kent Gibson <[email protected]>
---
 drivers/gpio/gpiolib-cdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpiolib-cdev.c +1 -0
index 971470bdc9c9..58011ba88a1d 100644
@@ -23,6 +23,7 @@
 
 
 #include "gpiolib.h"
+#include "gpiolib-cdev.h"
 
 /* Implementation infrastructure for GPIO interfaces.
  *
Signature · 1 line
2.27.0
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] gpiolib: cdev: fix -Wmissing-prototypes warnings

pt., 12 cze 2020 o 06:51 Kent Gibson <[email protected]> napisał(a):

Quoted 23 lines

Fix -Wmissing-prototypes warnings by including module's header.

Fixes f6d984418ffd (gpiolib: split character device into gpiolib-cdev)
Reported-by kernel test robot <[email protected]>
Signed-off-by Kent Gibson <[email protected]>
---
 drivers/gpio/gpiolib-cdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpiolib-cdev.c +1 -1
index 971470bdc9c9..58011ba88a1d 100644
@@ -23,6 +23,7 @@
 
 
 #include "gpiolib.h"
+#include "gpiolib-cdev.h"
 
 /* Implementation infrastructure for GPIO interfaces.
  *
--
Quoted 2 lines

2.27.0

Reviewed-by Bartosz Golaszewski <[email protected]>
author reviewer
#3 lore raw

PATCH 2/2 gpiolib: cdev: fix file comment

In reply to Kent Gibson

Replace file comment carried over from gpiolib.c with one more appropriate for gpiolib-cdev.c.

Signed-off-by Kent Gibson <[email protected]>
---
 drivers/gpio/gpiolib-cdev.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpio/gpiolib-cdev.c +3 -4
index 58011ba88a1d..17d5541d76a0 100644
@@ -25,11 +25,10 @@
 #include "gpiolib.h"
 #include "gpiolib-cdev.h"
 
-/* Implementation infrastructure for GPIO interfaces.
+/* Character device interface to GPIO.
  *
- * The GPIO programming interface allows for inlining speed-critical
- * get/set operations for common cases, so that access to SOC-integrated
- * GPIOs can sometimes cost only an instruction or two per bit.
+ * The GPIO character device, /dev/gpiochipN, provides userspace an
+ * interface to gpiolib GPIOs via ioctl()s.
  */
 
 /*
Signature · 1 line
2.27.0
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] gpiolib: cdev: fix file comment

pt., 12 cze 2020 o 06:51 Kent Gibson <[email protected]> napisał(a):

Quoted 29 lines

Replace file comment carried over from gpiolib.c with one more appropriate for gpiolib-cdev.c.

Signed-off-by Kent Gibson <[email protected]>
---
 drivers/gpio/gpiolib-cdev.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpio/gpiolib-cdev.c +3 -5
index 58011ba88a1d..17d5541d76a0 100644
@@ -25,11 +25,10 @@
 #include "gpiolib.h"
 #include "gpiolib-cdev.h"
 
-/* Implementation infrastructure for GPIO interfaces.
+/* Character device interface to GPIO.
  *
- * The GPIO programming interface allows for inlining speed-critical
- * get/set operations for common cases, so that access to SOC-integrated
- * GPIOs can sometimes cost only an instruction or two per bit.
+ * The GPIO character device, /dev/gpiochipN, provides userspace an
+ * interface to gpiolib GPIOs via ioctl()s.
  */
 
 /*
--
Quoted 2 lines

2.27.0

Reviewed-by Bartosz Golaszewski <[email protected]>