Skip to contentSkip to conversation

nfs: Fix memory leak of export_path

PATCH New [email protected] 1 participant 1 message Jun 12, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs: Fix memory leak of export_path

From: Tom Rix <[email protected]>

The try_location function is called within a loop by nfs_follow_referral. try_location calls nfs4_pathname_string to created the export_path. nfs4_pathname_string allocates the memory. export_path is stored in the nfs_fs_context/fs_context structure similarly as hostname and source. But whereas the ctx hostname and source are freed before assignment, export_path is not. So if there are multiple loops, the new export_path will overwrite the old without the old being freed.

So call kfree for export_path.

---
 fs/nfs/nfs4namespace.c | 1 +
 1 file changed, 1 insertion(+)
fs/nfs/nfs4namespace.c +1 -0
index a3ab6e219061..873342308dc0 100644
@@ -308,6 +308,7 @@ static int try_location(struct fs_context *fc,
 	if (IS_ERR(export_path))
 		return PTR_ERR(export_path);
 
+	kfree(ctx->nfs_server.export_path);
 	ctx->nfs_server.export_path = export_path;
 
 	source = kmalloc(len + 1 + ctx->nfs_server.export_path_len + 1,
Signature · 1 line
2.18.1