drm/i915: Remove redundant i915_request_await_object in blit clears
Subsystems (2)
PATCH 1/1 drm/i915: Remove redundant i915_request_await_object in blit clears
From: Tvrtko Ursulin <[email protected]>
One i915_request_await_object is enough and we keep the one under the object lock so it is final.
At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
--- .../gpu/drm/i915/gem/i915_gem_object_blt.c | 35 +++++++------------ 1 file changed, 13 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +13 -22
@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu (struct drm_i915_gem_object *obj, +struct i915_request *rq, +bool write) +{ +if (obj->cache_dirty & ~obj->cache_coherent) +i915_gem_clflush_object (obj,0 ); + +return i915_request_await_object (rq, obj, write); +} +int i915_gem_object_fill_blt (struct drm_i915_gem_object *obj,struct intel_context *ce,u32 value)
@@ -143,12 +154,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err))return err; -if (obj->cache_dirty & ~obj->cache_coherent) { -i915_gem_object_lock (obj); -i915_gem_clflush_object (obj,0 ); -i915_gem_object_unlock (obj); - } - batch =intel_emit_vma_fill_blt (ce, vma, value);if (IS_ERR (batch)) { err =PTR_ERR (batch);
@@ -165,10 +170,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err)) goto out_request; - err =i915_request_await_object (rq, obj, true); -if (unlikely (err)) - goto out_request; -if (ce->engine->emit_init_breadcrumb) { err = ce->engine->emit_init_breadcrumb (rq);if (unlikely (err))
@@ -176,7 +177,7 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, }i915_vma_lock (vma); - err =i915_request_await_object (rq, vma->obj, true); + err =move_obj_to_gpu (vma->obj, rq, true);if (err ==0 ) err =i915_vma_move_to_active (vma, rq,EXEC_OBJECT_WRITE );i915_vma_unlock (vma);
@@ -317,16 +318,6 @@ struct i915_vma *intel_emit_vma_copy_blt(struct intel_context *ce,return ERR_PTR (err); } -static int move_to_gpu (struct i915_vma *vma,struct i915_request *rq,bool write) -{ -struct drm_i915_gem_object *obj = vma->obj; - -if (obj->cache_dirty & ~obj->cache_coherent) -i915_gem_clflush_object (obj,0 ); - -return i915_request_await_object (rq, obj, write); -} -int i915_gem_object_copy_blt (struct drm_i915_gem_object *src,struct drm_i915_gem_object *dst,struct intel_context *ce)
@@ -375,7 +366,7 @@ int i915_gem_object_copy_blt(struct drm_i915_gem_object *src, goto out_request;for (i =0 ; i <ARRAY_SIZE (vma); i++) { - err =move_to_gpu (vma[i], rq, i); + err =move_obj_to_gpu (vma[i]->obj, rq, i);if (unlikely (err)) goto out_unlock; }
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2020-06-15 15:09:28)
Quoted 63 lines
From: Tvrtko Ursulin <[email protected]>
One
i915_request_await_objectis enough and we keep the one under the object lock so it is final.At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc Michael J. Ruhl <[email protected]>--- .../gpu/drm/i915/gem/i915_gem_object_blt.c | 35 +++++++------------ 1 file changed, 13 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +11
-10@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu (struct drm_i915_gem_object *obj, +struct i915_request *rq, +bool write) +{ +if (obj->cache_dirty & ~obj->cache_coherent) +i915_gem_clflush_object (obj,0 ); + +return i915_request_await_object (rq, obj, write); +} +int i915_gem_object_fill_blt (struct drm_i915_gem_object *obj,struct intel_context *ce,u32 value)@@ -143,12 +154,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err))return err; -if (obj->cache_dirty & ~obj->cache_coherent) { -i915_gem_object_lock (obj); -i915_gem_clflush_object (obj,0 ); -i915_gem_object_unlock (obj); - } - batch =intel_emit_vma_fill_blt (ce, vma, value);if (IS_ERR (batch)) { err =PTR_ERR (batch);@@ -165,10 +170,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err)) goto out_request; - err =i915_request_await_object (rq, obj, true); -if (unlikely (err)) - goto out_request; -if (ce->engine->emit_init_breadcrumb) { err = ce->engine->emit_init_breadcrumb (rq);if (unlikely (err))
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, · line 183
Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +1
-1@@ -176,7 +177,7 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, }i915_vma_lock (vma); - err =i915_request_await_object (rq, vma->obj, true); + err =move_obj_to_gpu (vma->obj, rq, true);if (err ==0 ) err =i915_vma_move_to_active (vma, rq,EXEC_OBJECT_WRITE );i915_vma_unlock (vma);
Ah, but here it's also the wrong side of init_breadcrumb. -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 66 lines · Chris Wilson
Quoting Tvrtko Ursulin (2020-06-15 15:09:28)
Quoted 65 lines
From: Tvrtko Ursulin <[email protected]>
One
i915_request_await_objectis enough and we keep the one under the object lock so it is final.At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc Michael J. Ruhl <[email protected]>--- .../gpu/drm/i915/gem/i915_gem_object_blt.c | 35 +++++++------------ 1 file changed, 13 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +11
-10@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu (struct drm_i915_gem_object *obj, +struct i915_request *rq, +bool write) +{ +if (obj->cache_dirty & ~obj->cache_coherent) +i915_gem_clflush_object (obj,0 ); + +return i915_request_await_object (rq, obj, write); +} +int i915_gem_object_fill_blt (struct drm_i915_gem_object *obj,struct intel_context *ce,u32 value)@@ -143,12 +154,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err))return err; -if (obj->cache_dirty & ~obj->cache_coherent) { -i915_gem_object_lock (obj); -i915_gem_clflush_object (obj,0 ); -i915_gem_object_unlock (obj); - } - batch =intel_emit_vma_fill_blt (ce, vma, value);if (IS_ERR (batch)) { err =PTR_ERR (batch);@@ -165,10 +170,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err)) goto out_request; - err =i915_request_await_object (rq, obj, true); -if (unlikely (err)) - goto out_request; -if (ce->engine->emit_init_breadcrumb) { err = ce->engine->emit_init_breadcrumb (rq);if (unlikely (err))@@ -176,7 +177,7 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, }
Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, · line 183
Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +1
-1i915_vma_lock (vma); - err =i915_request_await_object (rq, vma->obj, true); + err =move_obj_to_gpu (vma->obj, rq, true);if (err ==0 ) err =i915_vma_move_to_active (vma, rq,EXEC_OBJECT_WRITE );i915_vma_unlock (vma);Ah, but here it's also the wrong side of
init_breadcrumb.
Why it is important to mark the object as active on the failure path? We skip the payload, no?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2020-06-15 15:54:56)
Quoted 77 lines · Chris Wilson
Quoted 66 lines
Quoting Tvrtko Ursulin (2020-06-15 15:09:28)
Quoted 65 lines
From: Tvrtko Ursulin <[email protected]>
One
i915_request_await_objectis enough and we keep the one under the object lock so it is final.At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc Michael J. Ruhl <[email protected]>--- .../gpu/drm/i915/gem/i915_gem_object_blt.c | 35 +++++++------------ 1 file changed, 13 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +11
-10@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu (struct drm_i915_gem_object *obj, +struct i915_request *rq, +bool write) +{ +if (obj->cache_dirty & ~obj->cache_coherent) +i915_gem_clflush_object (obj,0 ); + +return i915_request_await_object (rq, obj, write); +} +int i915_gem_object_fill_blt (struct drm_i915_gem_object *obj,struct intel_context *ce,u32 value)@@ -143,12 +154,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err))return err; -if (obj->cache_dirty & ~obj->cache_coherent) { -i915_gem_object_lock (obj); -i915_gem_clflush_object (obj,0 ); -i915_gem_object_unlock (obj); - } - batch =intel_emit_vma_fill_blt (ce, vma, value);if (IS_ERR (batch)) { err =PTR_ERR (batch);@@ -165,10 +170,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err)) goto out_request; - err =i915_request_await_object (rq, obj, true); -if (unlikely (err)) - goto out_request; -if (ce->engine->emit_init_breadcrumb) { err = ce->engine->emit_init_breadcrumb (rq);if (unlikely (err))@@ -176,7 +177,7 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, }Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, · line 183
Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +1
-1i915_vma_lock (vma); - err =i915_request_await_object (rq, vma->obj, true); + err =move_obj_to_gpu (vma->obj, rq, true);if (err ==0 ) err =i915_vma_move_to_active (vma, rq,EXEC_OBJECT_WRITE );i915_vma_unlock (vma);Ah, but here it's also the wrong side of
init_breadcrumb.
Quoted 2 lines
Why it is important to mark the object as active on the failure path? We skip the payload, no?
It's important that all the async waits are before the breadcrumb. Up until recently we would emit the semaphore after the init, and so believe the payload was running and all waits were completed even though it was still waiting on another request to complete. If this blt request was subsequently relied upon to indicate the other fence completions we would then start other requests early. [It's less important now as we look at a flag saying that the init_breadcrumb has been emitted and avoid adding more semaphores.]
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove redundant i915_request_await_object in blit clears
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Remove redundant i915_request_await_object in blit clears
URL : https://patchwork.freedesktop.org/series/78374/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17949
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/index.html
Known issues
------------
Here are the changes found in Patchwork_17949 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-byt-n2820: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-byt-n2820/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-byt-n2820/igt@debugfs_test@read_all_entries.html
* igt@i915_pm_backlight@basic-brightness:
- fi-whl-u: [PASS][3] -> [DMESG-WARN][4] ([i915#95])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-whl-u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-whl-u/igt@[email protected]
* igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-y/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-tgl-y/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-guc: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-icl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-icl-guc/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-tgl-y/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][11] ([i915#1888]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-tgl-u2/igt@[email protected]
* igt@gem_flink_basic@flink-lifetime:
- fi-tgl-y: [DMESG-WARN][13] ([i915#402]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-y/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-tgl-y/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-byt-j1900/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-byt-j1900/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-glk-dsi/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-glk-dsi/igt@[email protected]
* igt@kms_busy@basic@modeset:
- {fi-tgl-dsi}: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-dsi/igt@kms_busy@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-tgl-dsi/igt@kms_busy@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22] +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-icl-u2/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-icl-u2/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-tgl-u2: [DMESG-WARN][23] ([i915#402]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-u2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-tgl-u2/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-kbl-x1275/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-kbl-x1275/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][27] ([i915#62]) -> [SKIP][28] ([fdo#109271])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-kbl-x1275/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-kbl-x1275: [DMESG-WARN][29] ([i915#62] / [i915#92]) -> [DMESG-WARN][30] ([i915#62] / [i915#92] / [i915#95])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-kbl-x1275/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][31] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][32] ([i915#62] / [i915#92]) +4 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-kbl-x1275/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (50 -> 44)
------------------------------
Additional (1): fi-gdg-551
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8627 -> Patchwork_17949
CI-20190529: 20190529
CI_DRM_8627: 593c112156feb0f6159814f2276a32c90f243823 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5710: f524eee47930601ad7b4cba9d40c26d68dc7d250 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17949: 3c89ad48e5ffb2be20173ef5a9e42950d696d223 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3c89ad48e5ff drm/i915: Remove redundant i915_request_await_object in blit clears
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915: Remove redundant i915_request_await_object in blit clears
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
One i915_request_await_object is enough and we keep the one under the object lock so it is final.
At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
v2:
* Emit initial breadcrumbs after aways are set up. (Chris)
--- .../gpu/drm/i915/gem/i915_gem_object_blt.c | 52 ++++++++----------- 1 file changed, 21 insertions(+), 31 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +21 -31
@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu (struct drm_i915_gem_object *obj, +struct i915_request *rq, +bool write) +{ +if (obj->cache_dirty & ~obj->cache_coherent) +i915_gem_clflush_object (obj,0 ); + +return i915_request_await_object (rq, obj, write); +} +int i915_gem_object_fill_blt (struct drm_i915_gem_object *obj,struct intel_context *ce,u32 value)
@@ -143,12 +154,6 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err))return err; -if (obj->cache_dirty & ~obj->cache_coherent) { -i915_gem_object_lock (obj); -i915_gem_clflush_object (obj,0 ); -i915_gem_object_unlock (obj); - } - batch =intel_emit_vma_fill_blt (ce, vma, value);if (IS_ERR (batch)) { err =PTR_ERR (batch);
@@ -165,27 +170,22 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,if (unlikely (err)) goto out_request; - err =i915_request_await_object (rq, obj, true); -if (unlikely (err)) - goto out_request; - -if (ce->engine->emit_init_breadcrumb) { - err = ce->engine->emit_init_breadcrumb (rq); -if (unlikely (err)) - goto out_request; - } -i915_vma_lock (vma); - err =i915_request_await_object (rq, vma->obj, true); + err =move_obj_to_gpu (vma->obj, rq, true);if (err ==0 ) err =i915_vma_move_to_active (vma, rq,EXEC_OBJECT_WRITE );i915_vma_unlock (vma);if (unlikely (err)) goto out_request; - err = ce->engine->emit_bb_start (rq, - batch->node.start, batch->node.size, -0 ); +if (ce->engine->emit_init_breadcrumb) + err = ce->engine->emit_init_breadcrumb (rq); + +if (likely (!err)) + err = ce->engine->emit_bb_start (rq, + batch->node.start, + batch->node.size, +0 ); out_request:if (unlikely (err))i915_request_set_error_once (rq, err);
@@ -317,16 +317,6 @@ struct i915_vma *intel_emit_vma_copy_blt(struct intel_context *ce,return ERR_PTR (err); } -static int move_to_gpu (struct i915_vma *vma,struct i915_request *rq,bool write) -{ -struct drm_i915_gem_object *obj = vma->obj; - -if (obj->cache_dirty & ~obj->cache_coherent) -i915_gem_clflush_object (obj,0 ); - -return i915_request_await_object (rq, obj, write); -} -int i915_gem_object_copy_blt (struct drm_i915_gem_object *src,struct drm_i915_gem_object *dst,struct intel_context *ce)
@@ -375,7 +365,7 @@ int i915_gem_object_copy_blt(struct drm_i915_gem_object *src, goto out_request;for (i =0 ; i <ARRAY_SIZE (vma); i++) { - err =move_to_gpu (vma[i], rq, i); + err =move_obj_to_gpu (vma[i]->obj, rq, i);if (unlikely (err)) goto out_unlock; }
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 35 lines
-----Original Message-----
From: Tvrtko Ursulin <[email protected]>
Sent: Monday, June 15, 2020 11:15 AM
To: [email protected]
Cc: Ursulin, Tvrtko <[email protected]>; Auld, Matthew <[email protected]>; Chris Wilson <[email protected]>; Ruhl, Michael J <[email protected]>
Subject: [PATCH v2] drm/i915: Remove redundanti915_request_await_objectin blit clearsFrom: Tvrtko Ursulin <[email protected]>
One
i915_request_await_objectis enough and we keep the one under the object lock so it is final.At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
v2:
* Emit initial breadcrumbs after aways are set up. (Chris)Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc Michael J. Ruhl <[email protected]>---
.../gpu/drm/i915/gem/i915_gem_object_blt.c| 52 ++++++++-----------1 file changed, 21 insertions(+), 31 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-0
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c void intel_emit_vma_release(struct intel_context · line 131
Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +2
-0@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu(struct drm_i915_gem_object *obj,
I am not understanding the name of this function.
How is the object moved to the gpu? Is clflush a move? Or is it that it is moving to the gpu domain?
What about:
obj_flush_and_wait()
or just:
flush_and_wait()
?
Or am I missing something? 😊
Mike
Quoted 94 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +9
-0+ struct i915_request *rq, + bool write) +{ +if (obj->cache_dirty & ~obj->cache_coherent) +i915_gem_clflush_object (obj,0 ); + +return i915_request_await_object (rq, obj, write); +} + int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, struct intel_context *ce,u32 value)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-6@@ -143,12 +154,6 @@ int i915_gem_object_fill_blt(structdrm_i915_gem_object *obj, if (unlikely(err)) return err; -if (obj->cache_dirty & ~obj->cache_coherent) { -i915_gem_object_lock (obj); -i915_gem_clflush_object (obj,0 ); -i915_gem_object_unlock (obj); - } - batch =intel_emit_vma_fill_blt (ce, vma, value);if (IS_ERR (batch)) {err = PTR_ERR(batch);drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +9
-14@@ -165,27 +170,22 @@ int i915_gem_object_fill_blt(structdrm_i915_gem_object *obj, if (unlikely(err)) goto out_request; - err = i915_request_await_object(rq, obj, true); -if (unlikely (err)) - goto out_request; - -if (ce->engine->emit_init_breadcrumb) { - err = ce->engine->emit_init_breadcrumb (rq); -if (unlikely (err)) - goto out_request; - } -i915_vma_lock (vma ); - err =i915_request_await_object (rq, vma->obj, true); + err =move_obj_to_gpu (vma->obj, rq, true);if (err ==0 ) err =i915_vma_move_to_active (vma, rq,EXEC_OBJECT_WRITE );i915_vma_unlock (vma);if (unlikely (err)) goto out_request; - err = ce->engine->emit_bb_start (rq, - batch->node.start, batch->node.size, -0 ); +if (ce->engine->emit_init_breadcrumb) + err = ce->engine->emit_init_breadcrumb (rq); + +if (likely (!err)) + err = ce->engine->emit_bb_start (rq, + batch->node.start, + batch->node.size, +0 );
out_request:if (unlikely(err)) i915_request_set_error_once(rq, err);drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-10@@ -317,16 +317,6 @@ struct i915_vma *intel_emit_vma_copy_blt(structintel_context *ce, return ERR_PTR(err); } -static int move_to_gpu (struct i915_vma *vma,struct i915_request *rq,bool write) -{ -struct drm_i915_gem_object *obj = vma->obj; - -if (obj->cache_dirty & ~obj->cache_coherent) -i915_gem_clflush_object (obj,0 ); - -return i915_request_await_object (rq, obj, write); -} - int i915_gem_object_copy_blt(struct drm_i915_gem_object *src,struct
drm_i915_gem_object*dst, structintel_context*ce)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +1
-1@@ -375,7 +365,7 @@ int i915_gem_object_copy_blt(structdrm_i915_gem_object *src, goto out_request;for (i =0 ; i <ARRAY_SIZE (vma); i++) { - err =move_to_gpu (vma[i], rq, i); + err =move_obj_to_gpu (vma[i]->obj, rq, i);if (unlikely (err)) goto out_unlock;}
Quoted 2 lines
--
2.20.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 51 lines · Michael J
Quoted 35 lines
-----Original Message-----
From: Tvrtko Ursulin <[email protected]>
Sent: Monday, June 15, 2020 11:15 AM
To: [email protected]
Cc: Ursulin, Tvrtko <[email protected]>; Auld, Matthew <[email protected]>; Chris Wilson <[email protected]>; Ruhl, Michael J <[email protected]>
Subject: [PATCH v2] drm/i915: Remove redundanti915_request_await_objectin blit clearsFrom: Tvrtko Ursulin <[email protected]>
One
i915_request_await_objectis enough and we keep the one under the object lock so it is final.At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
v2:
* Emit initial breadcrumbs after aways are set up. (Chris)Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc Michael J. Ruhl <[email protected]>---
.../gpu/drm/i915/gem/i915_gem_object_blt.c| 52 ++++++++-----------1 file changed, 21 insertions(+), 31 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-0drivers/gpu/drm/i915/gem/i915_gem_object_blt.c void intel_emit_vma_release(struct intel_context · line 131
Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +2
-0@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu(struct drm_i915_gem_object *obj,I am not understanding the name of this function.
How is the object moved to the gpu? Is clflush a move? Or is it that it is moving to the gpu domain?
What about:
obj_flush_and_wait()
Quoted 7 lines
or just:
flush_and_wait()?
Or am I missing something? 😊
Yes, the fact I have renamed the existing move_to_gpu to move_obj_to_gpu while moving it up in the file and so risked falling victim to bike shedding now. :D
Regards,
Tvrtko
Quoted 91 lines
Mike
Quoted 88 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +9
-0+ struct i915_request *rq, + bool write) +{ +if (obj->cache_dirty & ~obj->cache_coherent) +i915_gem_clflush_object (obj,0 ); + +return i915_request_await_object (rq, obj, write); +} + int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, struct intel_context *ce,u32 value)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-6@@ -143,12 +154,6 @@ int i915_gem_object_fill_blt(structdrm_i915_gem_object *obj, if (unlikely(err)) return err; -if (obj->cache_dirty & ~obj->cache_coherent) { -i915_gem_object_lock (obj); -i915_gem_clflush_object (obj,0 ); -i915_gem_object_unlock (obj); - } - batch =intel_emit_vma_fill_blt (ce, vma, value);if (IS_ERR (batch)) {err = PTR_ERR(batch);drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +9
-14@@ -165,27 +170,22 @@ int i915_gem_object_fill_blt(structdrm_i915_gem_object *obj, if (unlikely(err)) goto out_request; - err = i915_request_await_object(rq, obj, true); -if (unlikely (err)) - goto out_request; - -if (ce->engine->emit_init_breadcrumb) { - err = ce->engine->emit_init_breadcrumb (rq); -if (unlikely (err)) - goto out_request; - } -i915_vma_lock (vma ); - err =i915_request_await_object (rq, vma->obj, true); + err =move_obj_to_gpu (vma->obj, rq, true);if (err ==0 ) err =i915_vma_move_to_active (vma, rq,EXEC_OBJECT_WRITE );i915_vma_unlock (vma);if (unlikely (err)) goto out_request; - err = ce->engine->emit_bb_start (rq, - batch->node.start, batch->node.size, -0 ); +if (ce->engine->emit_init_breadcrumb) + err = ce->engine->emit_init_breadcrumb (rq); + +if (likely (!err)) + err = ce->engine->emit_bb_start (rq, + batch->node.start, + batch->node.size, +0 );
out_request:if (unlikely(err)) i915_request_set_error_once(rq, err);drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-10@@ -317,16 +317,6 @@ struct i915_vma *intel_emit_vma_copy_blt(structintel_context *ce, return ERR_PTR(err); } -static int move_to_gpu (struct i915_vma *vma,struct i915_request *rq,bool write) -{ -struct drm_i915_gem_object *obj = vma->obj; - -if (obj->cache_dirty & ~obj->cache_coherent) -i915_gem_clflush_object (obj,0 ); - -return i915_request_await_object (rq, obj, write); -} - int i915_gem_object_copy_blt(struct drm_i915_gem_object *src,struct
drm_i915_gem_object*dst, structintel_context*ce)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-0@@ -375,7 +365,7 @@ int i915_gem_object_copy_blt(structdrm_i915_gem_object *src, goto out_request;
Quoted 9 lines
Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +1
-1for (i =0 ; i <ARRAY_SIZE (vma); i++) { - err =move_to_gpu (vma[i], rq, i); + err =move_obj_to_gpu (vma[i]->obj, rq, i);if (unlikely (err)) goto out_unlock;}--
2.20.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Ruhl, Michael J
Reviewed-byQuoted 69 lines
-----Original Message-----
From: Tvrtko Ursulin <[email protected]>
Sent: Monday, June 15, 2020 12:16 PM
To: Ruhl, Michael J <[email protected]>; Intel- [email protected]
Cc: Ursulin, Tvrtko <[email protected]>; Auld, Matthew <[email protected]>; Chris Wilson <[email protected]>
Subject: Re: [PATCH v2] drm/i915: Remove redundanti915_request_await_objectin blit clearsQuoted 6 lines · Michael J
Quoted 6 lines
-----Original Message-----
From: Tvrtko Ursulin <[email protected]>
Sent: Monday, June 15, 2020 11:15 AM
To: [email protected]
Cc: Ursulin, Tvrtko <[email protected]>; Auld, Matthew <[email protected]>; Chris Wilson <[email protected]>;Ruhl,
Quoted 2 lines
Quoted 2 lines
Michael J <[email protected]>
Subject: [PATCH v2] drm/i915: Remove redundant
i915_request_await_objectQuoted 47 lines
Quoted 27 lines
in blit clears
From: Tvrtko Ursulin <[email protected]>
One
i915_request_await_objectis enough and we keep the one under the object lock so it is final.At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
v2:
* Emit initial breadcrumbs after aways are set up. (Chris)Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc Michael J. Ruhl <[email protected]>---
.../gpu/drm/i915/gem/i915_gem_object_blt.c| 52 ++++++++-----------1 file changed, 21 insertions(+), 31 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-0drivers/gpu/drm/i915/gem/i915_gem_object_blt.c void intel_emit_vma_release(struct intel_context · line 131
Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +2
-0@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu(struct drm_i915_gem_object *obj,I am not understanding the name of this function.
How is the object moved to the gpu? Is clflush a move? Or is it that it is moving to the gpu domain?
What about:
obj_flush_and_wait()or just:
flush_and_wait()
Quoted 7 lines
Quoted 3 lines
?
Or am I missing something? 😊
Yes, the fact I have renamed the existing
move_to_gputomove_obj_to_gpuwhile moving it up in the file and so risked falling victim to bike shedding now. :D
Ok.
Code path makes sense to me.
M
Quoted 78 lines
Regards,
Tvrtko
Quoted 73 lines
Mike
Quoted 70 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +9
-0+ struct i915_request *rq, + bool write) +{ +if (obj->cache_dirty & ~obj->cache_coherent) +i915_gem_clflush_object (obj,0 ); + +return i915_request_await_object (rq, obj, write); +} + int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, struct intel_context *ce,u32 value)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-6@@ -143,12 +154,6 @@ int i915_gem_object_fill_blt(structdrm_i915_gem_object *obj, if (unlikely(err)) return err; -if (obj->cache_dirty & ~obj->cache_coherent) { -i915_gem_object_lock (obj); -i915_gem_clflush_object (obj,0 ); -i915_gem_object_unlock (obj); - } - batch =intel_emit_vma_fill_blt (ce, vma, value);if (IS_ERR (batch)) {err = PTR_ERR(batch);drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +9
-14@@ -165,27 +170,22 @@ int i915_gem_object_fill_blt(structdrm_i915_gem_object *obj, if (unlikely(err)) goto out_request; - err = i915_request_await_object(rq, obj, true); -if (unlikely (err)) - goto out_request; - -if (ce->engine->emit_init_breadcrumb) { - err = ce->engine->emit_init_breadcrumb (rq); -if (unlikely (err)) - goto out_request; - } -i915_vma_lock (vma ); - err =i915_request_await_object (rq, vma->obj, true); + err =move_obj_to_gpu (vma->obj, rq, true);if (err ==0 ) err =i915_vma_move_to_active (vma, rq,EXEC_OBJECT_WRITE );i915_vma_unlock (vma);if (unlikely (err)) goto out_request; - err = ce->engine->emit_bb_start (rq, - batch->node.start, batch->node.size, -0 ); +if (ce->engine->emit_init_breadcrumb) + err = ce->engine->emit_init_breadcrumb (rq); + +if (likely (!err)) + err = ce->engine->emit_bb_start (rq, + batch->node.start, + batch->node.size, +0 );
out_request:if (unlikely(err)) i915_request_set_error_once(rq, err);drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-0@@ -317,16 +317,6 @@ struct i915_vma *intel_emit_vma_copy_blt(structintel_context *ce, return ERR_PTR(err); }
Quoted 28 lines
Quoted 1 line
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c struct i915_vma *intel_emit_vma_copy_blt(struct · line 321
Quoted 1 line
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-1-static int move_to_gpu(struct i915_vma *vma, struct i915_request *rq,bool
Quoted 26 lines
Quoted 25 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-9write) -{ -struct drm_i915_gem_object *obj = vma->obj; - -if (obj->cache_dirty & ~obj->cache_coherent) -i915_gem_clflush_object (obj,0 ); - -return i915_request_await_object (rq, obj, write); -} - int i915_gem_object_copy_blt(struct drm_i915_gem_object *src,struct
drm_i915_gem_object*dst, structintel_context*ce)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +1
-1@@ -375,7 +365,7 @@ int i915_gem_object_copy_blt(structdrm_i915_gem_object *src, goto out_request;for (i =0 ; i <ARRAY_SIZE (vma); i++) { - err =move_to_gpu (vma[i], rq, i); + err =move_obj_to_gpu (vma[i]->obj, rq, i);if (unlikely (err)) goto out_unlock;}--
2.20.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2020-06-15 16:14:49)
Quoted 10 lines
From: Tvrtko Ursulin <[email protected]>
One
i915_request_await_objectis enough and we keep the one under the object lock so it is final.At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function.
v2:
* Emit initial breadcrumbs after aways are set up. (Chris)
s/aways/awaits/
Quoted 13 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc Michael J. Ruhl <[email protected]>--- .../gpu/drm/i915/gem/i915_gem_object_blt.c | 52 ++++++++----------- 1 file changed, 21 insertions(+), 31 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +0
-0
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma) · line 132
Quoted 7 lines
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +4
-0@@ -126,6 +126,17 @@ void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)intel_engine_pm_put (ce->engine); } +static int +move_obj_to_gpu (struct drm_i915_gem_object *obj, +struct i915_request *rq, +bool write)
* shrug, I prefer to think in terms of vma, but even vma are unlikely to be the final form here.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove redundant i915_request_await_object in blit clears (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Remove redundant i915_request_await_object in blit clears (rev2)
URL : https://patchwork.freedesktop.org/series/78374/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17953
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/index.html
Known issues
------------
Here are the changes found in Patchwork_17953 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-tgl-u2/igt@[email protected]
* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-byt-j1900/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-byt-j1900/igt@[email protected]
* igt@i915_pm_backlight@basic-brightness:
- fi-whl-u: [PASS][5] -> [DMESG-WARN][6] ([i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-whl-u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-whl-u/igt@[email protected]
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][7] -> [DMESG-WARN][8] ([i915#62] / [i915#92] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-kbl-x1275/igt@kms_busy@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-kbl-x1275/igt@kms_busy@[email protected]
* igt@vgem_basic@setversion:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#402]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-tgl-y/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][11] ([i915#1888]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-tgl-u2/igt@[email protected]
* igt@gem_flink_basic@flink-lifetime:
- fi-tgl-y: [DMESG-WARN][13] ([i915#402]) -> [PASS][14] +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-y/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-tgl-y/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-byt-j1900/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-byt-j1900/igt@[email protected]
* igt@kms_busy@basic@modeset:
- {fi-tgl-dsi}: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-tgl-dsi/igt@kms_busy@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-tgl-dsi/igt@kms_busy@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20] +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-icl-u2/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-icl-u2/igt@kms_flip@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][22] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-kbl-x1275/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-kbl-x1275/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/fi-kbl-x1275/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (50 -> 44)
------------------------------
Additional (1): fi-gdg-551
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8627 -> Patchwork_17953
CI-20190529: 20190529
CI_DRM_8627: 593c112156feb0f6159814f2276a32c90f243823 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5710: f524eee47930601ad7b4cba9d40c26d68dc7d250 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17953: ad451451c90b1e063dd032f5ed563f501ff0350c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ad451451c90b drm/i915: Remove redundant i915_request_await_object in blit clears
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove redundant i915_request_await_object in blit clears
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Remove redundant i915_request_await_object in blit clears
URL : https://patchwork.freedesktop.org/series/78374/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8627_full -> Patchwork_17949_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17949_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@processes:
- shard-skl: [PASS][1] -> [FAIL][2] ([i915#1528])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-skl3/igt@[email protected]
* igt@kms_big_fb@linear-64bpp-rotate-0:
- shard-glk: [PASS][3] -> [DMESG-FAIL][4] ([i915#118] / [i915#95])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-glk5/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-glk8/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-apl2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-apl3/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +9 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-kbl3/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-kbl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-iclb: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-iclb8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-iclb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc:
- shard-tglb: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite:
- shard-skl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl9/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145] / [i915#265])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-skl5/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
* igt@kms_sequence@queue-idle:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#93] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-kbl3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-kbl4/igt@[email protected]
* igt@kms_vblank@pipe-c-wait-busy-hang:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#95]) +16 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-apl8/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-apl1/igt@[email protected]
* igt@perf_pmu@semaphore-busy@rcs0:
- shard-kbl: [PASS][23] -> [FAIL][24] ([i915#1820])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-kbl3/igt@perf_pmu@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-kbl1/igt@perf_pmu@[email protected]
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#1755])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl2/igt@sysfs_timeslice_duration@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-skl4/igt@sysfs_timeslice_duration@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@sliced:
- shard-tglb: [TIMEOUT][27] ([i915#1936]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-tglb3/igt@[email protected]
* igt@gem_exec_schedule@implicit-read-write@rcs0:
- shard-snb: [INCOMPLETE][29] ([i915#82]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-snb2/igt@gem_exec_schedule@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-snb2/igt@gem_exec_schedule@[email protected]
* {igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing@edp-1-pipe-a}:
- shard-tglb: [DMESG-WARN][31] ([i915#1982]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb1/igt@kms_atomic_transition@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-tglb7/igt@kms_atomic_transition@[email protected]
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-apl: [DMESG-WARN][33] ([i915#1982]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-apl4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-apl7/igt@[email protected]
* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- shard-apl: [DMESG-WARN][35] ([i915#95]) -> [PASS][36] +16 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-apl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-apl2/igt@[email protected]
* igt@kms_flip@2x-wf_vblank-ts-check@ab-hdmi-a1-hdmi-a2:
- shard-glk: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-glk1/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-glk6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-dpms-off-vs-modeset@a-edp1:
- shard-tglb: [DMESG-WARN][39] ([i915#402]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb7/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-tglb3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-panning-interruptible@a-edp1:
- shard-skl: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42] +9 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl9/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][43] ([i915#1928]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl8/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][45] ([i915#173]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-iclb1/igt@kms_psr@no_drrs.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-iclb6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][47] ([fdo#109441]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-tglb: [TIMEOUT][49] -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb6/igt@kms_psr@psr2_sprite_mmap_cpu.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-tglb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@perf@blocking-parameterized:
- shard-iclb: [FAIL][51] ([i915#1542]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-iclb4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-iclb8/igt@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][53] ([i915#454]) -> [SKIP][54] ([i915#468])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb3/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-tglb2/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [DMESG-FAIL][55] ([i915#1982]) -> [FAIL][56] ([i915#454])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-skl3/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-kbl: [TIMEOUT][57] ([i915#1319] / [i915#1958]) -> [TIMEOUT][58] ([i915#1319])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-kbl4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-kbl7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-kbl: [DMESG-WARN][59] ([i915#180]) -> [INCOMPLETE][60] ([i915#155])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-kbl6/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-kbl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-tglb: [TIMEOUT][61] -> [SKIP][62] ([fdo#111825])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1820]: https://gitlab.freedesktop.org/drm/intel/issues/1820
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1936]: https://gitlab.freedesktop.org/drm/intel/issues/1936
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8627 -> Patchwork_17949
CI-20190529: 20190529
CI_DRM_8627: 593c112156feb0f6159814f2276a32c90f243823 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5710: f524eee47930601ad7b4cba9d40c26d68dc7d250 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17949: 3c89ad48e5ffb2be20173ef5a9e42950d696d223 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17949/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove redundant i915_request_await_object in blit clears (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Remove redundant i915_request_await_object in blit clears (rev2)
URL : https://patchwork.freedesktop.org/series/78374/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8627_full -> Patchwork_17953_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17953_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-glk: [PASS][1] -> [DMESG-FAIL][2] ([i915#118] / [i915#95])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-glk7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-glk8/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-kbl6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-kbl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#300])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl10/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-skl3/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#46])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl2/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-skl5/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt:
- shard-tglb: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite:
- shard-skl: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl9/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [i915#265]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-skl2/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-c-wait-busy-hang:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#95]) +6 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-apl8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-apl7/igt@[email protected]
* igt@perf_pmu@semaphore-busy@rcs0:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#1820])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-kbl3/igt@perf_pmu@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-kbl7/igt@perf_pmu@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@sliced:
- shard-tglb: [TIMEOUT][21] ([i915#1936]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-tglb2/igt@[email protected]
* {igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing@edp-1-pipe-a}:
- shard-tglb: [DMESG-WARN][23] ([i915#1982]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb1/igt@kms_atomic_transition@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-tglb6/igt@kms_atomic_transition@[email protected]
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-apl: [DMESG-WARN][25] ([i915#1982]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-apl4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-apl3/igt@[email protected]
- shard-glk: [DMESG-FAIL][27] ([i915#118] / [i915#95]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-glk8/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-glk5/igt@[email protected]
* igt@kms_flip@flip-vs-dpms-off-vs-modeset@a-edp1:
- shard-tglb: [DMESG-WARN][29] ([i915#402]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb7/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-tglb2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-panning-interruptible@a-edp1:
- shard-skl: [DMESG-WARN][31] ([i915#1982]) -> [PASS][32] +11 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl9/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][33] ([i915#180]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-kbl6/igt@kms_flip@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-kbl3/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][35] ([i915#1928]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl8/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][37] ([i915#1188]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-skl4/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-primary-size-256:
- shard-glk: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-glk9/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-glk1/igt@[email protected]
* igt@kms_properties@invalid-properties-atomic:
- shard-apl: [DMESG-WARN][41] ([i915#95]) -> [PASS][42] +15 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-apl1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-apl3/igt@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][43] ([i915#173]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-iclb1/igt@kms_psr@no_drrs.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-iclb7/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-tglb: [TIMEOUT][47] -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb6/igt@kms_psr@psr2_sprite_mmap_cpu.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-tglb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@syncobj_wait@multi-wait-for-submit-unsubmitted-submitted:
- shard-snb: [TIMEOUT][49] ([i915#1958]) -> [PASS][50] +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-snb6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-snb4/igt@[email protected]
#### Warnings ####
* igt@gem_exec_balancer@invalid-bonds:
- shard-snb: [TIMEOUT][51] ([i915#1958]) -> [SKIP][52] ([fdo#109271]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-snb6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-snb4/igt@[email protected]
* igt@gem_exec_reloc@basic-concurrent16:
- shard-snb: [TIMEOUT][53] ([i915#1958]) -> [FAIL][54] ([i915#1930])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-snb6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-snb4/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-skl: [SKIP][55] ([fdo#109271] / [i915#658]) -> [INCOMPLETE][56] ([i915#198])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-skl8/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-skl5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-tglb: [TIMEOUT][57] -> [SKIP][58] ([fdo#111825])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8627/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-pwrite.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1820]: https://gitlab.freedesktop.org/drm/intel/issues/1820
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1936]: https://gitlab.freedesktop.org/drm/intel/issues/1936
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8627 -> Patchwork_17953
CI-20190529: 20190529
CI_DRM_8627: 593c112156feb0f6159814f2276a32c90f243823 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5710: f524eee47930601ad7b4cba9d40c26d68dc7d250 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17953: ad451451c90b1e063dd032f5ed563f501ff0350c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17953/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx