staging: rts5208: Use array_size() helper in vmalloc()
PATCH 1/1 staging: rts5208: Use array_size() helper in vmalloc()
and memset()
The vmalloc() function has no 2-factor argument form, so multiplication factors need to be wrapped in array_size(). Also, while there, use array_size() in memset().
This issue was found with the help of Coccinelle and, audited and fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
--- drivers/staging/rts5208/ms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rts5208/ms.c +3 -3
@@ -2306,14 +2306,14 @@ static int ms_build_l2p_tbl(struct rtsx_chip *chip, int seg_no)if (!segment->l2p_table) goto BUILD_FAIL; } -memset ((u8 *)(segment->l2p_table),0xff , table_size *2 ); +memset ((u8 *)(segment->l2p_table),0xff ,array_size (table_size,2 ));if (!segment->free_table) { - segment->free_table =vmalloc (MS_FREE_TABLE_CNT *2 ); + segment->free_table =vmalloc (array_size (MS_FREE_TABLE_CNT ,2 ));if (!segment->free_table) goto BUILD_FAIL; } -memset ((u8 *)(segment->free_table),0xff ,MS_FREE_TABLE_CNT *2 ); +memset ((u8 *)(segment->free_table),0xff ,array_size (MS_FREE_TABLE_CNT ,2 )); start = (u16 )seg_no <<9 ; end = (u16)(seg_no +1 ) <<9 ;
Signature · 1 line
2.27.0
Quoted 1 line · Gustavo A. R. Silva
and
memset()
Please don't start the commit message in the middle of a sentence. It's a completely different thing from the title. When you're reading the full email then the title is hidden in the headers and the Date: and
Message-ID: field go in between the title and the message body.
https://lore.kernel.org/lkml/20200615230811.GA18818@embeddedor/
I normally read either the title or the body but seldom read both when I'm reviewing patches.
regards,
dan carpenter
Quoted 5 lines · Dan Carpenter
Quoted 1 line · Gustavo A. R. Silva
and
memset()Please don't start the commit message in the middle of a sentence. It's
That was, certainly, unintentional. Thanks for letting me know.
--
Gustavo