Skip to contentSkip to conversation

sound: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845

PATCH Superseded John Stultz 3 participants 5 messages Jun 16, 2020

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sound: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845

CROS_EC isn't strictly required for audio to work on other SDM845 platforms (like the Dragonboard 845c).

So lets remove the dependency and select the related CROS_EC options if CROS_EC is already enabled.

Cc Srinivas Kandagatla <[email protected]>
Cc Rohit kumar <[email protected]>
Cc Patrick Lai <[email protected]>
Cc Banajit Goswami <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Jaroslav Kysela <[email protected]>
Cc Takashi Iwai <[email protected]>
---
 sound/soc/qcom/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/qcom/Kconfig +2 -2
index f51b28d1b94d..0434f2c7d746 100644
@@ -99,12 +99,12 @@ config SND_SOC_MSM8996
 
 config SND_SOC_SDM845
 	tristate "SoC Machine driver for SDM845 boards"
-	depends on QCOM_APR && CROS_EC && I2C && SOUNDWIRE
+	depends on QCOM_APR && I2C && SOUNDWIRE
 	select SND_SOC_QDSP6
 	select SND_SOC_QCOM_COMMON
 	select SND_SOC_RT5663
 	select SND_SOC_MAX98927
-	select SND_SOC_CROS_EC_CODEC
+	select SND_SOC_CROS_EC_CODEC if CROS_EC
 	help
 	  To add support for audio on Qualcomm Technologies Inc.
 	  SDM845 SoC-based systems.
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · John Stultz

CROS_EC isn't strictly required for audio to work on other SDM845 platforms (like the Dragonboard 845c).

So lets remove the dependency and select the related CROS_EC options if CROS_EC is already enabled.

Sorry John, totally missed this one out!

Quoted 21 lines
Cc Srinivas Kandagatla <[email protected]>
Cc Rohit kumar <[email protected]>
Cc Patrick Lai <[email protected]>
Cc Banajit Goswami <[email protected]>
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Jaroslav Kysela <[email protected]>
Cc Takashi Iwai <[email protected]>
---
  sound/soc/qcom/Kconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/qcom/Kconfig +0 -0
index f51b28d1b94d..0434f2c7d746 100644
@@ -99,12 +99,12 @@ config SND_SOC_MSM8996
 

sound/soc/qcom/Kconfig config SND_SOC_MSM8996 · line 107

Quoted 10 lines
sound/soc/qcom/Kconfig +2 -2
  config SND_SOC_SDM845
  	tristate "SoC Machine driver for SDM845 boards"
-	depends on QCOM_APR && CROS_EC && I2C && SOUNDWIRE
+	depends on QCOM_APR && I2C && SOUNDWIRE
  	select SND_SOC_QDSP6
  	select SND_SOC_QCOM_COMMON
  	select SND_SOC_RT5663
  	select SND_SOC_MAX98927
-	select SND_SOC_CROS_EC_CODEC
+	select SND_SOC_CROS_EC_CODEC if CROS_EC

Isn't "imply SND_SOC_CROS_EC_CODEC" better option here?

--srini

Quoted 4 lines
sound/soc/qcom/Kconfig +0 -0
  	help
  	  To add support for audio on Qualcomm Technologies Inc.
  	  SDM845 SoC-based systems.
#2 lore raw
Quoted 8 lines · Srinivas Kandagatla
Quoted 5 lines · John Stultz

CROS_EC isn't strictly required for audio to work on other SDM845 platforms (like the Dragonboard 845c).

So lets remove the dependency and select the related CROS_EC options if CROS_EC is already enabled.

Sorry John, totally missed this one out!

No worries!

Quoted 6 lines
Quoted 6 lines
sound/soc/qcom/Kconfig +0 -0
index f51b28d1b94d..0434f2c7d746 100644
@@ -99,12 +99,12 @@ config SND_SOC_MSM8996
 
Quoted 12 lines

sound/soc/qcom/Kconfig config SND_SOC_MSM8996 · line 107

Quoted 10 lines
sound/soc/qcom/Kconfig +2 -2
  config SND_SOC_SDM845
      tristate "SoC Machine driver for SDM845 boards"
-     depends on QCOM_APR && CROS_EC && I2C && SOUNDWIRE
+     depends on QCOM_APR && I2C && SOUNDWIRE
      select SND_SOC_QDSP6
      select SND_SOC_QCOM_COMMON
      select SND_SOC_RT5663
      select SND_SOC_MAX98927
-     select SND_SOC_CROS_EC_CODEC
+     select SND_SOC_CROS_EC_CODEC if CROS_EC

Isn't "imply SND_SOC_CROS_EC_CODEC" better option here?

I've honestly not gotten my head around "imply", so I'll have to take a closer look.
What I have in this patch least is easier to compare and match with the existing code. :)

Thanks for the feedback!
-john

maintainer
#3 lore raw
Quoted 10 lines · John Stultz

On Tue, Jun 16, 2020 at 1:25 AM Srinivas Kandagatla

Quoted 3 lines
Quoted 1 line

+ select SND_SOC_CROS_EC_CODEC if CROS_EC

Isn't "imply SND_SOC_CROS_EC_CODEC" better option here?

I've honestly not gotten my head around "imply", so I'll have to take a closer look.
What I have in this patch least is easier to compare and match with the existing code. :)

It's a conditional select which enables a Kconfig symbol if its dependencies are enabled rather than forcing it on regardless of them, avoiding most of the errors that select tends to introduce with missing dependencies.

maintainer
#4 lore raw
In reply to John Stultz
Quoted 2 lines · John Stultz

CROS_EC isn't strictly required for audio to work on other SDM845 platforms (like the Dragonboard 845c).

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.