Skip to contentSkip to conversation

usb: dwc2: suspend/resume support for DWC2_POWER_DOWN_PARAM_NONE case

Query Jisheng Zhang 2 participants 2 messages Jun 16, 2020 USB

lore
Share & tools
lore
#0 lore raw

Hi,

After reading current dwc2 code, I got an impression that resume from suspend to ram isn't supported for DWC2_POWER_DOWN_PARAM_NONE case, right? In fact we do see usb device can't resume properly with DWC2_POWER_DOWN_PARAM_NONE case.

If the impression is true, what's the proper technical direction? Add dwc2_host_enter_suspend() as dwc2_host_enter_hibernation() and
dwc2_host_exit_suspend() as dwc2_host_exit_hibernation()?

Thanks in advance,
Jisheng

#1 lore raw

Hi Jisheng,

Quoted 4 lines · Jisheng Zhang

Hi,

After reading current dwc2 code, I got an impression that resume from suspend to ram isn't supported for DWC2_POWER_DOWN_PARAM_NONE case, right? In fact

'ram' Do you mean on suspend save registers in RAM?
If yes, then in case when power_down is _NONE then no any register saving/restoring to/from RAM should be performing.

Quoted 2 lines

we do see usb device can't resume properly with DWC2_POWER_DOWN_PARAM_NONE case.

If you see any issue on resume in mentioned case then more probably is some another issue which can debugged.

Quoted 8 lines

If the impression is true, what's the proper technical direction? Add dwc2_host_enter_suspend() as dwc2_host_enter_hibernation() and
dwc2_host_exit_suspend() as dwc2_host_exit_hibernation()?

Thanks in advance,
Jisheng

Thanks,
Minas