Skip to contentSkip to conversation

Input: mxs-lradc-ts - execute mxs_lradc_ts_stop() only once

PATCH New Fabio Estevam 1 participant 1 message Jun 17, 2020

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 Input: mxs-lradc-ts - execute mxs_lradc_ts_stop() only once

Currently mxs_lradc_ts_stop() is unnecessarily executed several times as it is placed inside a for loop.

Executing it only once is enough, so move it outside the for loop.

---
 drivers/input/touchscreen/mxs-lradc-ts.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/input/touchscreen/mxs-lradc-ts.c +1 -2
index 9e36fee38d61..d42203b14335 100644
@@ -669,6 +669,7 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
 		return ret;
 
 	mxs_lradc_ts_hw_init(ts);
+	mxs_lradc_ts_stop(ts);
 
 	for (i = 0; i < 3; i++) {
 		irq = platform_get_irq_byname(pdev, mxs_lradc_ts_irq_names[i]);
@@ -677,8 +678,6 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
 
 		virq = irq_of_parse_and_map(node, irq);
 
-		mxs_lradc_ts_stop(ts);
-
 		ret = devm_request_irq(dev, virq,
 				       mxs_lradc_ts_handle_irq,
 				       0, mxs_lradc_ts_irq_names[i], ts);
Signature · 1 line
2.17.1