Skip to contentSkip to conversation

regmap: Fix memory leak from regmap_register_patch

PATCH In review Charles Keepax 2 participants 2 messages Jun 17, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regmap: Fix memory leak from regmap_register_patch

When a register patch is registered the reg_sequence is copied but the memory allocated is never freed. Add a kfree in regmap_exit to clean it up.

Fixes 22f0d90a3482 ("regmap: Support register patch sets")
---
 drivers/base/regmap/regmap.c | 1 +
 1 file changed, 1 insertion(+)
drivers/base/regmap/regmap.c +1 -0
index 94e2e2d1824bb..414422e1a2e6e 100644
@@ -1349,6 +1349,7 @@ void regmap_exit(struct regmap *map)
 	if (map->hwlock)
 		hwspin_lock_free(map->hwlock);
 	kfree_const(map->name);
+	kfree(map->patch);
 	kfree(map);
 }
 EXPORT_SYMBOL_GPL(regmap_exit);
Signature · 1 line
2.11.0
maintainer
#1 lore raw
Quoted 3 lines · Charles Keepax

When a register patch is registered the reg_sequence is copied but the memory allocated is never freed. Add a kfree in regmap_exit to clean it up.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/1] regmap: Fix memory leak from regmap_register_patch

      commit: 95b2c3ec4cb1689db2389c251d39f64490ba641c

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark