Skip to contentSkip to conversation

drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

PATCH In review James Zhu 2 participants 3 messages Jun 17, 2020

Subsystems (2)
lore
Share & tools
lore

James Zhu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

From: kernel test robot <[email protected]>

Fixes c422a628925d ("drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0")
---
 drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c +3 -3
index 261afbb504bd..ba1c4fbc19dc 100644
@@ -443,7 +443,7 @@ static void vcn_v2_5_mc_resume(struct amdgpu_device *adev)
 	}
 }
 
-void vcn_v2_5_mc_resume_dpg_mode(struct amdgpu_device *adev, int inst_idx, bool indirect)
+static void vcn_v2_5_mc_resume_dpg_mode(struct amdgpu_device *adev, int inst_idx, bool indirect)
 {
 	uint32_t size = AMDGPU_GPU_PAGE_ALIGN(adev->vcn.fw->size + 4);
 	uint32_t offset;
@@ -657,7 +657,7 @@ static void vcn_v2_5_disable_clock_gating(struct amdgpu_device *adev)
 	}
 }
 
-void vcn_v2_5_clock_gating_dpg_mode(struct amdgpu_device *adev,
+static void vcn_v2_5_clock_gating_dpg_mode(struct amdgpu_device *adev,
 		uint8_t sram_sel, int inst_idx, uint8_t indirect)
 {
 	uint32_t reg_data = 0;
@@ -1300,7 +1300,7 @@ static int vcn_v2_5_sriov_start(struct amdgpu_device *adev)
 	return vcn_v2_5_mmsch_start(adev, &adev->virt.mm_table);
 }
 
-int vcn_v2_5_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
+static int vcn_v2_5_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
 {
 	int ret_code = 0;
 	uint32_t tmp;
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

[AMD Public Use]

James, please feel free to commit this.

Alex
________________________________
From: amd-gfx <[email protected]> on behalf of James Zhu <[email protected]>
Sent: Wednesday, June 17, 2020 4:41 PM
To: [email protected] <[email protected]>
Cc: Zhu, James <[email protected]>; kernel test robot <[email protected]>
Subject: [PATCH] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

From: kernel test robot <[email protected]>

Fixes c422a628925d ("drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0")
---
 drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c +3 -3
index 261afbb504bd..ba1c4fbc19dc 100644
@@ -443,7 +443,7 @@ static void vcn_v2_5_mc_resume(struct amdgpu_device *adev)
         }
 }
 
-void vcn_v2_5_mc_resume_dpg_mode(struct amdgpu_device *adev, int inst_idx, bool indirect)
+static void vcn_v2_5_mc_resume_dpg_mode(struct amdgpu_device *adev, int inst_idx, bool indirect)
 {
         uint32_t size = AMDGPU_GPU_PAGE_ALIGN(adev->vcn.fw->size + 4);
         uint32_t offset;
@@ -657,7 +657,7 @@ static void vcn_v2_5_disable_clock_gating(struct amdgpu_device *adev)
         }
 }
 
-void vcn_v2_5_clock_gating_dpg_mode(struct amdgpu_device *adev,
+static void vcn_v2_5_clock_gating_dpg_mode(struct amdgpu_device *adev,
                 uint8_t sram_sel, int inst_idx, uint8_t indirect)
 {
         uint32_t reg_data = 0;
@@ -1300,7 +1300,7 @@ static int vcn_v2_5_sriov_start(struct amdgpu_device *adev)
         return vcn_v2_5_mmsch_start(adev, &adev->virt.mm_table);
 }
 
-int vcn_v2_5_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
+static int vcn_v2_5_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
 {
         int ret_code = 0;
         uint32_t tmp;

--
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7Cd1a701be74ff4d1bdea208d812fee91d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637280233359067907&amp;sdata=Fvi%2FAILeziaKyd06ORW0tiscXDQy%2B8vOB6y0tqvmXaI%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

author
#2 lore raw

[AMD Public Use]

sure

Thanks & Best Regards!

James Zhu

________________________________
From: Deucher, Alexander <[email protected]>
Sent: Wednesday, June 17, 2020 4:53 PM
To: Zhu, James <[email protected]>; [email protected] <[email protected]>
Cc: kernel test robot <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

[AMD Public Use]

James, please feel free to commit this.

Alex
________________________________
From: amd-gfx <[email protected]> on behalf of James Zhu <[email protected]>
Sent: Wednesday, June 17, 2020 4:41 PM
To: [email protected] <[email protected]>
Cc: Zhu, James <[email protected]>; kernel test robot <[email protected]>
Subject: [PATCH] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

From: kernel test robot <[email protected]>

Fixes c422a628925d ("drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0")
---
 drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c +3 -3
index 261afbb504bd..ba1c4fbc19dc 100644
@@ -443,7 +443,7 @@ static void vcn_v2_5_mc_resume(struct amdgpu_device *adev)
         }
 }
 
-void vcn_v2_5_mc_resume_dpg_mode(struct amdgpu_device *adev, int inst_idx, bool indirect)
+static void vcn_v2_5_mc_resume_dpg_mode(struct amdgpu_device *adev, int inst_idx, bool indirect)
 {
         uint32_t size = AMDGPU_GPU_PAGE_ALIGN(adev->vcn.fw->size + 4);
         uint32_t offset;
@@ -657,7 +657,7 @@ static void vcn_v2_5_disable_clock_gating(struct amdgpu_device *adev)
         }
 }
 
-void vcn_v2_5_clock_gating_dpg_mode(struct amdgpu_device *adev,
+static void vcn_v2_5_clock_gating_dpg_mode(struct amdgpu_device *adev,
                 uint8_t sram_sel, int inst_idx, uint8_t indirect)
 {
         uint32_t reg_data = 0;
@@ -1300,7 +1300,7 @@ static int vcn_v2_5_sriov_start(struct amdgpu_device *adev)
         return vcn_v2_5_mmsch_start(adev, &adev->virt.mm_table);
 }
 
-int vcn_v2_5_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
+static int vcn_v2_5_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
 {
         int ret_code = 0;
         uint32_t tmp;

--
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7Cd1a701be74ff4d1bdea208d812fee91d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637280233359067907&amp;sdata=Fvi%2FAILeziaKyd06ORW0tiscXDQy%2B8vOB6y0tqvmXaI%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx