drm/vmwgfx: Use struct_size() helper
Subsystems (3)
PATCH 1/1 drm/vmwgfx: Use struct_size() helper
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes.
This code was detected with the help of Coccinelle and, audited and fixed manually.
--- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +1 -1
@@ -1969,7 +1969,7 @@ static int vmw_surface_dirty_alloc(struct vmw_resource *res) num_mip =1 ; num_subres = num_layers * num_mip; - dirty_size =sizeof (*dirty) + num_subres *sizeof (dirty->boxes[0 ]); + dirty_size =struct_size (dirty, boxes, num_subres); acc_size =ttm_round_pot (dirty_size); ret =ttm_mem_global_alloc (vmw_mem_glob (res->dev_priv), acc_size, &ctx);
Signature · 6 lines
2.27.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
I've commited this to our next branch, thanks!
(I'm actually kind of impressed this can be found automatically...)
Roland
Am 17.06.20 um 23:51 schrieb Gustavo A. R. Silva:
Quoted 17 lines
Make use of the
struct_size()helper instead of an open-coded version in order to avoid any potential type mistakes.This code was detected with the help of Coccinelle and, audited and fixed manually.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +0
-0
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c static int vmw_surface_dirty_alloc(struct vmw_resource *res) · line 1975
Quoted 8 lines
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +1
-1@@ -1969,7 +1969,7 @@ static int vmw_surface_dirty_alloc(struct vmw_resource *res) num_mip =1 ; num_subres = num_layers * num_mip; - dirty_size =sizeof (*dirty) + num_subres *sizeof (dirty->boxes[0 ]); + dirty_size =struct_size (dirty, boxes, num_subres); acc_size =ttm_round_pot (dirty_size); ret =ttm_mem_global_alloc (vmw_mem_glob (res->dev_priv), acc_size, &ctx);
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel