mISDN: hfcsusb: Use struct_size() helper
Subsystems (2)
PATCH 1/1 mISDN: hfcsusb: Use struct_size() helper
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes.
This code was detected with the help of Coccinelle and, audited and fixed manually.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/isdn/hardware/mISDN/hfcsusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/isdn/hardware/mISDN/hfcsusb.c +1 -2
@@ -261,8 +261,7 @@ hfcsusb_ph_info(struct hfcsusb *hw) phi->bch[i].Flags = hw->bch[i].Flags; }_queue_data (&dch->dev.D,MPH_INFORMATION_IND ,MISDN_ID_ANY , -sizeof (struct ph_info_dch ) + dch->dev.nrbchan * -sizeof (struct ph_info_ch ), phi,GFP_ATOMIC ); +struct_size (phi, bch, dch->dev.nrbchan), phi,GFP_ATOMIC );kfree (phi); }
Signature · 1 line
2.27.0
From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 17 Jun 2020 18:15:57 -0500
Quoted 7 lines
Make use of the
struct_size()helper instead of an open-coded version in order to avoid any potential type mistakes.This code was detected with the help of Coccinelle and, audited and fixed manually.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thanks.