security: Add a config option to disable security mitigations
Subsystems (2)
RFC PATCH 1/1 security: Add a config option to disable security mitigations
Instead of having to pass 'mitigations=off' on the kernel command line, add a config option that has a similar effect.
Adding this makes it easier to disable mitigations in scenarios where you cannot modify the command line or are unable to pass a command line while booting.
--- kernel/cpu.c | 2 +- security/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-)
kernel/cpu.c +1 -1
@@ -2542,7 +2542,7 @@ early_param("mitigations", mitigations_parse_cmdline);/* mitigations=off */ bool cpu_mitigations_off (void ) { -return cpu_mitigations ==CPU_MITIGATIONS_OFF ; +return cpu_mitigations ==CPU_MITIGATIONS_OFF ||IS_ENABLED (CONFIG_DISABLE_MITIGATIONS ); }EXPORT_SYMBOL_GPL (cpu_mitigations_off);
security/Kconfig +8 -0
@@ -65,6 +65,14 @@ config PAGE_TABLE_ISOLATION See Documentation/x86/pti.rst for more details. +config DISABLE_MITIGATIONS + bool "Disable kernel security mitigations" + default n + help + This turns off the kernel security mitigations. This is + equivalent to passing 'mitigations=off' on the kernel + command line. + config SECURITY_INFINIBAND bool "Infiniband Security Hooks" depends on SECURITY && INFINIBAND
Signature · 1 line
2.27.0
Quoted 6 lines · Pranith Kumar
Instead of having to pass 'mitigations=off' on the kernel command line, add a config option that has a similar effect.
Adding this makes it easier to disable mitigations in scenarios where you cannot modify the command line or are unable to pass a command line while booting.
Better wait to hear from others too, but I think if you want a config, then it better support all possible variations of the option too, not just the 'off' one.
Quoted 12 lines
Signed-off-by Pranith Kumar <[email protected]>--- kernel/cpu.c | 2 +- security/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-)kernel/cpu.c +0
-0
kernel/cpu.c early_param("mitigations", mitigations_parse_cmdline); · line 2546
Quoted 6 lines
kernel/cpu.c +1
-1@@ -2542,7 +2542,7 @@ early_param("mitigations", mitigations_parse_cmdline);/* mitigations=off */ bool cpu_mitigations_off (void ) { -return cpu_mitigations ==CPU_MITIGATIONS_OFF ; +return cpu_mitigations ==CPU_MITIGATIONS_OFF ||IS_ENABLED (CONFIG_DISABLE_MITIGATIONS ); }
So if cmdline asked for this to be auto, but the config is compiled with off then the config always wins according to this.
This conflict makes me think this is probably going to be a bad idea because 2 points of control would create a confusion of which one should be honored.
You can set the cmdline in the config too, have you tried this?
On arm64, I can add additional cmdline paramter in the config
Boot options --> Default kernel command string
On x86 I found this too
Processor type and features --> Built-in kernel command line
Beside that, you can always use kexec to boot a new kernel with extra cmdline option
The command I used in the past (from memory, so worth double checking)
kexec --command-line "$(cat /proc/cmdline) migrations=off" -f Image
security/Kconfig config PAGE_TABLE_ISOLATION · line 70
Quoted 13 lines
kernel/cpu.c +0
-0EXPORT_SYMBOL_GPL (cpu_mitigations_off);security/Kconfig +3
-0@@ -65,6 +65,14 @@ config PAGE_TABLE_ISOLATION See Documentation/x86/pti.rst for more details. +config DISABLE_MITIGATIONS + bool "Disable kernel security mitigations" + default n
No need for default n in general as it is the default anyway :)
HTH.
Thanks
--
Qais Yousef