arm64: kvm: Remove kern_hyp_va from get_vcpu_ptr
PATCH 1/1 arm64: kvm: Remove kern_hyp_va from get_vcpu_ptr
get_vcpu_ptr is an assembly accessor for the percpu value kvm_host_data->host_ctxt.__hyp_running_vcpu. kern_hyp_va only applies to nVHE however __hyp_running_vcpu is always assigned a pointer that has already had kern_hyp_va applied in __kvm_vcpu_run_nvhe.
kern_hyp_va is currently idempotent as it just masks and inserts the tag, but this could change in future and the second application is unnecessary.
---
Built with ARM64_HARDEN_EL2_VECTORS=y and tested on qemu A72 with kvm-unit-tests and booting a VM with kvmtool.
--- arch/arm64/include/asm/kvm_asm.h | 1 - 1 file changed, 1 deletion(-)
arch/arm64/include/asm/kvm_asm.h +0 -1
@@ -143,7 +143,6 @@ extern char __smccc_workaround_1_smc[__SMCCC_WORKAROUND_1_SMC_SZ]; .macro get_vcpu_ptr vcpu, ctxt get_host_ctxt \ctxt, \vcpu ldr \vcpu, [\ctxt, #HOST_CONTEXT_VCPU] - kern_hyp_va \vcpu .endm #endif
Signature · 6 lines
2.27.0.290.gba653c62da-goog _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Hi Andrew,
Quoted 4 lines · Andrew Scull
get_vcpu_ptris an assembly accessor for the percpu valuekvm_host_data->host_ctxt.__hyp_running_vcpu.kern_hyp_vaonly applies to nVHE however__hyp_running_vcpuis always assigned a pointer that has already hadkern_hyp_vaapplied in__kvm_vcpu_run_nvhe.
So it is!
Quoted 3 lines
kern_hyp_vais currently idempotent as it just masks and inserts the tag, but this could change in future and the second application is unnecessary.
Thanks,
James
_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Quoted 8 lines · Andrew Scull
get_vcpu_ptris an assembly accessor for the percpu valuekvm_host_data->host_ctxt.__hyp_running_vcpu.kern_hyp_vaonly applies to nVHE however__hyp_running_vcpuis always assigned a pointer that has already hadkern_hyp_vaapplied in__kvm_vcpu_run_nvhe.
kern_hyp_vais currently idempotent as it just masks and inserts the tag, but this could change in future and the second application is unnecessary.
Applied, thanks!
[1/1] arm64: kvm: Remove kern_hyp_va from get_vcpu_ptr
commit: 2da3ffa6e840b9f8fc65a71326c43b716992861d
Best regards,
Signature · 6 lines
Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm