serial: 8250_mtk: Switch to use platform_get_irq()
Subsystems (2)
PATCH v2 1/1 serial: 8250_mtk: Switch to use platform_get_irq()
platform_get_irq() provides an established error code and error message. Also, it's better to use dedicated API to retrieve Linux IRQ resource.
Signed-off-by Andy Shevchenko <[email protected]>
---
v2: rebase on clean tree
drivers/tty/serial/8250/8250_mtk.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/tty/serial/8250/8250_mtk.c +10 -6
@@ -494,13 +494,17 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p,static int mtk8250_probe (struct platform_device *pdev) {struct uart_8250_port uart = {}; -struct resource *regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -struct resource *irq =platform_get_resource (pdev,IORESOURCE_IRQ ,0 );struct mtk8250_data *data; -int err; +struct resource *regs; +int irq, err; + + irq =platform_get_irq (pdev,0 ); +if (irq <0 ) +return irq; -if (!regs || !irq) { -dev_err (&pdev->dev,"no registers/irq defined\n" ); + regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); +if (!regs) { +dev_err (&pdev->dev,"no registers defined\n" );return -EINVAL ; }
@@ -524,7 +528,7 @@ static int mtk8250_probe(struct platform_device *pdev)spin_lock_init (&uart.port.lock); uart.port.mapbase = regs->start; - uart.port.irq = irq->start; + uart.port.irq = irq; uart.port.pm = mtk8250_do_pm; uart.port.type =PORT_16550 ; uart.port.flags =UPF_BOOT_AUTOCONF |UPF_FIXED_PORT ;
Signature · 1 line
2.27.0.rc2
Quoted 4 lines · Andy Shevchenko
platform_get_irq()provides an established error code and error message. Also, it's better to use dedicated API to retrieve Linux IRQ resource.Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Matthias Brugger <[email protected]>
Quoted 42 lines
---
v2: rebase on clean treedrivers/tty/serial/8250/8250_mtk.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)drivers/tty/serial/8250/8250_mtk.c +10
-6@@ -494,13 +494,17 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p,static int mtk8250_probe (struct platform_device *pdev) {struct uart_8250_port uart = {}; -struct resource *regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -struct resource *irq =platform_get_resource (pdev,IORESOURCE_IRQ ,0 );struct mtk8250_data *data; -int err; +struct resource *regs; +int irq, err; + + irq =platform_get_irq (pdev,0 ); +if (irq <0 ) +return irq; -if (!regs || !irq) { -dev_err (&pdev->dev,"no registers/irq defined\n" ); + regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); +if (!regs) { +dev_err (&pdev->dev,"no registers defined\n" );return -EINVAL ; }@@ -524,7 +528,7 @@ static int mtk8250_probe(struct platform_device *pdev)spin_lock_init (&uart.port.lock); uart.port.mapbase = regs->start; - uart.port.irq = irq->start; + uart.port.irq = irq; uart.port.pm = mtk8250_do_pm; uart.port.type =PORT_16550 ; uart.port.flags =UPF_BOOT_AUTOCONF |UPF_FIXED_PORT ;