vfio/type1: Use struct_size() helper

PATCH New Gustavo A. R. Silva 1 participant 1 message Jun 18, 2020

Subsystems (2)

KVM VFIO driver

lore

Share & tools

lore

Gustavo A. R. Silva

author

2020-06-18 19:16 UTC #0 lore raw

PATCH 1/1 vfio/type1: Use struct_size() helper

Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes.

This code was detected with the help of Coccinelle and, audited and fixed manually.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/vfio/vfio_iommu_type1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/vfio/vfio_iommu_type1.c +1 -1

index 5e556ac9102a..b7e71e10a169 100644
@@ -2493,7 +2493,7 @@ static int vfio_iommu_iova_build_caps(struct vfio_iommu *iommu,
 		return 0;
 	}
 
-	size = sizeof(*cap_iovas) + (iovas * sizeof(*cap_iovas->iova_ranges));
+	size = struct_size(cap_iovas, iova_ranges, iovas);
 
 	cap_iovas = kzalloc(size, GFP_KERNEL);
 	if (!cap_iovas)

Signature · 1 line

2.27.0