package/libopenssl: fix target architecture for MIPS64n32
PATCH 1/1 package/libopenssl: fix target architecture for MIPS64n32
From: Thomas De Schampheleire <[email protected]>
Commit 1ebb35ee5fb7bd5e6278a84ac2c18aa0a38056fb changed the libopenssl target architecture to 'linux-generic64' for 64-bit archs based on BR2_ARCH_IS_64. However, MIPS64n32 has BR2_ARCH_IS_64 set, but is a 32-bit ABI. On such board, libopenssl needs to be configured with linux-generic32 to function properly.
One symptom of this problem is that ssh-keygen hangs on key generation, waiting for more random bits. See [1] for the discussion with openssl upstream.
Thanks to Ronny Meeus for investigating the issue and kudos to the openssl community for their responsive and helpful interaction!
[1] https://mta.openssl.org/pipermail/openssl-users/2020-June/012565.html
--- package/libopenssl/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/libopenssl/Config.in +1 -1
@@ -29,7 +29,7 @@ config BR2_PACKAGE_LIBOPENSSL_TARGET_ARCH # no-asm is needed with generic architectures such as # linux-generic{32,64}, see # https://github.com/openssl/openssl/issues/9839 - default "linux-generic64 no-asm" if BR2_ARCH_IS_64 + default "linux-generic64 no-asm" if BR2_ARCH_IS_64 && !BR2_MIPS_NABI32 default "linux-generic32 no-asm" config BR2_PACKAGE_LIBOPENSSL_BIN
Signature · 1 line
2.26.2
PATCH 1/1 package/libopenssl: fix target architecture for MIPS64n32
Quoted 15 lines · On Fri, 19 Jun 2020 08:50:33 +0200 Thomas De Schampheleire…
From: Thomas De Schampheleire <[email protected]>
Commit
1ebb35ee5fb7bd5e6278a84ac2c18aa0a38056fbchanged the libopenssl target architecture to 'linux-generic64' for 64-bit archs based onBR2_ARCH_IS_64. However, MIPS64n32 hasBR2_ARCH_IS_64set, but is a 32-bit ABI. On such board, libopenssl needs to be configured with linux-generic32 to function properly.One symptom of this problem is that ssh-keygen hangs on key generation, waiting for more random bits. See [1] for the discussion with openssl upstream.
Thanks to Ronny Meeus for investigating the issue and kudos to the openssl community for their responsive and helpful interaction!
Quoted 7 lines
Reported-by Ronny Meeus <[email protected]>Signed-off-by Thomas De Schampheleire <[email protected]>[1] https://mta.openssl.org/pipermail/openssl-users/2020-June/012565.html
--- package/libopenssl/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks a lot for the investigation and fix! I've applied as-is as it is the most immediate fix.
However, I am wondering if we shouldn't make BR2_MIPS_NABI32 *not* select BR2_ARCH_IS_64. Indeed, for most packages (which are running userspace code), mips64n32 *is* a 32-bit architecture.
We could make that even clearer by having a BR2_KERNEL_ARCH_IS_64, if there's anything that needs to know at the kernel level the bitness.
But it overall feels incorrect for BR2_MIPS_NABI32 to select BR2_ARCH_IS_64.
What do you think ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/libopenssl: fix target architecture for MIPS64n32
In reply to Thomas De SchampheleireQuoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> Commit
1ebb35ee5fb7bd5e6278a84ac2c18aa0a38056fbchanged the libopenssl target architecture to 'linux-generic64' for 64-bit archs based onBR2_ARCH_IS_64. However, MIPS64n32 hasBR2_ARCH_IS_64set, but is a 32-bit ABI. On such board, libopenssl needs to be configured with linux-generic32 to function properly.One symptom of this problem is that ssh-keygen hangs on key generation, waiting for more random bits. See [1] for the discussion with openssl upstream.
Quoted 7 lines
Thanks to Ronny Meeus for investigating the issue and kudos to the openssl community for their responsive and helpful interaction!
Reported-by Ronny Meeus <[email protected]>Signed-off-by Thomas De Schampheleire <[email protected]>[1] https://mta.openssl.org/pipermail/openssl-users/2020-June/012565.html
Committed to 2020.02.x and 2020.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard