Skip to contentSkip to conversation

systemd-serialgetty: do not use BindsTo

PATCH New Chen Qi 1 participant 1 message Jun 19, 2020

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

PATCH 1/1 systemd-serialgetty: do not use BindsTo

This unit was changed from 'BindsTo' in the following commit. """
commit f0f359ec9210759f6b4dbfb35d3fba8af208c43a

Author: Jason Wessel <[email protected]>
Date:   Thu Aug 29 07:00:31 2019 -0700

[email protected]: Allow device to fast fail if it does not exist
"""

It was changed back to 'BindTo' in the following commit. """
commit 63bbff61b78c651339c4b18d8376187379ec3b3c

Author: Otavio Salvador <[email protected]>
Date:   Fri Jun 12 14:30:44 2020 -0300

systemd: Sync [email protected] with upstream
"""

This is now causing runtime problem for qemuarm64. The default.target is not reached until a timeout. Output is like below.

"""

root@qemuarm64:~# systemd-analyze
Bootup is not yet finished (org.freedesktop.systemd1.Manager.FinishTimestampMonotonic=0).
Please try again later.
Hint: Use 'systemctl list-jobs' to see active jobs
root@qemuarm64:~# systemctl list-jobs
JOB UNIT TYPE STATE
102 getty.target start waiting
1 multi-user.target start waiting
95 systemd-update-utmp-runlevel.service start waiting
110 [email protected] start waiting
111 dev-hvc0.device start running
"""

We can see that we are waiting for /dev/hvc0, while in fact there's no /dev/hvc0. Jason's commit actually solves such problem.

So restore to use Jason's method. Do not use 'BindsTo'.

---
 .../systemd/systemd-serialgetty/[email protected]          | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/systemd/systemd-serialgetty/[email protected] +2 -1
index 542b905795..549d566009 100644
@@ -11,7 +11,8 @@
 Description=Serial Getty on %I
 Documentation=man:agetty(8) man:systemd-getty-generator(8)
 Documentation=http://0pointer.de/blog/projects/serial-console.html
-BindsTo=dev-%i.device
+PartOf=dev-%i.device
+ConditionPathExists=/dev/%i
 After=dev-%i.device systemd-user-sessions.service plymouth-quit-wait.service getty-pre.target
 After=rc-local.service
 
Signature · 1 line
2.21.0