Skip to contentSkip to conversation

spi: spidev: fix missing octal defines

PATCH In review Vinod Koul 2 participants 2 messages Jun 19, 2020

Subsystems (2)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH 1/1 spi: spidev: fix missing octal defines

Commit 896fa735084e ("spi: spidev_test: Add support for Octal mode data transfers") adds support for octal mode but failed to update userspace header with octal defines causing build error for the spidev tool

spidev_test.c: In function ‘transfer’:
spidev_test.c:131:13: error: ‘SPI_TX_OCTAL’ undeclared (first use in this function); did you mean ‘SPI_TX_DUAL’?
if (mode & SPI_TX_OCTAL)
...

Update the header with octal values.

Fixes 896fa735084e ("spi: spidev_test: Add support for Octal mode data transfers")
---
 include/uapi/linux/spi/spidev.h | 2 ++
 1 file changed, 2 insertions(+)
include/uapi/linux/spi/spidev.h +2 -0
index ee0f2460bff6..f0c95f5cc719 100644
@@ -48,6 +48,8 @@
 #define SPI_TX_QUAD		0x200
 #define SPI_RX_DUAL		0x400
 #define SPI_RX_QUAD		0x800
+#define SPI_TX_OCTAL		0x2000
+#define SPI_RX_OCTAL		0x4000
 
 /*---------------------------------------------------------------------------*/
 
Signature · 1 line
2.26.2
maintainer
#1 lore raw
Quoted 3 lines · Vinod Koul

Commit 896fa735084e ("spi: spidev_test: Add support for Octal mode data transfers") adds support for octal mode but failed to update userspace header with octal defines causing build error for the spidev tool

This was already fixed.