cxgb4: Use struct_size() helper
Subsystems (3)
PATCH 1/1 cxgb4: Use struct_size() helper
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes.
This code was detected with the help of Coccinelle and, audited and fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/net/ethernet/chelsio/cxgb4/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/chelsio/cxgb4/sge.c +1 -1
@@ -2431,7 +2431,7 @@ int cxgb4_ethofld_send_flowc(struct net_device *dev, u32 eotid, u32 tc)struct sk_buff *skb;int ret =0 ; - len =sizeof (*flowc) +sizeof (struct fw_flowc_mnemval ) * nparams; + len =struct_size (flowc, mnemval, nparams); len16 =DIV_ROUND_UP (len,16 ); entry =cxgb4_lookup_eotid (&adap->tids, eotid);
Signature · 1 line
2.27.0
From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 19 Jun 2020 13:01:49 -0500
Quoted 8 lines
Make use of the
struct_size()helper instead of an open-coded version in order to avoid any potential type mistakes.This code was detected with the help of Coccinelle and, audited and fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.