x86/dumpstack: Print registers with the same log level as the backtrace
Subsystems (2)
cover x86/dumpstack: Print registers with the same log level as the backtrace
show_trace_log_lvl() provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead, KERN_DEFAULT is always used.
Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into /var/log/ as the console baud-rate often is indecently slow (9600 bps).
Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce KERN_UNSUPPRESSED (which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, I have a potential use-case for printing traces with KERN_DEBUG level [2] (where registers dump shouldn't appear with higher log level than the backtrace).
Cc: Andy Lutomirski <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jann Horn <[email protected]>
Cc: Petr Mladek <[email protected]>
Cc: Sergey Senozhatsky <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Tetsuo Handa <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: https://lore.kernel.org/linux-doc/[email protected]/
Dmitry Safonov (3):
x86/dumpstack: Add log_lvl to show_iret_regs() x86/dumpstack: Add log_lvl to __show_regs() x86/dumpstack: Show registers dump with trace's log level
arch/x86/include/asm/kdebug.h | 5 ++-- arch/x86/kernel/dumpstack.c | 23 +++++++++------- arch/x86/kernel/process_32.c | 29 ++++++++++---------- arch/x86/kernel/process_64.c | 51 ++++++++++++++++++----------------- 4 files changed, 57 insertions(+), 51 deletions(-)
Signature · 1 line
2.27.0
PATCH 1/3 x86/dumpstack: Add log_lvl to show_iret_regs()
show_trace_log_lvl() provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead, KERN_DEFAULT is always used.
Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into /var/log/ as the console baud-rate often is indecently slow (9600 bps).
Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce KERN_UNSUPPRESSED (which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, I have a potential use-case for printing traces with KERN_DEBUG level [2] (where registers dump shouldn't appear with higher log level).
Add log_lvl parameter to show_iret_regs() as a preparation to add it to __show_regs() and show_regs_if_on_stack().
[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: https://lore.kernel.org/linux-doc/[email protected]/
--- arch/x86/include/asm/kdebug.h | 2 +- arch/x86/kernel/dumpstack.c | 8 ++++---- arch/x86/kernel/process_64.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)
arch/x86/include/asm/kdebug.h +1 -1
@@ -37,7 +37,7 @@ void die_addr(const char *str, struct pt_regs *regs, long err, long gp_addr);extern int __must_check __die (const char *,struct pt_regs *,long );extern void show_stack_regs (struct pt_regs *regs);extern void __show_regs (struct pt_regs *regs,enum show_regs_mode ); -extern void show_iret_regs (struct pt_regs *regs); +extern void show_iret_regs (struct pt_regs *regs,const char *log_lvl);extern unsigned long oops_begin (void );extern void oops_end (unsigned long ,struct pt_regs *,int signr);
arch/x86/kernel/dumpstack.c +4 -4
@@ -126,10 +126,10 @@ void show_ip(struct pt_regs *regs, const char *loglvl)show_opcodes (regs, loglvl); } -void show_iret_regs (struct pt_regs *regs) +void show_iret_regs (struct pt_regs *regs,const char *log_lvl) { -show_ip (regs,KERN_DEFAULT ); -printk (KERN_DEFAULT "RSP: %04x:%016lx EFLAGS: %08lx" , (int )regs->ss, +show_ip (regs, log_lvl); +printk ("%sRSP: %04x:%016lx EFLAGS: %08lx" , log_lvl, (int )regs->ss, regs->sp, regs->flags); }
@@ -155,7 +155,7 @@ static void show_regs_if_on_stack(struct stack_info *info, struct pt_regs *regs,* full pt_regs might not have been saved yet. In that case * just print the iret frame. */ -show_iret_regs (regs); +show_iret_regs (regs,KERN_DEFAULT ); } }
arch/x86/kernel/process_64.c +1 -1
@@ -69,7 +69,7 @@ void __show_regs(struct pt_regs *regs, enum show_regs_mode mode)unsigned int fsindex, gsindex;unsigned int ds, es; -show_iret_regs (regs); +show_iret_regs (regs,KERN_DEFAULT );if (regs->orig_ax !=-1 )pr_cont (" ORIG_RAX: %016lx\n" , regs->orig_ax);
Signature · 1 line
2.27.0
PATCH 2/3 x86/dumpstack: Add log_lvl to __show_regs()
In reply to Dmitry Safonovshow_trace_log_lvl() provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead, KERN_DEFAULT is always used.
Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into /var/log/ as the console baud-rate often is indecently slow (9600 bps).
Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce KERN_UNSUPPRESSED (which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, I have a potential use-case for printing traces with KERN_DEBUG level [2] (where registers dump shouldn't appear with higher log level).
Add log_lvl parameter to __show_regs().
Keep the used log level intact to separate visible change.
[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: https://lore.kernel.org/linux-doc/[email protected]/
--- arch/x86/include/asm/kdebug.h | 3 ++- arch/x86/kernel/dumpstack.c | 9 ++++--- arch/x86/kernel/process_32.c | 29 ++++++++++---------- arch/x86/kernel/process_64.c | 51 ++++++++++++++++++----------------- 4 files changed, 49 insertions(+), 43 deletions(-)
arch/x86/include/asm/kdebug.h +2 -1
@@ -36,7 +36,8 @@ extern void die(const char *, struct pt_regs *,long);void die_addr (const char *str,struct pt_regs *regs,long err,long gp_addr);extern int __must_check __die (const char *,struct pt_regs *,long );extern void show_stack_regs (struct pt_regs *regs); -extern void __show_regs (struct pt_regs *regs,enum show_regs_mode ); +extern void __show_regs (struct pt_regs *regs,enum show_regs_mode , +const char *log_lvl);extern void show_iret_regs (struct pt_regs *regs,const char *log_lvl);extern unsigned long oops_begin (void );extern void oops_end (unsigned long ,struct pt_regs *,int signr);
arch/x86/kernel/dumpstack.c +6 -3
@@ -146,7 +146,7 @@ static void show_regs_if_on_stack(struct stack_info *info, struct pt_regs *regs,* they can be printed in the right context. */ if (!partial &&on_stack (info, regs,sizeof (*regs))) { -__show_regs (regs,SHOW_REGS_SHORT ); +__show_regs (regs,SHOW_REGS_SHORT ,KERN_DEFAULT ); }else if (partial &&on_stack (info, (void *)regs +IRET_FRAME_OFFSET ,IRET_FRAME_SIZE )) {
@@ -345,7 +345,7 @@ void oops_end(unsigned long flags, struct pt_regs *regs, int signr)oops_exit ();/* Executive summary in case the oops scrolled away */ -__show_regs (&exec_summary_regs,SHOW_REGS_ALL ); +__show_regs (&exec_summary_regs,SHOW_REGS_ALL ,KERN_DEFAULT );if (!signr)return ;
@@ -437,9 +437,12 @@ void die_addr(const char *str, struct pt_regs *regs, long err, long gp_addr)void show_regs (struct pt_regs *regs) { +int print_kernel_regs; +show_regs_print_info (KERN_DEFAULT ); -__show_regs (regs,user_mode (regs) ?SHOW_REGS_USER :SHOW_REGS_ALL ); + print_kernel_regs =user_mode (regs) ?SHOW_REGS_USER :SHOW_REGS_ALL ; +__show_regs (regs, print_kernel_regs,KERN_DEFAULT );/* * When in-kernel, we also print out the stack at the time of the fault..
arch/x86/kernel/process_32.c +15 -14
@@ -56,7 +56,8 @@#include "process.h" -void __show_regs (struct pt_regs *regs,enum show_regs_mode mode) +void __show_regs (struct pt_regs *regs,enum show_regs_mode mode, +const char *log_lvl) {unsigned long cr0 =0L , cr2 =0L , cr3 =0L , cr4 =0L ;unsigned long d0, d1, d2, d3, d6, d7;
@@ -67,14 +68,14 @@ void __show_regs(struct pt_regs *regs, enum show_regs_mode mode)else savesegment (gs, gs); -show_ip (regs,KERN_DEFAULT ); +show_ip (regs, log_lvl); -printk (KERN_DEFAULT "EAX: %08lx EBX: %08lx ECX: %08lx EDX: %08lx\n" , - regs->ax, regs->bx, regs->cx, regs->dx); -printk (KERN_DEFAULT "ESI: %08lx EDI: %08lx EBP: %08lx ESP: %08lx\n" , - regs->si, regs->di, regs->bp, regs->sp); -printk (KERN_DEFAULT "DS: %04x ES: %04x FS: %04x GS: %04x SS: %04x EFLAGS: %08lx\n" , - (u16 )regs->ds, (u16 )regs->es, (u16 )regs->fs, gs, regs->ss, regs->flags); +printk ("%sEAX: %08lx EBX: %08lx ECX: %08lx EDX: %08lx\n" , + log_lvl, regs->ax, regs->bx, regs->cx, regs->dx); +printk ("%sESI: %08lx EDI: %08lx EBP: %08lx ESP: %08lx\n" , + log_lvl, regs->si, regs->di, regs->bp, regs->sp); +printk ("%sDS: %04x ES: %04x FS: %04x GS: %04x SS: %04x EFLAGS: %08lx\n" , + log_lvl, (u16 )regs->ds, (u16 )regs->es, (u16 )regs->fs, gs, regs->ss, regs->flags);if (mode !=SHOW_REGS_ALL )return ;
@@ -83,8 +84,8 @@ void __show_regs(struct pt_regs *regs, enum show_regs_mode mode) cr2 =read_cr2 (); cr3 =__read_cr3 (); cr4 =__read_cr4 (); -printk (KERN_DEFAULT "CR0: %08lx CR2: %08lx CR3: %08lx CR4: %08lx\n" , - cr0, cr2, cr3, cr4); +printk ("%sCR0: %08lx CR2: %08lx CR3: %08lx CR4: %08lx\n" , + log_lvl, cr0, cr2, cr3, cr4);get_debugreg (d0,0 );get_debugreg (d1,1 );
@@ -98,10 +99,10 @@ void __show_regs(struct pt_regs *regs, enum show_regs_mode mode) (d6 == DR6_RESERVED) && (d7 == 0x400))return ; -printk (KERN_DEFAULT "DR0: %08lx DR1: %08lx DR2: %08lx DR3: %08lx\n" , - d0, d1, d2, d3); -printk (KERN_DEFAULT "DR6: %08lx DR7: %08lx\n" , - d6, d7); +printk ("%sDR0: %08lx DR1: %08lx DR2: %08lx DR3: %08lx\n" , + log_lvl, d0, d1, d2, d3); +printk ("%sDR6: %08lx DR7: %08lx\n" , + log_lvl, d6, d7); }void release_thread (struct task_struct *dead_task)
arch/x86/kernel/process_64.c +26 -25
90 lines not on this page · raw message
Signature · 1 line
2.27.0
Re: [PATCH 2/3] x86/dumpstack: Add log_lvl to __show_regs()
Quoted 18 lines · Dmitry Safonov
show_trace_log_lvl()provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead,KERN_DEFAULTis always used.Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into
/var/log/as the console baud-rate often is indecently slow (9600 bps).Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce
KERN_UNSUPPRESSED(which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, I have a potential use-case for printing traces withKERN_DEBUGlevel [2] (where registers dump shouldn't appear with higher log level).
Quoted 2 lines
Add
log_lvlparameter to__show_regs().
Keep the used log level intact to separate visible change.
This change seems like a good idea to me; just one small nit:
[...]
arch/x86/kernel/dumpstack.c void die_addr(const char *str, struct pt_regs *regs, long err, long gp_addr) · line 445
Quoted 9 lines
void
show_regs(struct pt_regs *regs)
{arch/x86/kernel/dumpstack.c +4
-1+int print_kernel_regs; +show_regs_print_info (KERN_DEFAULT ); -__show_regs (regs,user_mode (regs) ?SHOW_REGS_USER :SHOW_REGS_ALL ); + print_kernel_regs =user_mode (regs) ?SHOW_REGS_USER :SHOW_REGS_ALL ; +__show_regs (regs, print_kernel_regs,KERN_DEFAULT );
print_kernel_regs should probably have type "enum show_regs_mode"?
Re: [PATCH 2/3] x86/dumpstack: Add log_lvl to __show_regs()
Quoted 31 lines · Jann Horn
Quoted 18 lines · Dmitry Safonov
show_trace_log_lvl()provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead,KERN_DEFAULTis always used.Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into
/var/log/as the console baud-rate often is indecently slow (9600 bps).Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce
KERN_UNSUPPRESSED(which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, I have a potential use-case for printing traces withKERN_DEBUGlevel [2] (where registers dump shouldn't appear with higher log level).Quoted 2 lines
Add
log_lvlparameter to__show_regs().
Keep the used log level intact to separate visible change.This change seems like a good idea to me; just one small nit:
[...]
Quoted 6 lines
void
show_regs(struct pt_regs *regs)
{arch/x86/kernel/dumpstack.c +2
-0+int print_kernel_regs; +show_regs_print_info (KERN_DEFAULT );
Quoted 5 lines
arch/x86/kernel/dumpstack.c void die_addr(const char *str, struct pt_regs *regs, long err, long gp_addr) · line 445
Quoted 3 lines
arch/x86/kernel/dumpstack.c +2
-1-__show_regs (regs,user_mode (regs) ?SHOW_REGS_USER :SHOW_REGS_ALL ); + print_kernel_regs =user_mode (regs) ?SHOW_REGS_USER :SHOW_REGS_ALL ; +__show_regs (regs, print_kernel_regs,KERN_DEFAULT );
print_kernel_regsshould probably have type "enumshow_regs_mode"?
Makes sense, will fix in v2.
Thanks,
Dmitry
PATCH 3/3 x86/dumpstack: Show registers dump with trace's log level
In reply to Dmitry Safonovshow_trace_log_lvl() provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead, KERN_DEFAULT is always used.
Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into /var/log/ as the console baud-rate often is indecently slow (9600 bps).
Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce KERN_UNSUPPRESSED (which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, I have a potential use-case for printing traces with KERN_DEBUG level [2] (where registers dump shouldn't appear with higher log level).
After all preparations are done, provide log_lvl parameter for show_regs_if_on_stack() and wire up to actual log level used as an argument for show_trace_log_lvl().
[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: https://lore.kernel.org/linux-doc/[email protected]/
--- arch/x86/kernel/dumpstack.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/x86/kernel/dumpstack.c +5 -5
@@ -134,7 +134,7 @@ void show_iret_regs(struct pt_regs *regs, const char *log_lvl) }static void show_regs_if_on_stack (struct stack_info *info,struct pt_regs *regs, -bool partial) +bool partial,const char *log_lvl) {/* * These on_stack() checks aren't strictly necessary: the unwind code
@@ -146,7 +146,7 @@ static void show_regs_if_on_stack(struct stack_info *info, struct pt_regs *regs,* they can be printed in the right context. */ if (!partial &&on_stack (info, regs,sizeof (*regs))) { -__show_regs (regs,SHOW_REGS_SHORT ,KERN_DEFAULT ); +__show_regs (regs,SHOW_REGS_SHORT , log_lvl); }else if (partial &&on_stack (info, (void *)regs +IRET_FRAME_OFFSET ,IRET_FRAME_SIZE )) {
@@ -155,7 +155,7 @@ static void show_regs_if_on_stack(struct stack_info *info, struct pt_regs *regs,* full pt_regs might not have been saved yet. In that case * just print the iret frame. */ -show_iret_regs (regs,KERN_DEFAULT ); +show_iret_regs (regs, log_lvl); } }
@@ -210,7 +210,7 @@ void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,printk ("%s <%s>\n" , log_lvl, stack_name);if (regs) -show_regs_if_on_stack (&stack_info, regs, partial); +show_regs_if_on_stack (&stack_info, regs, partial, log_lvl);/* * Scan the stack, printing any text addresses we find. At the
@@ -271,7 +271,7 @@ void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,/* if the frame has entry regs, print them */ regs =unwind_get_entry_regs (&state, &partial);if (regs) -show_regs_if_on_stack (&stack_info, regs, partial); +show_regs_if_on_stack (&stack_info, regs, partial, log_lvl); }if (stack_name)
Signature · 1 line
2.27.0
Quoted 18 lines · Dmitry Safonov
show_trace_log_lvl()provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead,KERN_DEFAULTis always used.Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into
/var/log/as the console baud-rate often is indecently slow (9600 bps).Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce
KERN_UNSUPPRESSED(which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, I have a potential use-case for printing traces withKERN_DEBUGlevel [2] (where registers dump shouldn't appear with higher log level than the backtrace).
Quoted 4 lines
Dmitry Safonov (3):
x86/dumpstack: Addlog_lvltoshow_iret_regs()x86/dumpstack: Addlog_lvlto__show_regs()x86/dumpstack: Show registers dump with trace's log level
The change makes sense. It is natural next step after adding log_lvl parameter for printing stack traces. For the entire patchset:
Are there any plans to add this also for other architectures, please?
Best Regards,
Petr
Quoted 24 lines · Petr Mladek
Quoted 18 lines · Dmitry Safonov
show_trace_log_lvl()provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead,KERN_DEFAULTis always used.Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into
/var/log/as the console baud-rate often is indecently slow (9600 bps).Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce
KERN_UNSUPPRESSED(which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, I have a potential use-case for printing traces withKERN_DEBUGlevel [2] (where registers dump shouldn't appear with higher log level than the backtrace).Quoted 4 lines
Dmitry Safonov (3):
x86/dumpstack: Addlog_lvltoshow_iret_regs()x86/dumpstack: Addlog_lvlto__show_regs()x86/dumpstack: Show registers dump with trace's log level
Quoted 4 lines
The change makes sense. It is natural next step after adding
log_lvlparameter for printing stack traces. For the entire patchset:Acked-by Petr Mladek <[email protected]>
I'll address the nit by Jann and resend v2 with your Ack, thanks!
Quoted 1 line
Are there any plans to add this also for other architectures, please?
Yes, I'll look into that.
Thanks,
Dmitry