Skip to contentSkip to conversation

ARM: dts: imx6q-tbs2910: Fix Ethernet regression

PATCH Superseded Fabio Estevam 1 participant 1 message Jun 25, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx6q-tbs2910: Fix Ethernet regression

Since commit:

commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc

Author: Michael Walle <[email protected]>
Date:   Thu May 7 00:11:58 2020 +0200

phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver.

If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY. Please have a look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set "clk-out-frequency = <125000000>" because that value was the hardcoded value until this commit.

, the clock output setting for the AR803x driver is removed from being hardcoded in the PHY driver and should be passed via device tree instead.

Update the device tree with the "qca,clk-out-frequency" property so that Ethernet can work again.

---
 arch/arm/dts/imx6q-tbs2910.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/dts/imx6q-tbs2910.dts +12 -0
index cc5df37b46..eb08801044 100644
@@ -107,7 +107,19 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+	phy-handle = <&phy>;
+
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy: ethernet-phy at 4 {
+			reg = <4>;
+			qca,clk-out-frequency = <125000000>;
+		};
+	};
 };
 
 &hdmi {
Signature · 1 line
2.17.1