nvme: fix identify error status silent ignore
Sagi Grimberg
maintainerPATCH v2 1/1 nvme: fix identify error status silent ignore
Patch 59c7c3caaaf8 intended to only silently ignore non retry-able errors (DNR bit set) such that we can still identify misbehaving controllers, and in the other hand propagate retry-able errors (DNR bit cleared) so we don't wrongly abandon a namespace just because it happens to be temporarily inaccessible.
The goal remains the same as the original commit where this was introduced but unfortunately had the logic backwards.
Fixes 59c7c3caaaf8 ("nvme: fix possible hang when ns
scanning fails during error recovery")
Reported-by Keith Busch <[email protected]>
Reviewed-by Keith Busch <[email protected]>
Signed-off-by Sagi Grimberg <[email protected]>
---
Changes from v1:
- remove paranthesis
drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
@@ -1130,7 +1130,7 @@ static int nvme_identify_ns_descs(struct nvme_ctrl *ctrl, unsigned nsid,* Don't treat an error as fatal, as we potentially already * have a NGUID or EUI-64. */ -if (status >0 && !(status &NVME_SC_DNR )) +if (status >0 && status &NVME_SC_DNR ) status =0 ; goto free_data; }
Signature · 7 lines
2.25.1 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme