Skip to contentSkip to conversation

kernel.bbclass: Fix Module.symvers support

PATCH In review [email protected] 2 participants 3 messages Jun 26, 2020 – Jul 2, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel.bbclass: Fix Module.symvers support

From: Lili Li <[email protected]>

Starting from v5.8-rc1 commit 269a535ca931 (modpost: generate vmlinux.symvers and reuse it for the second modpost"), kernel will generate new vmlinux.symvers instead of dumping all the vmlinux symbols into Module.symvers in the first pass.

Error log:
'run.do_shared_workdir.16614' failed with exit code 1:
DEBUG: cp: cannot stat 'Module.symvers': No such file or directory

This change will check the file Module.symvers existence before copying it.

---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -1
index 20a0135fc979..a1219f315620 100644
@@ -463,7 +463,7 @@ do_shared_workdir () {
 
 	# Copy files required for module builds
 	cp System.map $kerneldir/System.map-${KERNEL_VERSION}
-	cp Module.symvers $kerneldir/
+	[ -e Module.symvers ] && cp Module.symvers $kerneldir/
 	cp .config $kerneldir/
 	mkdir -p $kerneldir/include/config
 	cp include/config/kernel.release $kerneldir/include/config/kernel.release
Signature · 1 line
2.26.2
#1 lore raw
Quoted 8 lines · On Fri, Jun 26, 2020 at 1:47 AM <[email protected]> wrote:

From: Lili Li <[email protected]>

Starting from v5.8-rc1 commit 269a535ca931 (modpost: generate vmlinux.symvers and reuse it for the second modpost"), kernel will generate new vmlinux.symvers instead of dumping all the vmlinux symbols into Module.symvers in the first pass.

Quoted 5 lines

Error log:
'run.do_shared_workdir.16614' failed with exit code 1:
DEBUG: cp: cannot stat 'Module.symvers': No such file or directory

This change will check the file Module.symvers existence before copying it.

This doesn't actually fix the problem where we still want Module.symvers, it just ignores copying it to the shared directory. But it will be created ones modules are built.

We either need a 2nd copy task, or we need to move the do_shared_workdir until after modules are built. I'm looking into which makes more sense.

Bruce

Quoted 23 lines
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -2
index 20a0135fc979..a1219f315620 100644
@@ -463,7 +463,7 @@ do_shared_workdir () {
 
        # Copy files required for module builds
        cp System.map $kerneldir/System.map-${KERNEL_VERSION}
-       cp Module.symvers $kerneldir/
+       [ -e Module.symvers ] && cp Module.symvers $kerneldir/
        cp .config $kerneldir/
        mkdir -p $kerneldir/include/config
        cp include/config/kernel.release $kerneldir/include/config/kernel.release
--

2.26.2

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 16 lines · Bruce Ashfield via lists.openembedded.org
Quoted 8 lines · On Fri, Jun 26, 2020 at 1:47 AM <[email protected]> wrote:

From: Lili Li <[email protected]>

Starting from v5.8-rc1 commit 269a535ca931 (modpost: generate vmlinux.symvers and reuse it for the second modpost"), kernel will generate new vmlinux.symvers instead of dumping all the vmlinux symbols into Module.symvers in the first pass.

Quoted 5 lines

Error log:
'run.do_shared_workdir.16614' failed with exit code 1:
DEBUG: cp: cannot stat 'Module.symvers': No such file or directory

This change will check the file Module.symvers existence before copying it.

Quoted 7 lines

This doesn't actually fix the problem where we still want Module.symvers, it just ignores copying it to the shared directory. But it will be created ones modules are built.

We either need a 2nd copy task, or we need to move the do_shared_workdir until after modules are built. I'm looking into which makes more sense.

As it turns out (and as you probably already knew), we do that 2nd copy already so it will make it to the shared workdir.

So I retract my comment, and we are good.

Cheers,

Bruce

Quoted 34 lines

Bruce

Quoted 20 lines
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -2
index 20a0135fc979..a1219f315620 100644
@@ -463,7 +463,7 @@ do_shared_workdir () {
 
        # Copy files required for module builds
        cp System.map $kerneldir/System.map-${KERNEL_VERSION}
-       cp Module.symvers $kerneldir/
+       [ -e Module.symvers ] && cp Module.symvers $kerneldir/
        cp .config $kerneldir/
        mkdir -p $kerneldir/include/config
        cp include/config/kernel.release $kerneldir/include/config/kernel.release
--
Quoted 3 lines

2.26.2

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II