Skip to contentSkip to conversation

: don't select vulkan if directfb enabled.

PATCH In review [email protected] 3 participants 6 messages Jun 28, 2020 – Jun 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : don't select vulkan if directfb enabled.

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -1
index 7a227fed51..aee001e641 100644
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 1/1 : don't select vulkan if directfb enabled.

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -1
index 7a227fed51..aee001e641 100644
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
Signature · 1 line
2.25.1
#2 lore raw
Quoted 3 lines · Chenxi Mao

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

This change doesn't look right. Passing two values to bb.utils.filter() doesn't imply any dependency between them.

Can you explain what problem you have seen and how to reproduce it?

Quoted 23 lines
Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -2
index 7a227fed51..aee001e641 100644
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
--

2.25.1

author
#3 lore raw

Hi Andre:

My reproduce step as below:

I enable directfb and vulkan id DISTRO_FEATURES with QT5.15

Then during vulkan build, it has error message show that the vulkan didn't support directfb.

If I remove vulkan in DISTRO_FEATURES, the build will be passed.

Chenxi

Quoted 31 lines · Andre McCurdy
Quoted 2 lines · Chenxi Mao

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

This change doesn't look right. Passing two values to bb.utils.filter() doesn't imply any dependency between them.

Can you explain what problem you have seen and how to reproduce it?

Quoted 23 lines
Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -2
index 7a227fed51..aee001e641 100644
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
--

2.25.1

#4 lore raw

✗ patchtest: failure for [1/1,dunfell,master] : don't select vulkan if directfb enabled.

In reply to [email protected]

== Series Details ==

Series: [1/1,dunfell,master] : don't select vulkan if directfb enabled.
Revision: 1
URL : https://patchwork.openembedded.org/series/24873/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            [1/1,dunfell,master] : don't select vulkan if directfb enabled.
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#5 lore raw

✗ patchtest: failure for [1/1,dunfell,master] : don't select vulkan if directfb enabled. (rev2)

In reply to [email protected]

== Series Details ==

Series: [1/1,dunfell,master] : don't select vulkan if directfb enabled. (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/24873/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            [dunfell,master] : don't select vulkan if directfb enabled.
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe