Skip to contentSkip to conversation

gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.

PATCH Superseded Chenxi Mao 3 participants 6 messages Jun 28, 2020 – Jun 29, 2020

lore
Share & tools
lore

Chenxi Mao

author
#0 lore raw

PATCH 1/1 gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -1
index 7a227fed51..aee001e641 100644
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH v2 1/1 gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -1
index 7a227fed51..aee001e641 100644
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
Signature · 1 line
2.25.1
#2 lore raw
Quoted 14 lines · Chenxi Mao

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +0 -0
index 7a227fed51..aee001e641 100644

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb inherit gobject-introspection · line 30

Quoted 8 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -1
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \

This doesn't look right since what if DISTRO_FEATURES contains just vulkan? This patch would stop vulkan being enabled when directfb isn't enabled if I read it correctly?

Cheers,

Richard

author
#3 lore raw

Hi Richard:

If I set directfb only in DISTRO_FEATURES, the vulkan will be enabled in gstreamer, that will cause the build break.
The root cause is the vulkan didn't support directfb.
So I remove this vulkan if directfb enabled.

Another solution is separate the directfb with directfb. Like below:
+ ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
+ ${@bb.utils.filter('DISTRO_FEATURES', 'vulkan', d)} \

Chenxi

Quoted 33 lines · Richard Purdie
Quoted 14 lines · Chenxi Mao

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +0 -0
index 7a227fed51..aee001e641 100644

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb inherit gobject-introspection · line 30

Quoted 8 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -1
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \

This doesn't look right since what if DISTRO_FEATURES contains just vulkan? This patch would stop vulkan being enabled when directfb isn't enabled if I read it correctly?

Cheers,

Richard

#4 lore raw

bb.utils.filter() makes sets out of DISTRO_FEATURES and the second argument, and returns an intersection of the two. So the line shouldn't need any fixing.

Are you sure you do not have vulkan in your DISTRO_FEATURES? How are you setting it? What does 'bitbake -e gstreamer1.0-plugins-bad' say?

Alex

Quoted 56 lines · Chenxi Mao

Hi Richard:

If I set directfb only in DISTRO_FEATURES, the vulkan will be enabled in gstreamer, that will cause the build break.
The root cause is the vulkan didn't support directfb.
So I remove this vulkan if directfb enabled.

Another solution is separate the directfb with directfb. Like below:

(quoted diff) +2 -0
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'vulkan', d)} \

Chenxi

Quoted 11 lines · Richard Purdie

Review

Quoted 10 lines · Chenxi Mao

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/ gstreamer1.0-plugins-bad_1.16.2.bb

Quoted 2 lines
Quoted 2 lines

index 7a227fed51..aee001e641 100644
--- a/meta/recipes-multimedia/gstreamer/

gstreamer1.0-plugins-bad_1.16.2.bb

Quoted 1 line
Quoted 1 line

+++ b/meta/recipes-multimedia/gstreamer/

gstreamer1.0-plugins-bad_1.16.2.bb

Quoted 4 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb inherit gobject-introspection · line 26

Quoted 4 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +0 -0
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '',

d)} \

Quoted 3 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb inherit gobject-introspection

Quoted 3 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -1
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '',

d)} \

Quoted 2 lines

Review inherit gobject-introspection · line 30

Quoted 2 lines
(quoted diff) +0 -0
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming

sndfile \

Quoted 10 lines

This doesn't look right since what if DISTRO_FEATURES contains just vulkan? This patch would stop vulkan being enabled when directfb isn't enabled if I read it correctly?

Cheers,

Richard

author
#5 lore raw

Hi Alex, Richard:

Thanks for your information, hints and suggestion.

After remove vulkan in DISTRO_FEATURES configuration,  it works fine.

We don't need this commit any more. Please abandon this commit.

Thanks.

Chenxi

Quoted 67 lines · Alexander Kanavin

bb.utils.filter() makes sets out of DISTRO_FEATURES and the second argument, and returns an intersection of the two. So the line shouldn't need any fixing.

Are you sure you do not have vulkan in your DISTRO_FEATURES? How are you setting it? What does 'bitbake -e gstreamer1.0-plugins-bad' say?

Alex

Quoted 56 lines · Chenxi Mao

Hi Richard:

If I set directfb only in DISTRO_FEATURES, the vulkan will be enabled in gstreamer, that will cause the build break.
The root cause is the vulkan didn't support directfb.
So I remove this vulkan if directfb enabled.

Another solution is separate the directfb with directfb. Like below:

(quoted diff) +2 -0
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'vulkan', d)} \

Chenxi

Quoted 11 lines · Richard Purdie

Review

Quoted 10 lines · Chenxi Mao

vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.

Change-Id Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/ gstreamer1.0-plugins-bad_1.16.2.bb

Quoted 2 lines
Quoted 2 lines

index 7a227fed51..aee001e641 100644
--- a/meta/recipes-multimedia/gstreamer/

gstreamer1.0-plugins-bad_1.16.2.bb

Quoted 1 line
Quoted 1 line

+++ b/meta/recipes-multimedia/gstreamer/

gstreamer1.0-plugins-bad_1.16.2.bb

Quoted 4 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb inherit gobject-introspection · line 26

Quoted 4 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +0 -0
@@ -24,7 +24,7 @@ inherit gobject-introspection
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '',

d)} \

Quoted 3 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb inherit gobject-introspection

Quoted 3 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb +1 -1
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '',

d)} \

Quoted 2 lines

Review inherit gobject-introspection · line 30

Quoted 2 lines
(quoted diff) +0 -0
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
     bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming

sndfile \

Quoted 10 lines

This doesn't look right since what if DISTRO_FEATURES contains just vulkan? This patch would stop vulkan being enabled when directfb isn't enabled if I read it correctly?

Cheers,

Richard