Skip to contentSkip to conversation

f2fs: remove useless parameter of __insert_free_nid()

PATCH In review Liu Song via Linux-f2fs-devel 2 participants 2 messages Jun 28, 2020 – Jun 29, 2020 F2FS file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 f2fs: remove useless parameter of __insert_free_nid()

From: Liu Song <[email protected]>

In current version, @state will only be FREE_NID. This parameter has no real effect so remove it to keep clean.

---
 fs/f2fs/node.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
fs/f2fs/node.c +4 -6
index 03e24df1c84f..b4f4b0d77553 100644
@@ -2108,7 +2108,7 @@ static struct free_nid *__lookup_free_nid_list(struct f2fs_nm_info *nm_i,
 }
 
 static int __insert_free_nid(struct f2fs_sb_info *sbi,
-			struct free_nid *i, enum nid_state state)
+				struct free_nid *i)
 {
 	struct f2fs_nm_info *nm_i = NM_I(sbi);
 
@@ -2116,10 +2116,8 @@ static int __insert_free_nid(struct f2fs_sb_info *sbi,
 	if (err)
 		return err;
 
-	f2fs_bug_on(sbi, state != i->state);
-	nm_i->nid_cnt[state]++;
-	if (state == FREE_NID)
-		list_add_tail(&i->list, &nm_i->free_nid_list);
+	nm_i->nid_cnt[FREE_NID]++;
+	list_add_tail(&i->list, &nm_i->free_nid_list);
 	return 0;
 }
 
@@ -2241,7 +2239,7 @@ static bool add_free_nid(struct f2fs_sb_info *sbi,
 		}
 	}
 	ret = true;
-	err = __insert_free_nid(sbi, i, FREE_NID);
+	err = __insert_free_nid(sbi, i);
 err_out:
 	if (update) {
 		update_free_nid_bitmap(sbi, nid, ret, build);
Signature · 8 lines
2.20.1



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On 2020/6/28 21:48, Liu Song via Linux-f2fs-devel wrote:

From: Liu Song <[email protected]>

In current version, @state will only be FREE_NID. This parameter has no real effect so remove it to keep clean.

Thanks,

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel