Skip to contentSkip to conversation

samples/vfs: Avoid warning in statx override

PATCH Applied Kees Cook 1 participant 1 message Jun 29, 2020

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 samples/vfs: Avoid warning in statx override

Something changed recently to uncover this warning:

samples/vfs/test-statx.c:24:15: warning: ‘struct foo’ declared inside parameter list will not be visible outside of this definition or declaration
24 | #define statx foo
| ^~~

Which is due the use of "struct statx" (here, "struct foo") in a function prototype argument list before it has been defined:

int
# 56 "/usr/include/x86_64-linux-gnu/bits/statx-generic.h"
foo
# 56 "/usr/include/x86_64-linux-gnu/bits/statx-generic.h" 3 4
(int __dirfd, const char *__restrict __path, int __flags,
unsigned int __mask, struct
# 57 "/usr/include/x86_64-linux-gnu/bits/statx-generic.h"
foo
# 57 "/usr/include/x86_64-linux-gnu/bits/statx-generic.h" 3 4

                                             *__restrict __buf)

__attribute__ ((__nothrow__ , __leaf__)) __attribute__ ((__nonnull__ (2, 5)));

Add explicit struct before #include to avoid warning.

Fixes f1b5618e013a ("vfs: Add a sample program for the new mount API")
---
 samples/vfs/test-statx.c | 2 ++
 1 file changed, 2 insertions(+)
samples/vfs/test-statx.c +2 -0
index 76c577ea4fd8..49c7a46cee07 100644
@@ -23,6 +23,8 @@
 #include <linux/fcntl.h>
 #define statx foo
 #define statx_timestamp foo_timestamp
+struct statx;
+struct statx_timestamp;
 #include <sys/stat.h>
 #undef statx
 #undef statx_timestamp
Signature · 5 lines
2.25.1


-- 
Kees Cook