nfs: pnfs: use GFP_ATOMIC under spin lock
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 20 lines · Xu Wang
A spin lock is taken here so we should use
GFP_ATOMIC.Signed-off-by Xu Wang <[email protected]>--- fs/nfs/pnfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/nfs/pnfs.c +1
-1@@ -2170,7 +2170,7 @@ _pnfs_grab_empty_layout(struct inode *ino, struct nfs_open_context *ctx)struct pnfs_layout_hdr *lo;spin_lock (&ino->i_lock); - lo =pnfs_find_alloc_layout (ino, ctx,GFP_KERNEL ); + lo =pnfs_find_alloc_layout (ino, ctx,GFP_ATOMIC );if (!lo) goto out_unlock;
Quoted 1 line
if (!test_bit(NFS_LAYOUT_INVALID_STID,
&lo->plh_flags))
NACK. Please read the code before sending yet another one of these pointless patches.
Signature · 3 lines
Trond Myklebust Linux NFS client maintainer, Hammerspace [email protected]