Skip to contentSkip to conversation

dt-bindings: mfd: st,stmfx: Remove extra additionalProperties

RFC In review Fabio Estevam 4 participants 5 messages Jun 29, 2020 – Jul 1, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC 1/1 dt-bindings: mfd: st,stmfx: Remove extra additionalProperties

The following build error is seen with 'make dt_binding_check':

CHKDT Documentation/devicetree/bindings/mfd/st,stmfx.yaml
/home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'

Remove the extra 'additionalProperties' to pass the build.

---
 Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
 1 file changed, 2 deletions(-)
Documentation/devicetree/bindings/mfd/st,stmfx.yaml +0 -2
index 0ce56a0da553..bed22d4abffb 100644
@@ -73,8 +73,6 @@ properties:
           output-high: true
           output-low: true
 
-      additionalProperties: false
-
     additionalProperties: false
 
     required:
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Fabio Estevam

The following build error is seen with 'make dt_binding_check':

CHKDT Documentation/devicetree/bindings/mfd/st,stmfx.yaml
/home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'

Quoted 7 lines

Remove the extra 'additionalProperties' to pass the build.

---
 Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
 1 file changed, 2 deletions(-)
#2 lore raw
In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

The following build error is seen with 'make dt_binding_check':

CHKDT Documentation/devicetree/bindings/mfd/st,stmfx.yaml
/home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'

Remove the extra 'additionalProperties' to pass the build.

---
 Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
 1 file changed, 2 deletions(-)

Any reason for not sending this to LKML?

Quoted 13 lines
Documentation/devicetree/bindings/mfd/st,stmfx.yaml +0 -2
index 0ce56a0da553..bed22d4abffb 100644
@@ -73,8 +73,6 @@ properties:
           output-high: true
           output-low: true
 
-      additionalProperties: false
-
     additionalProperties: false
 
     required:
Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Reviewed-by on v1 1/1
#3 lore raw
In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

The following build error is seen with 'make dt_binding_check':

CHKDT Documentation/devicetree/bindings/mfd/st,stmfx.yaml
/home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'

Remove the extra 'additionalProperties' to pass the build.

Quoted 19 lines
---
  Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
  1 file changed, 2 deletions(-)
Documentation/devicetree/bindings/mfd/st,stmfx.yaml +0 -2
index 0ce56a0da553..bed22d4abffb 100644
@@ -73,8 +73,6 @@ properties:
            output-high: true
            output-low: true
 
-      additionalProperties: false
-
      additionalProperties: false
 
      required:
#4 lore raw
Quoted 10 lines · Benjamin GAIGNARD
Quoted 6 lines · Fabio Estevam

The following build error is seen with 'make dt_binding_check':

CHKDT Documentation/devicetree/bindings/mfd/st,stmfx.yaml
/home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'

Remove the extra 'additionalProperties' to pass the build.

FYI: The resend of this patch has already been applied.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog