Skip to contentSkip to conversation

ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

PATCH In review Krzysztof Kozlowski 2 participants 5 messages Jun 29, 2020 – Jul 2, 2020

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH v2 1/1 ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

Remove the regulators node entirely because its children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

---

Changes since v1:
1. Remove the node, not only compatible, as pointed out by Sylwester.

---
 arch/arm/boot/dts/exynos4210-trats.dts | 98 ++++++++++++--------------
 1 file changed, 47 insertions(+), 51 deletions(-)
arch/arm/boot/dts/exynos4210-trats.dts +47 -51
index 3d791db6095c..5cc96f04a4fa 100644
@@ -30,62 +30,58 @@
 		stdout-path = "serial2:115200n8";
 	};
 
-	regulators {
-		compatible = "simple-bus";
-
-		vemmc_reg: regulator-0 {
-			compatible = "regulator-fixed";
-			regulator-name = "VMEM_VDD_2.8V";
-			regulator-min-microvolt = <2800000>;
-			regulator-max-microvolt = <2800000>;
-			gpio = <&gpk0 2 GPIO_ACTIVE_HIGH>;
-			enable-active-high;
-		};
+	vemmc_reg: regulator-0 {
+		compatible = "regulator-fixed";
+		regulator-name = "VMEM_VDD_2.8V";
+		regulator-min-microvolt = <2800000>;
+		regulator-max-microvolt = <2800000>;
+		gpio = <&gpk0 2 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 
-		tsp_reg: regulator-1 {
-			compatible = "regulator-fixed";
-			regulator-name = "TSP_FIXED_VOLTAGES";
-			regulator-min-microvolt = <2800000>;
-			regulator-max-microvolt = <2800000>;
-			gpio = <&gpl0 3 GPIO_ACTIVE_HIGH>;
-			enable-active-high;
-		};
+	tsp_reg: regulator-1 {
+		compatible = "regulator-fixed";
+		regulator-name = "TSP_FIXED_VOLTAGES";
+		regulator-min-microvolt = <2800000>;
+		regulator-max-microvolt = <2800000>;
+		gpio = <&gpl0 3 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 
-		cam_af_28v_reg: regulator-2 {
-			compatible = "regulator-fixed";
-			regulator-name = "8M_AF_2.8V_EN";
-			regulator-min-microvolt = <2800000>;
-			regulator-max-microvolt = <2800000>;
-			gpio = <&gpk1 1 GPIO_ACTIVE_HIGH>;
-			enable-active-high;
-		};
+	cam_af_28v_reg: regulator-2 {
+		compatible = "regulator-fixed";
+		regulator-name = "8M_AF_2.8V_EN";
+		regulator-min-microvolt = <2800000>;
+		regulator-max-microvolt = <2800000>;
+		gpio = <&gpk1 1 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 
-		cam_io_en_reg: regulator-3 {
-			compatible = "regulator-fixed";
-			regulator-name = "CAM_IO_EN";
-			regulator-min-microvolt = <2800000>;
-			regulator-max-microvolt = <2800000>;
-			gpio = <&gpe2 1 GPIO_ACTIVE_HIGH>;
-			enable-active-high;
-		};
+	cam_io_en_reg: regulator-3 {
+		compatible = "regulator-fixed";
+		regulator-name = "CAM_IO_EN";
+		regulator-min-microvolt = <2800000>;
+		regulator-max-microvolt = <2800000>;
+		gpio = <&gpe2 1 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 
-		cam_io_12v_reg: regulator-4 {
-			compatible = "regulator-fixed";
-			regulator-name = "8M_1.2V_EN";
-			regulator-min-microvolt = <1200000>;
-			regulator-max-microvolt = <1200000>;
-			gpio = <&gpe2 5 GPIO_ACTIVE_HIGH>;
-			enable-active-high;
-		};
+	cam_io_12v_reg: regulator-4 {
+		compatible = "regulator-fixed";
+		regulator-name = "8M_1.2V_EN";
+		regulator-min-microvolt = <1200000>;
+		regulator-max-microvolt = <1200000>;
+		gpio = <&gpe2 5 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 
-		vt_core_15v_reg: regulator-5 {
-			compatible = "regulator-fixed";
-			regulator-name = "VT_CORE_1.5V";
-			regulator-min-microvolt = <1500000>;
-			regulator-max-microvolt = <1500000>;
-			gpio = <&gpe2 2 GPIO_ACTIVE_HIGH>;
-			enable-active-high;
-		};
+	vt_core_15v_reg: regulator-5 {
+		compatible = "regulator-fixed";
+		regulator-name = "VT_CORE_1.5V";
+		regulator-min-microvolt = <1500000>;
+		regulator-max-microvolt = <1500000>;
+		gpio = <&gpe2 2 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
 	};
 
 	gpio-keys {
Signature · 1 line
2.17.1
Tested-by on v2 1/1
#1 lore raw

Hi Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski

Remove the regulators node entirely because its children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

What about removing the regulators node from other boards:
exynos4412-origen.dts, exynos5420-smdk5420.dts and exynos5250-arndale.dts?

On the other hand, maybe it would be really easier to add missing address/size-cells properties to exynos4210-trats.dts/regulators node?

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
author maintainer
#2 lore raw
Quoted 10 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski

Remove the regulators node entirely because its children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

Quoted 7 lines

What about removing the regulators node from other boards:
exynos4412-origen.dts, exynos5420-smdk5420.dts and exynos5250-arndale.dts?

On the other hand, maybe it would be really easier to add missing address/size-cells properties to exynos4210-trats.dts/regulators node?

Indeed let's keep it consistent so in such case better to add here proper address/size-cells.

Thanks for feedback!

Best regards,
Krzysztof

author maintainer
#3 lore raw
Quoted 13 lines · Krzysztof Kozlowski
Quoted 12 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski

Remove the regulators node entirely because its children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

Quoted 8 lines
Quoted 5 lines

What about removing the regulators node from other boards:
exynos4412-origen.dts, exynos5420-smdk5420.dts and exynos5250-arndale.dts?

On the other hand, maybe it would be really easier to add missing address/size-cells properties to exynos4210-trats.dts/regulators node?

Indeed let's keep it consistent so in such case better to add here proper address/size-cells.

Actually more of DTSes put fixed regulators directly in root node, not under "regulators" node:
exynos3250-monk.dts
exynos4210-i9100.dts
exynos4210-origen.dts
exynos4210-universal_c210.dts
exynos4412-galaxy-s3.dtsi
exynos4412-midas.dtsi
exynos4412-n710x.dts
exynos4412-odroidx.dts
exynos5250-smdk5250.dts
exynos5250-snow-common.dtsi
exynos5420-peach-pit.dts
exynos5800-peach-pi.dts

If we want it to be consistent, it's easier to remove the regulator nodes from exynos4412-origen.dts, exynos5420-smdk5420.dts and exynos5250-arndale.dts.

Best regards,
Krzysztof

#4 lore raw
Quoted 33 lines · Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski
Quoted 9 lines · Marek Szyprowski
Quoted 6 lines · Krzysztof Kozlowski

Remove the regulators node entirely because its children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

Quoted 7 lines
Quoted 5 lines

What about removing the regulators node from other boards:
exynos4412-origen.dts, exynos5420-smdk5420.dts and exynos5250-arndale.dts?

On the other hand, maybe it would be really easier to add missing address/size-cells properties to exynos4210-trats.dts/regulators node?

Indeed let's keep it consistent so in such case better to add here proper address/size-cells.

Actually more of DTSes put fixed regulators directly in root node, not under "regulators" node:
exynos3250-monk.dts
exynos4210-i9100.dts
exynos4210-origen.dts
exynos4210-universal_c210.dts
exynos4412-galaxy-s3.dtsi
exynos4412-midas.dtsi
exynos4412-n710x.dts
exynos4412-odroidx.dts
exynos5250-smdk5250.dts
exynos5250-snow-common.dtsi
exynos5420-peach-pit.dts
exynos5800-peach-pi.dts

Quoted 3 lines

If we want it to be consistent, it's easier to remove the regulator nodes from exynos4412-origen.dts, exynos5420-smdk5420.dts and exynos5250-arndale.dts.

Feel free, I'm fine with both approaches.

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland