Skip to contentSkip to conversation

clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver

PATCH In review David Gow 3 participants 3 messages Jun 30, 2020 – Jul 12, 2020

Subsystems (2)
Staging Common clk
lore
Share & tools
lore

David Gow

author
#0 lore raw

PATCH 1/1 clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver

The Xilinx Clocking Wizard driver uses the devm_ioremap_resource function, but does not specify a dependency on IOMEM in Kconfig. This causes a build failure on architectures without IOMEM, for example, UML (notably with make allyesconfig).

Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.

Signed-off-by David Gow <[email protected]>
---
 drivers/staging/clocking-wizard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/clocking-wizard/Kconfig +1 -1
index 04be22dca9b6..69cf51445f08 100644
@@ -5,6 +5,6 @@
 
 config COMMON_CLK_XLNX_CLKWZRD
 	tristate "Xilinx Clocking Wizard"
-	depends on COMMON_CLK && OF
+	depends on COMMON_CLK && OF && IOMEM
 	help
 	  Support for the Xilinx Clocking Wizard IP core clock generator.
Signature · 1 line
2.27.0.212.ge8ba1cc988-goog
maintainer
#1 lore raw

Quoting David Gow (2020-06-29 21:45:17)

Quoted 9 lines

The Xilinx Clocking Wizard driver uses the devm_ioremap_resource function, but does not specify a dependency on IOMEM in Kconfig. This causes a build failure on architectures without IOMEM, for example, UML (notably with make allyesconfig).

Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.

Signed-off-by David Gow <[email protected]>

---

This driver is in the process of being destaged to drivers/clk/

Greg, should I pick this one up?

Quoted 3 lines
 drivers/staging/clocking-wizard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
maintainer
#2 lore raw
Quoted 6 lines · Stephen Boyd

Quoting David Gow (2020-06-29 21:45:17)

Quoted 5 lines

The Xilinx Clocking Wizard driver uses the devm_ioremap_resource function, but does not specify a dependency on IOMEM in Kconfig. This causes a build failure on architectures without IOMEM, for example, UML (notably with make allyesconfig).

Quoted 8 lines
Quoted 4 lines

Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.

Signed-off-by David Gow <[email protected]>

---

This driver is in the process of being destaged to drivers/clk/

Greg, should I pick this one up?

Sure, if I haven't already.

thanks,

greg k-h