panic: Dump registers on panic_on_warn
PATCH 1/1 panic: Dump registers on panic_on_warn
Currently we print stack and registers for ordinary warnings but we do not for panic_on_warn which looks as oversight - panic() will reboot the machine but won't print registers.
This moves printing of registers and modules earlier.
This does not move the stack dumping as panic() dumps it.
--- kernel/panic.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
kernel/panic.c +6 -6
@@ -589,6 +589,11 @@ void __warn(const char *file, int line, void *caller, unsigned taint,if (args)vprintk (args->fmt, args->args); +print_modules (); + +if (regs) +show_regs (regs); +if (panic_on_warn) {/* * This thread may hit another WARN() in the panic path.
@@ -600,12 +605,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint,panic ("panic_on_warn set ...\n" ); } -print_modules (); - -if (regs) -show_regs (regs); -else -dump_stack (); +dump_stack ();print_irqtrace_events (current);
Signature · 1 line
2.17.1
Ping?
Quoted 44 lines · Alexey Kardashevskiy
Currently we print stack and registers for ordinary warnings but we do not for
panic_on_warnwhich looks as oversight -panic()will reboot the machine but won't print registers.This moves printing of registers and modules earlier.
This does not move the stack dumping as
panic()dumps it.Signed-off-by Alexey Kardashevskiy <[email protected]>--- kernel/panic.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)kernel/panic.c +6
-6@@ -589,6 +589,11 @@ void __warn(const char *file, int line, void *caller, unsigned taint,if (args)vprintk (args->fmt, args->args); +print_modules (); + +if (regs) +show_regs (regs); +if (panic_on_warn) {/* * This thread may hit another WARN() in the panic path. @@ -600,12 +605,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint,panic ("panic_on_warn set ...\n" ); } -print_modules (); - -if (regs) -show_regs (regs); -else -dump_stack (); +dump_stack ();print_irqtrace_events (current);
Signature · 1 line
Alexey
Quoted 16 lines · Alexey Kardashevskiy
Ping?
Quoted 12 lines · Alexey Kardashevskiy
Currently we print stack and registers for ordinary warnings but we do not for
panic_on_warnwhich looks as oversight -panic()will reboot the machine but won't print registers.This moves printing of registers and modules earlier.
This does not move the stack dumping as
panic()dumps it.Signed-off-by Alexey Kardashevskiy <[email protected]>--- kernel/panic.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Why did you pick me and Nick as the people to get this patch?
Always use scripts/get_maintainer.pl please, that's what it is there for...
thanks,
greg k-h