objtool: fix potential memory leak special_get_alts()
PATCH 1/1 objtool: fix potential memory leak special_get_alts()
If get_alt_entry() return error, struct special_alt will leak.
Fixes 442f04c34a1a ("objtool: Add tool to perform compile-time stack metadata validation")
Signed-off-by Chen Wandun <[email protected]>
--- tools/objtool/special.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/objtool/special.c +3 -1
@@ -188,8 +188,10 @@ int special_get_alts(struct elf *elf, struct list_head *alts)memset (alt,0 ,sizeof (*alt)); ret =get_alt_entry (elf, entry, sec, idx, alt); -if (ret) +if (ret) { +free (alt);return ret; + }list_add_tail (&alt->list, alts); }
Signature · 1 line
2.17.1
Peter Zijlstra
maintainerQuoted 4 lines · Chen Wandun
If
get_alt_entry()return error, structspecial_altwill leak.Fixes 442f04c34a1a ("objtool: Add tool to perform compile-time stack metadata validation")Signed-off-by Chen Wandun <[email protected]>
https://lkml.kernel.org/r/20200427144439.rrywv56mjfypupgh@treble