scsi: iscsi: register sysfs for workqueue iscsi_destroy
PATCH 1/1 scsi: iscsi: register sysfs for workqueue iscsi_destroy
Register sysfs for workqueue iscsi_destroy, so that users can set cpu affinity through "cpumask" for this workqueue to get better isolation in cloud multi-tenant scenario.
This patch unfolded create_singlethread_workqueue(), added WQ_SYSFS and drop __WQ_ORDERED_EXPLICIT since __WQ_ORDERED_EXPLICIT workqueue isn't allowed to change "cpumask".
--- drivers/scsi/scsi_transport_iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/scsi/scsi_transport_iscsi.c +3 -1
@@ -4766,7 +4766,9 @@ static __init int iscsi_transport_init(void) goto release_nls; } - iscsi_destroy_workq =create_singlethread_workqueue ("iscsi_destroy" ); + iscsi_destroy_workq =alloc_workqueue ("%s" , +WQ_SYSFS | __WQ_LEGACY |WQ_MEM_RECLAIM |WQ_UNBOUND , +1 ,"iscsi_destroy" );if (!iscsi_destroy_workq) { err = -ENOMEM ; goto destroy_wq;
Signature · 1 line
2.9.5
Quoted 20 lines · Bob Liu
Register sysfs for workqueue
iscsi_destroy, so that users can set cpu affinity through "cpumask" for this workqueue to get better isolation in cloud multi-tenant scenario.This patch unfolded
create_singlethread_workqueue(), addedWQ_SYSFSand drop__WQ_ORDERED_EXPLICITsince__WQ_ORDERED_EXPLICITworkqueue isn't allowed to change "cpumask".Suggested-by Mike Christie <[email protected]>Signed-off-by Bob Liu <[email protected]>--- drivers/scsi/scsi_transport_iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/scsi/scsi_transport_iscsi.c +0
-0
drivers/scsi/scsi_transport_iscsi.c static __init int iscsi_transport_init(void) · line 4774
Quoted 10 lines
drivers/scsi/scsi_transport_iscsi.c +3
-1@@ -4766,7 +4766,9 @@ static __init int iscsi_transport_init(void) goto release_nls; } - iscsi_destroy_workq =create_singlethread_workqueue ("iscsi_destroy" ); + iscsi_destroy_workq =alloc_workqueue ("%s" , +WQ_SYSFS | __WQ_LEGACY |WQ_MEM_RECLAIM |WQ_UNBOUND , +1 ,"iscsi_destroy" );if (!iscsi_destroy_workq) { err = -ENOMEM ; goto destroy_wq;
Quoted 20 lines · Bob Liu
Register sysfs for workqueue
iscsi_destroy, so that users can set cpu affinity through "cpumask" for this workqueue to get better isolation in cloud multi-tenant scenario.This patch unfolded
create_singlethread_workqueue(), addedWQ_SYSFSand drop__WQ_ORDERED_EXPLICITsince__WQ_ORDERED_EXPLICITworkqueue isn't allowed to change "cpumask".Suggested-by Mike Christie <[email protected]>Signed-off-by Bob Liu <[email protected]>--- drivers/scsi/scsi_transport_iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/scsi/scsi_transport_iscsi.c +0
-0
drivers/scsi/scsi_transport_iscsi.c static __init int iscsi_transport_init(void) · line 4774
Quoted 10 lines
drivers/scsi/scsi_transport_iscsi.c +3
-1@@ -4766,7 +4766,9 @@ static __init int iscsi_transport_init(void) goto release_nls; } - iscsi_destroy_workq =create_singlethread_workqueue ("iscsi_destroy" ); + iscsi_destroy_workq =alloc_workqueue ("%s" , +WQ_SYSFS | __WQ_LEGACY |WQ_MEM_RECLAIM |WQ_UNBOUND , +1 ,"iscsi_destroy" );if (!iscsi_destroy_workq) { err = -ENOMEM ; goto destroy_wq;
Quoted 29 lines · Mike Christie
Quoted 28 lines · Bob Liu
Register sysfs for workqueue
iscsi_destroy, so that users can set cpu affinity
through "cpumask" for this workqueue to get better isolation in cloud multi-tenant scenario.This patch unfolded
create_singlethread_workqueue(), addedWQ_SYSFSand drop__WQ_ORDERED_EXPLICITsince__WQ_ORDERED_EXPLICITworkqueue isn't allowed to
change "cpumask".Suggested-by Mike Christie <[email protected]>Signed-off-by Bob Liu <[email protected]>---
drivers/scsi/scsi_transport_iscsi.c| 4 +++-1 file changed, 3 insertions(+), 1 deletion(-)drivers/scsi/scsi_transport_iscsi.c +0
-0@@ -4766,7 +4766,9 @@ static __init int iscsi_transport_init(void) goto release_nls; }-
iscsi_destroy_workq=create_singlethread_workqueue("iscsi_destroy");
+iscsi_destroy_workq= alloc_workqueue("%s",
Quoted 9 lines
Quoted 6 lines
+
WQ_SYSFS|__WQ_LEGACY|WQ_MEM_RECLAIM|WQ_UNBOUND, + 1, "iscsi_destroy");
if (!iscsi_destroy_workq) {
err =-ENOMEM;
gotodestroy_wq;Reviewed-by Mike Christie <[email protected]>
Martin K. Petersen
AppliedQuoted 7 lines · Bob Liu
Register sysfs for workqueue
iscsi_destroy, so that users can set cpu affinity through "cpumask" for this workqueue to get better isolation in cloud multi-tenant scenario.This patch unfolded
create_singlethread_workqueue(), addedWQ_SYSFSand drop__WQ_ORDERED_EXPLICITsince__WQ_ORDERED_EXPLICITworkqueue isn't allowed to change "cpumask".
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: iscsi: Register sysfs for workqueue iscsi_destroy
https://git.kernel.org/mkp/scsi/c/919a295abf96
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering