f2fs: remove write attribute of main_blkaddr sysfs node
PATCH 1/1 f2fs: remove write attribute of main_blkaddr sysfs node
From: Dehe Gu <[email protected]>
Fuzzing main_blkaddr sysfs node will corrupt this field's value, causing kernel panic, remove its write attribute to avoid potential security risk.
[Chao Yu: add description]
Signed-off-by Dehe Gu <[email protected]>
Signed-off-by Daiyue Zhang <[email protected]>
Reviewed-by Chao Yu <[email protected]>
--- fs/f2fs/sysfs.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
fs/f2fs/sysfs.c +8 -1
@@ -224,6 +224,13 @@ static ssize_t avg_vblocks_show(struct f2fs_attr *a, }#endif +static ssize_t main_blkaddr_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return snprintf (buf,PAGE_SIZE ,"%llu\n" , + (unsigned long long )MAIN_BLKADDR (sbi)); +} +static ssize_t f2fs_sbi_show (struct f2fs_attr *a,struct f2fs_sb_info *sbi,char *buf) {
@@ -525,7 +532,6 @@ F2FS_RW_ATTR(GC_THREAD, f2fs_gc_kthread, gc_no_gc_sleep_time, no_gc_sleep_time);F2FS_RW_ATTR (F2FS_SBI , f2fs_sb_info, gc_idle, gc_mode);F2FS_RW_ATTR (F2FS_SBI , f2fs_sb_info, gc_urgent, gc_mode);F2FS_RW_ATTR (SM_INFO , f2fs_sm_info, reclaim_segments, rec_prefree_segments); -F2FS_RW_ATTR (SM_INFO , f2fs_sm_info, main_blkaddr, main_blkaddr);F2FS_RW_ATTR (DCC_INFO , discard_cmd_control, max_small_discards, max_discards);F2FS_RW_ATTR (DCC_INFO , discard_cmd_control, discard_granularity, discard_granularity);F2FS_RW_ATTR (RESERVED_BLOCKS , f2fs_sb_info, reserved_blocks, reserved_blocks);
@@ -568,6 +574,7 @@ F2FS_GENERAL_RO_ATTR(current_reserved_blocks);F2FS_GENERAL_RO_ATTR (unusable);F2FS_GENERAL_RO_ATTR (encoding);F2FS_GENERAL_RO_ATTR (mounted_time_sec); +F2FS_GENERAL_RO_ATTR (main_blkaddr);#ifdef CONFIG_F2FS_STAT_FS F2FS_STAT_ATTR (STAT_INFO , f2fs_stat_info, cp_foreground_calls, cp_count);F2FS_STAT_ATTR (STAT_INFO , f2fs_stat_info, cp_background_calls, bg_cp_count);
Signature · 1 line
2.26.2