drm/vc4: Convert register accessors to FIELD_*
Subsystems (3)
PATCH 1/1 drm/vc4: Convert register accessors to FIELD_*
The VC4_SET_FIELD and VC4_GET_FIELD are reimplementing most of the logic already defined in FIELD_SET and FIELD_GET. Let's convert the vc4 macros to use the FIELD_* macros.
--- drivers/gpu/drm/vc4/vc4_regs.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/gpu/drm/vc4/vc4_regs.h +4 -5
@@ -6,19 +6,18 @@#ifndef VC4_REGS_H #define VC4_REGS_H +#include <linux/bitfield.h> #include <linux/bitops.h> #define VC4_MASK (high, low) ((u32)GENMASK(high, low))/* Using the GNU statement expression extension */ #define VC4_SET_FIELD (value, field) \ ({ \ - uint32_t fieldval = (value) << field##_SHIFT; \ - WARN_ON((fieldval & ~field##_MASK) != 0); \ - fieldval & field##_MASK; \ + WARN_ON(!FIELD_FIT(field##_MASK, value)); \ + FIELD_PREP(field##_MASK, value); \ }) -#define VC4_GET_FIELD (word, field) (((word) & field##_MASK) >> \ - field##_SHIFT) +#define VC4_GET_FIELD (word, field) FIELD_GET(field##_MASK, word)#define V3D_IDENT0 0x00000# define V3D_EXPECTED_IDENT0 \
Signature · 6 lines
2.26.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Maxime Ripard
The
VC4_SET_FIELDandVC4_GET_FIELDare reimplementing most of the logic already defined inFIELD_SETandFIELD_GET. Let's convert the vc4 macros to use the FIELD_* macros.Signed-off-by Maxime Ripard <[email protected]>---
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maxime Ripard
AppliedQuoted 10 lines · Eric Anholt
Quoted 7 lines · Maxime Ripard
The
VC4_SET_FIELDandVC4_GET_FIELDare reimplementing most of the logic already defined inFIELD_SETandFIELD_GET. Let's convert the vc4 macros to use the FIELD_* macros.Signed-off-by Maxime Ripard <[email protected]>---
Reviewed-by Eric Anholt <[email protected]>
Applied, thanks!
Maxime
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel