x86: remove unused setup_pcat_compatibility() stub
PATCH 1/1 x86: remove unused setup_pcat_compatibility() stub
'git grep' did not find any user of this stub.
---
arch/x86/include/asm/u-boot-x86.h | 2 -- arch/x86/lib/zimage.c | 10 ---------- 2 files changed, 12 deletions(-)
arch/x86/include/asm/u-boot-x86.h +0 -2
@@ -75,8 +75,6 @@ int default_print_cpuinfo(void);/* Set up a UART which can be used with printch(), printhex8(), etc. */ int setup_internal_uart (int enable); -void setup_pcat_compatibility (void ); -void isa_unmap_rom (u32 addr);u32 isa_map_rom (u32 bus_addr,int size);
arch/x86/lib/zimage.c +0 -10
@@ -304,13 +304,6 @@ int setup_zimage(struct boot_params *setup_base, char *cmd_line, int auto_boot,return 0 ; } -void setup_pcat_compatibility (void ) - __attribute__((weak,alias ("__setup_pcat_compatibility" ))); - -void __setup_pcat_compatibility (void ) -{ -} -int do_zboot (struct cmd_tbl *cmdtp,int flag,int argc,char *const argv[]) {struct boot_params *base_ptr;
@@ -323,9 +316,6 @@ int do_zboot(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])disable_interrupts (); -/* Setup board for maximum PC/AT Compatibility */ -setup_pcat_compatibility (); -if (argc >=2 ) {/* argv[1] holds the address of the bzImage */ s = argv[1 ];
Signature · 1 line
2.25.1
PATCH 1/1 x86: remove unused setup_pcat_compatibility() stub
Hi Masahiro,
Quoted 10 lines · Masahiro Yamada
'git grep' did not find any user of this stub.
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/include/asm/u-boot-x86.h | 2 -- arch/x86/lib/zimage.c | 10 ---------- 2 files changed, 12 deletions(-)
See also: http://patchwork.ozlabs.org/project/uboot/patch/20200615035738.248710-21-sjg at chromium.org/
Regards,
Simon
PATCH 1/1 x86: remove unused setup_pcat_compatibility() stub
Simon,
Quoted 10 lines · Simon Glass
Hi Masahiro,
Quoted 6 lines · Masahiro Yamada
'git grep' did not find any user of this stub.
Signed-off-by Masahiro Yamada <[email protected]>---
Quoted 6 lines
Quoted 4 lines
arch/x86/include/asm/u-boot-x86.h | 2 -- arch/x86/lib/zimage.c | 10 ---------- 2 files changed, 12 deletions(-)See also: http://patchwork.ozlabs.org/project/uboot/patch/20200615035738.248710-21-sjg at chromium.org/
That's fine if you are removing this function.
Thanks.
Signature · 2 lines
Best Regards Masahiro Yamada
PATCH 1/1 x86: remove unused setup_pcat_compatibility() stub
Quoted 19 lines · Masahiro Yamada
Simon,
Quoted 15 lines · Simon Glass
Hi Masahiro,
Quoted 10 lines · Masahiro Yamada
'git grep' did not find any user of this stub.
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/include/asm/u-boot-x86.h | 2 -- arch/x86/lib/zimage.c | 10 ---------- 2 files changed, 12 deletions(-)
Quoted 6 lines
Quoted 1 line
See also: http://patchwork.ozlabs.org/project/uboot/patch/20200615035738.248710-21-sjg at chromium.org/
That's fine if you are removing this function.
Thanks.
Thanks Masahiro. I will use Simon's version then as it is included in a series.
Regards,
Bin