Skip to contentSkip to conversation

btfrs: initialize return of btrfs_extent_same

PATCH In review [email protected] 3 participants 4 messages Jul 5, 2020 – Jul 7, 2020 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btfrs: initialize return of btrfs_extent_same

From: Tom Rix <[email protected]>

clang static analysis flags a garbage return

fs/btrfs/reflink.c:611:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]

        return ret;
        ^~~~~~~~~~

ret will not be set when olen is 0
When olen is 0, this function does no work.

So initialize ret to 0

---
 fs/btrfs/reflink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/reflink.c +1 -1
index 040009d1cc31..200a80fcbecb 100644
@@ -572,7 +572,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 len,
 static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen,
 			     struct inode *dst, u64 dst_loff)
 {
-	int ret;
+	int ret = 0;
 	u64 i, tail_len, chunk_count;
 	struct btrfs_root *root_dst = BTRFS_I(dst)->root;
 
Signature · 1 line
2.18.1
#1 lore raw
Quoted 5 lines · On 5.07.20 г. 17:20 ч., [email protected] wrote:

From: Tom Rix <[email protected]>

clang static analysis flags a garbage return

fs/btrfs/reflink.c:611:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]

Quoted 8 lines
        return ret;
        ^~~~~~~~~~

ret will not be set when olen is 0
When olen is 0, this function does no work.

So initialize ret to 0

Patch itself is good however, the bug cannot currently be triggered, due to the following code in the sole caller (btrfs_remap_file_range):

   15         if (ret < 0 || len == 0)

14 goto out_unlock;

13

12 if (remap_flags & REMAP_FILE_DEDUP)

11 ret = btrfs_extent_same(src_inode, off, len,
dst_inode, destoff);
10 else

9 ret = btrfs_clone_files(dst_file, src_file, off,
len, destoff);

i.e len is guaranteed to be non-zero

Quoted 18 lines
---
 fs/btrfs/reflink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/reflink.c +1 -1
index 040009d1cc31..200a80fcbecb 100644
@@ -572,7 +572,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 len,
 static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen,
 			     struct inode *dst, u64 dst_loff)
 {
-	int ret;
+	int ret = 0;
 	u64 i, tail_len, chunk_count;
 	struct btrfs_root *root_dst = BTRFS_I(dst)->root;
 
#2 lore raw
Quoted 27 lines · Nikolay Borisov
Quoted 5 lines · On 5.07.20 г. 17:20 ч., [email protected] wrote:

From: Tom Rix <[email protected]>

clang static analysis flags a garbage return

fs/btrfs/reflink.c:611:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]

Quoted 8 lines
        return ret;
        ^~~~~~~~~~

ret will not be set when olen is 0
When olen is 0, this function does no work.

So initialize ret to 0

Patch itself is good however, the bug cannot currently be triggered, due to the following code in the sole caller (btrfs_remap_file_range):

   15         if (ret < 0 || len == 0)
   14                 goto out_unlock;
   13
   12         if (remap_flags & REMAP_FILE_DEDUP)
   11                 ret = btrfs_extent_same(src_inode, off, len, dst_inode, destoff);
   10         else
    9                 ret = btrfs_clone_files(dst_file, src_file, off,
Quoted 3 lines

len, destoff);

i.e len is guaranteed to be non-zero

Yeah, for that reason I don't think we need to set the value inside btrfs_extent_same because the caller(s) do the sanity checks.

There are VFS-level checks of the length wrt zero, eg. it won't even call to copy_file_range from vfs_copy_file_range. The user supplied length = 0 is interpreted as 'until the end of file' and is properly reclaculated in generic_remap_file_range_prep.

This looks like clang checker is not able to follow the values accross function calls, even if the functions are static.

Reviewed-by on v1 1/1
#3 lore raw
In reply to [email protected]
Quoted 5 lines · On 5.07.20 г. 17:20 ч., [email protected] wrote:

From: Tom Rix <[email protected]>

clang static analysis flags a garbage return

fs/btrfs/reflink.c:611:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]

Quoted 8 lines
        return ret;
        ^~~~~~~~~~

ret will not be set when olen is 0
When olen is 0, this function does no work.

So initialize ret to 0

And I forgot:

Quoted 18 lines
---
 fs/btrfs/reflink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/reflink.c +1 -1
index 040009d1cc31..200a80fcbecb 100644
@@ -572,7 +572,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 len,
 static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen,
 			     struct inode *dst, u64 dst_loff)
 {
-	int ret;
+	int ret = 0;
 	u64 i, tail_len, chunk_count;
 	struct btrfs_root *root_dst = BTRFS_I(dst)->root;