package/bitwise: add package
PATCH 1/1 package/bitwise: add package
Bitwise is multi base interactive calculator supporting dynamic base conversion and bit manipulation.
It's a handy tool for low level hackers,
kernel developers and device drivers developers.
--- package/Config.in | 1 + package/bitwise/Config.in | 10 ++++++++++ package/bitwise/bitwise.hash | 1 + package/bitwise/bitwise.mk | 12 ++++++++++++ 4 files changed, 24 insertions(+) create mode 100644 package/bitwise/Config.in create mode 100644 package/bitwise/bitwise.hash create mode 100644 package/bitwise/bitwise.mk
package/Config.in +1 -0
@@ -147,6 +147,7 @@ endmenu menu "Development tools" source "package/bats-core/Config.in" + source "package/bitwise/Config.in" source "package/binutils/Config.in" source "package/bsdiff/Config.in" source "package/bustle/Config.in"
package/bitwise/Config.in new file +10 -0
@@ -0,0 +1,10 @@ +config BR2_PACKAGE_BITWISE + bool "bitwise" + select BR2_PACKAGE_NCURSES + select BR2_PACKAGE_READLINE + help + Bitwise is multi base interactive calculator supporting dynamic base + conversion and bit manipulation. It's a handy tool for low level hackers, + kernel developers and device drivers developers. + + https://github.com/mellowcandle/bitwise
package/bitwise/bitwise.hash new file +1 -0
@@ -0,0 +1 @@ +sha256 33ce934fb99dadf7652224152cc135a0abf6a211adde53d96e9be7067567749c bitwise-v0.41.tar.gz
package/bitwise/bitwise.mk new file +12 -0
@@ -0,0 +1,12 @@ +# +# bitwise +# +################################################################################ + +BITWISE_VERSION = v0.41 +BITWISE_SITE = https://github.com/mellowcandle/bitwise/releases/download/$(BITWISE_VERSION) +BITWISE_SOURCE = bitwise-$(BITWISE_VERSION).tar.gz +BITWISE_DEPENDENCIES= ncurses readline +BITWISE_LICENSE = GPL-2.0 +BITWISE_LICENSE_FILES = COPYING +$(eval $(autotools-package))
Signature · 1 line
2.27.0
PATCH 1/1 package/bitwise: add package
Hello,
Thanks for your contribution! The commit title should be "package/bitwise: new package".
Quoted 5 lines · On Mon, 6 Jul 2020 07:19:04 +0300 Ramon Fried <[email protected]> wrote:
Bitwise is multi base interactive calculator supporting dynamic base conversion and bit manipulation.
It's a handy tool for low level hackers,
kernel developers and device drivers developers.
Quoted 7 lines
Signed-off-by Ramon Fried <[email protected]>--- package/Config.in | 1 + package/bitwise/Config.in | 10 ++++++++++ package/bitwise/bitwise.hash | 1 + package/bitwise/bitwise.mk | 12 ++++++++++++ 4 files changed, 24 insertions(+)
You need to update the DEVELOPERS file.
Quoted 6 lines
package/bitwise/Config.in new file +0
-0
package/bitwise/Config.in line 8
Quoted 8 lines
package/bitwise/Config.in new file +8
-0@@ -0,0 +1,10 @@ +config BR2_PACKAGE_BITWISE + bool "bitwise" + select BR2_PACKAGE_NCURSES + select BR2_PACKAGE_READLINE + help + Bitwise is multi base interactive calculator supporting dynamic base + conversion and bit manipulation. It's a handy tool for low level hackers, + kernel developers and device drivers developers.
I think some of those lines are too long. Could you run "make check-package" ?
Quoted 13 lines
package/bitwise/bitwise.hash new file +1
-0@@ -0,0 +1 @@ +sha256 33ce934fb99dadf7652224152cc135a0abf6a211adde53d96e9be7067567749c bitwise-v0.41.tar.gzpackage/bitwise/bitwise.mk new file +0
-0
package/bitwise/bitwise.mk line 4
Quoted 4 lines
package/bitwise/bitwise.mk new file +4
-0@@ -0,0 +1,12 @@ +# +# bitwise +# +################################################################################
The comment header is not complete, the first line full of #### is missing.
package/bitwise/bitwise.mk line 6
Quoted 1 line
package/bitwise/bitwise.mk new file +1
-0+BITWISE_VERSION = v0.41
This should be just 0.41
package/bitwise/bitwise.mk line 8
Quoted 2 lines
package/bitwise/bitwise.mk new file +2
-0+BITWISE_SITE = https://github.com/mellowcandle/bitwise/releases/download/$(BITWISE_VERSION) +BITWISE_SOURCE = bitwise-$(BITWISE_VERSION).tar.gz
So this should be:
BITWISE_SOURCE = bitwise-v$(BITWISE_VERSION).tar.gz
package/bitwise/bitwise.mk line 9
Quoted 1 line
package/bitwise/bitwise.mk new file +1
-0+BITWISE_DEPENDENCIES= ncurses readline
Space before =. This is reported by "make check-package" as well I believe.
package/bitwise/bitwise.mk line 11
Quoted 2 lines
package/bitwise/bitwise.mk new file +2
-0+BITWISE_LICENSE = GPL-2.0 +BITWISE_LICENSE_FILES = COPYING
We need an empty line before the eval autotools-package line.
package/bitwise/bitwise.mk line 12
Quoted 1 line
package/bitwise/bitwise.mk new file +1
-0+$(eval $(autotools-package))
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/bitwise: add package
Quoted 5 lines · Thomas Petazzoni
Hello,
Thanks for your contribution! The commit title should be "package/bitwise: new package".
Thanks, Fixed everything. sending v2.