acl: Fix RTE_ACL_RULE_SZ macro definition
Quoted 2 lines
From: Levend Sayar <[email protected]>
Could you provide some explanation:
What do you think is wrong with current version and why, and what your fix does.
Quoted 21 lines
Signed-off-by Levend Sayar <[email protected]>--- lib/librte_acl/rte_acl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_acl/rte_acl.h +1
-2@@ -116,7 +116,7 @@ struct rte_acl_rule_data { RTE_ACL_RULE_DEF(rte_acl_rule,);#define RTE_ACL_RULE_SZ (fld_num) \ - (sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) * (fld_num)) + (sizeof(struct rte_acl_rule_data) + sizeof(struct rte_acl_field) * (fld_num))/** Max number of characters in name.*/ --2.27.0
PATCH 1/1 acl: Fix RTE_ACL_RULE_SZ macro definition
From: Levend Sayar <[email protected]>
--- lib/librte_acl/rte_acl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_acl/rte_acl.h +1 -1
@@ -116,7 +116,7 @@ struct rte_acl_rule_data { RTE_ACL_RULE_DEF(rte_acl_rule,);#define RTE_ACL_RULE_SZ (fld_num) \ - (sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) * (fld_num)) + (sizeof(struct rte_acl_rule_data) + sizeof(struct rte_acl_field) * (fld_num))/** Max number of characters in name.*/
Signature · 1 line
2.27.0
From: Levend Sayar <[email protected]>
Sent: Tuesday, July 7, 2020 4:25 PM
To: Ananyev, Konstantin <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition
Sure.
I am really sorry for not being verbose enough.
From lib/librte_acl/rte_acl.h
#define RTE_ACL_RULE_DEF(name, fld_num) struct name {\
struct rte_acl_rule_data data; \
struct rte_acl_field field[fld_num]; \
}RTE_ACL_RULE_DEF(rte_acl_rule,);
When you put the definition in-place, above line means :
struct rte_acl_rule {
struct rte_acl_rule_data data;
struct rte_acl_field field[];
}
[KA] Yes.
There is another define to get the size of an acl rule such as
#define RTE_ACL_RULE_SZ(fld_num) \
(sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) * (fld_num))
So the above definition gets the size of a "struct rte_acl_rule" which has fld_num fields. which must be
sizeof (struct rte_acl_rule_data) + (sizeof(struct rte_acl_field) * fld_num)
Because it adds up the sizes of struct components;
[KA] I don’t think so.
You forgot about possible gaps between members of rte_acl_rule. Let say for 64 bit target it would be a 4B gap between ‘data’ and ‘field’. So, for:RTE_ACL_RULE_DEF(xz, 1);
sizeof(struct xz) == RTE_ACL_RULE_SZ(1) == 32
After changes you suggestRTE_ACL_RULE_SZ(1) == 28 != sizeof(struct xz)
Which is wrong.
But according to the current RTE_ACL_RULE_SZ, it is
sizeof (struct rte_acl_rule) + (sizeof(struct rte_acl_field) * fld_num)
So my patch only changes the part that I underlined.
sizeof (struct rte_acl_rule) = 16;
sizeof (struct rte_acl_rule_data) = 12;
Best,
Levend
Quoted 1 line · On Tue, Jul 7, 2020 at 3:42 PM Ananyev, Konstantin…
From: Levend Sayar <[email protected]<mailto:[email protected]>>
Could you provide some explanation:
What do you think is wrong with current version and why, and what your fix does.
Quoted 21 lines
--- lib/librte_acl/rte_acl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_acl/rte_acl.h +1
-2@@ -116,7 +116,7 @@ struct rte_acl_rule_data { RTE_ACL_RULE_DEF(rte_acl_rule,);#define RTE_ACL_RULE_SZ (fld_num) \ - (sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) * (fld_num)) + (sizeof(struct rte_acl_rule_data) + sizeof(struct rte_acl_field) * (fld_num))/** Max number of characters in name.*/ --2.27.0
Sure.
I am really sorry for not being verbose enough.
From lib/librte_acl/rte_acl.h
#define RTE_ACL_RULE_DEF(name, fld_num) struct name {\
struct rte_acl_rule_data data; \
struct rte_acl_field field[fld_num]; \
}RTE_ACL_RULE_DEF(rte_acl_rule,);
When you put the definition in-place, above line means :
struct rte_acl_rule {
struct rte_acl_rule_data data;
struct rte_acl_field field[];
}
There is another define to get the size of an acl rule such as
#define RTE_ACL_RULE_SZ(fld_num) \
(sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) * (fld_num))
So the above definition gets the size of a "struct rte_acl_rule" which has fld_num fields.
which must be
*sizeof (struct rte_acl_rule_data) *+ (sizeof(struct rte_acl_field) * fld_num)
Because it adds up the sizes of struct components;
But according to the current RTE_ACL_RULE_SZ, it is
*sizeof (struct rte_acl_rule)* + (sizeof(struct rte_acl_field) * fld_num)
So my patch only changes the part that I underlined.
sizeof (struct rte_acl_rule) = 16;
sizeof (struct rte_acl_rule_data) = 12;
Best,
Levend
Quoted 32 lines · Konstantin
Quoted 2 lines
From: Levend Sayar <[email protected]>
Could you provide some explanation:
What do you think is wrong with current version and why, and what your fix does.Quoted 11 lines
Signed-off-by Levend Sayar <[email protected]>--- lib/librte_acl/rte_acl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_acl/rte_acl.h +0
-0lib/librte_acl/rte_acl.h struct rte_acl_rule_data { · line 119
Quoted 4 lines
lib/librte_acl/rte_acl.h +0
-1@@ -116,7 +116,7 @@ struct rte_acl_rule_data { RTE_ACL_RULE_DEF(rte_acl_rule,);#define RTE_ACL_RULE_SZ (fld_num) \ - (sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) *(
fld_num))lib/librte_acl/rte_acl.h struct rte_acl_rule_data { · line 119
Quoted 1 line
lib/librte_acl/rte_acl.h +1
-0+ (sizeof(struct rte_acl_rule_data) + sizeof(struct rte_acl_field) *(
fld_num))Quoted 5 lines
lib/librte_acl/rte_acl.h +0
-1/** Max number of characters in name.*/ --2.27.0
Yes you are totally right.
I overlooked the alignment of struct components.
Sorry for that.
But imho, not to have such confusions,
Another define can be added such as
#define RTE_ACL_RULE_SIZE(xz) sizeof(struct xz)
Thanks for your time.
Best,
Levend
Quoted 164 lines · Konstantin
*From:* Levend Sayar <[email protected]>
*Sent:* Tuesday, July 7, 2020 4:25 PM
*To:* Ananyev, Konstantin <[email protected]> *Cc:* [email protected]
*Subject:* Re: [PATCH] acl: FixRTE_ACL_RULE_SZmacro definitionSure.
I am really sorry for not being verbose enough.
From
lib/librte_acl/rte_acl.h#define
RTE_ACL_RULE_DEF(*name*, *fld_num*)*struct* name {\*struct* rte_acl_rule_data data; \ *struct* rte_acl_field field[fld_num]; \}
RTE_ACL_RULE_DEF(rte_acl_rule,);When you put the definition in-place, above line means :
struct
rte_acl_rule{struct rte_acl_rule_data data; struct rte_acl_field field[];}
[KA] Yes.
There is another define to get the size of an acl rule such as
#define
RTE_ACL_RULE_SZ(*fld_num*)\(
sizeof(struct rte_acl_rule)+sizeof(struct rte_acl_field)* (fld_num
))So the above definition gets the size of a "struct
rte_acl_rule" which hasfld_numfields.which must be
*sizeof (struct
rte_acl_rule_data) *+ (sizeof(struct rte_acl_field)*fld_num)Because it adds up the sizes of struct components;
[KA] I don’t think so.
You forgot about possible gaps between members of
rte_acl_rule.Let say for 64 bit target it would be a 4B gap between ‘data’ and ‘field’.
So, for:
RTE_ACL_RULE_DEF(xz, 1);sizeof(struct xz) ==
RTE_ACL_RULE_SZ(1)== 32After changes you suggest
RTE_ACL_RULE_SZ(1)== 28 != sizeof(struct xz)Which is wrong.
But according to the current
RTE_ACL_RULE_SZ, it is*sizeof (struct rte_acl_rule)* + (
sizeof(struct rte_acl_field)*fld_num)So my patch only changes the part that I underlined.
sizeof (struct
rte_acl_rule) = 16;sizeof (struct
rte_acl_rule_data) = 12;Best,
Levend
Quoted 1 line · Konstantin
From: Levend Sayar <[email protected]>
Could you provide some explanation:
What do you think is wrong with current version and why, and what your fix does.Quoted 11 lines
Signed-off-by Levend Sayar <[email protected]>--- lib/librte_acl/rte_acl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_acl/rte_acl.h +0
-0lib/librte_acl/rte_acl.h struct rte_acl_rule_data { · line 119
Quoted 4 lines
lib/librte_acl/rte_acl.h +0
-1@@ -116,7 +116,7 @@ struct rte_acl_rule_data { RTE_ACL_RULE_DEF(rte_acl_rule,);#define RTE_ACL_RULE_SZ (fld_num) \ - (sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) *(
fld_num))lib/librte_acl/rte_acl.h struct rte_acl_rule_data { · line 119
Quoted 1 line
lib/librte_acl/rte_acl.h +1
-0+ (sizeof(struct rte_acl_rule_data) + sizeof(struct rte_acl_field) *(
fld_num))Quoted 5 lines
lib/librte_acl/rte_acl.h +0
-1/** Max number of characters in name.*/ --2.27.0