disas/riscv: Fix incorrect disassembly for `imm20` operand.
PATCH 1/1 disas/riscv: Fix incorrect disassembly for `imm20` operand.
imm20 operand type is used in LUI/AUIPC and other instructions. The value should not be left shifted 12bits for disassembly output.
Signed-off-by Wei Wu <[email protected]>
--- disas/riscv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
disas/riscv.c +1 -1
@@ -2083,7 +2083,7 @@ static int32_t operand_imm12(rv_inst inst)static int32_t operand_imm20 (rv_inst inst) { -return (((int64_t )inst <<32 ) >>44 ) <<12 ; +return ((int64_t )inst <<32 ) >>44 ; }static int32_t operand_jimm20 (rv_inst inst)
Signature · 1 line
2.17.1
disas/riscv.c static int32_t operand_imm12(rv_inst inst) · line 2087
Quoted 5 lines · Wei Wu
static
int32_toperand_imm20(rv_inst inst)
{disas/riscv.c +1
-1-return (((int64_t )inst <<32 ) >>44 ) <<12 ; +return ((int64_t )inst <<32 ) >>44 ; }
There's no point in casting to int64_t, for one. But it would be better to use sextract32(inst, 12, 20).
r~