sparc: Use fallthrough pseudo-keyword
PATCH 1/1 sparc: Use fallthrough pseudo-keyword
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case.
--- arch/sparc/kernel/auxio_64.c | 1 - arch/sparc/kernel/central.c | 2 +- arch/sparc/kernel/kgdb_32.c | 2 +- arch/sparc/kernel/kgdb_64.c | 2 +- arch/sparc/kernel/pcr.c | 2 +- arch/sparc/kernel/prom_32.c | 2 +- arch/sparc/kernel/signal32.c | 4 ++-- arch/sparc/kernel/signal_32.c | 4 ++-- arch/sparc/kernel/signal_64.c | 4 ++-- arch/sparc/math-emu/math_32.c | 8 ++++---- 10 files changed, 15 insertions(+), 16 deletions(-)
arch/sparc/kernel/auxio_64.c +0 -1
@@ -87,7 +87,6 @@ void auxio_set_lte(int on)__auxio_sbus_set_lte (on);break ;case AUXIO_TYPE_EBUS : -/* FALL-THROUGH */ default :break ; }
arch/sparc/kernel/central.c +1 -1
@@ -55,7 +55,7 @@ static int clock_board_calc_nslots(struct clock_board *p)else return 5 ; } -/* Fallthrough */ + fallthrough;default :return 4 ; }
arch/sparc/kernel/kgdb_32.c +1 -1
@@ -122,7 +122,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, linux_regs->pc = addr; linux_regs->npc = addr +4 ; } -/* fall through */ + fallthrough;case 'D' :case 'k' :
arch/sparc/kernel/kgdb_64.c +1 -1
@@ -148,7 +148,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, linux_regs->tpc = addr; linux_regs->tnpc = addr +4 ; } -/* fall through */ + fallthrough;case 'D' :case 'k' :
arch/sparc/kernel/pcr.c +1 -1
@@ -359,7 +359,7 @@ int __init pcr_arch_init(void)* counter overflow interrupt so we can't make use of * their hardware currently. */ -/* fallthrough */ + fallthrough;default : err = -ENODEV ; goto out_unregister;
arch/sparc/kernel/prom_32.c +1 -1
@@ -224,7 +224,7 @@ void __init of_console_init(void)case PROMDEV_TTYB : skip =1 ; -/* FALLTHRU */ + fallthrough;case PROMDEV_TTYA : type ="serial" ;
arch/sparc/kernel/signal32.c +2 -2
@@ -646,7 +646,7 @@ static inline void syscall_restart32(unsigned long orig_i0, struct pt_regs *regscase ERESTARTSYS :if (!(sa->sa_flags &SA_RESTART )) goto no_system_call_restart; -/* fallthrough */ + fallthrough;case ERESTARTNOINTR : regs->u_regs[UREG_I0 ] = orig_i0; regs->tpc -=4 ;
@@ -686,7 +686,7 @@ void do_signal32(struct pt_regs * regs) regs->tpc -=4 ; regs->tnpc -=4 ;pt_regs_clear_syscall (regs); -/* fall through */ + fallthrough;case ERESTART_RESTARTBLOCK : regs->u_regs[UREG_G1 ] = __NR_restart_syscall; regs->tpc -=4 ;
arch/sparc/kernel/signal_32.c +2 -2
@@ -441,7 +441,7 @@ static inline void syscall_restart(unsigned long orig_i0, struct pt_regs *regs,case ERESTARTSYS :if (!(sa->sa_flags &SA_RESTART )) goto no_system_call_restart; -/* fallthrough */ + fallthrough;case ERESTARTNOINTR : regs->u_regs[UREG_I0 ] = orig_i0; regs->pc -=4 ;
@@ -507,7 +507,7 @@ static void do_signal(struct pt_regs *regs, unsigned long orig_i0) regs->pc -=4 ; regs->npc -=4 ;pt_regs_clear_syscall (regs); -/* fall through */ + fallthrough;case ERESTART_RESTARTBLOCK : regs->u_regs[UREG_G1 ] = __NR_restart_syscall; regs->pc -=4 ;
arch/sparc/kernel/signal_64.c +2 -2
@@ -461,7 +461,7 @@ static inline void syscall_restart(unsigned long orig_i0, struct pt_regs *regs,case ERESTARTSYS :if (!(sa->sa_flags &SA_RESTART )) goto no_system_call_restart; -/* fallthrough */ + fallthrough;case ERESTARTNOINTR : regs->u_regs[UREG_I0 ] = orig_i0; regs->tpc -=4 ;
@@ -532,7 +532,7 @@ static void do_signal(struct pt_regs *regs, unsigned long orig_i0) regs->tpc -=4 ; regs->tnpc -=4 ;pt_regs_clear_syscall (regs); -/* fall through */ + fallthrough;case ERESTART_RESTARTBLOCK : regs->u_regs[UREG_G1 ] = __NR_restart_syscall; regs->tpc -=4 ;
arch/sparc/math-emu/math_32.c +4 -4
@@ -359,7 +359,7 @@ static int do_one_mathemu(u32 insn, unsigned long *pfsr, unsigned long *fregs) *pfsr |= (6 <<14 );return 0 ;/* simulate invalid_fp_register exception */ } -/* fall through */ + fallthrough;case 2 :if (freg &1 ) {/* doublewords must have bit 5 zeroed */ *pfsr |= (6 <<14 );
@@ -380,7 +380,7 @@ static int do_one_mathemu(u32 insn, unsigned long *pfsr, unsigned long *fregs) *pfsr |= (6 <<14 );return 0 ;/* simulate invalid_fp_register exception */ } -/* fall through */ + fallthrough;case 2 :if (freg &1 ) {/* doublewords must have bit 5 zeroed */ *pfsr |= (6 <<14 );
@@ -408,13 +408,13 @@ static int do_one_mathemu(u32 insn, unsigned long *pfsr, unsigned long *fregs) *pfsr |= (6 <<14 );return 0 ;/* simulate invalid_fp_register exception */ } -/* fall through */ + fallthrough;case 2 :if (freg &1 ) {/* doublewords must have bit 5 zeroed */ *pfsr |= (6 <<14 );return 0 ; } -/* fall through */ + fallthrough;case 1 : rd = (void *)&fregs[freg];break ;
From: "Gustavo A. R. Silva" <[email protected]>
Date: Tue, 7 Jul 2020 12:24:36 -0500
Quoted 7 lines
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.
Quoted 7 lines · David Miller
From: "Gustavo A. R. Silva" <[email protected]>
Date: Tue, 7 Jul 2020 12:24:36 -0500Quoted 4 lines
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case.
Quoted 6 lines
Quoted 3 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied.
Thanks, Dave.
--
Gustavo