Skip to contentSkip to conversation

i915/gem_exec_suspend: Added test description for test case

PATCH In review [email protected] 3 participants 4 messages Jul 9, 2020 – Nov 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i915/gem_exec_suspend: Added test description for test case

From: ranjeet kumar <[email protected]>

Added test description for subtest.

Cc Melkaveri, Arjun <[email protected]>
---
 tests/i915/gem_exec_suspend.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
tests/i915/gem_exec_suspend.c +19 -0
index d768db91..8c9258f5 100644
@@ -50,6 +50,9 @@
 #define CACHED (1<<8)
 #define HANG (2<<8)
 
+IGT_TEST_DESCRIPTION("executing batch buffer objects on suspend and then checks"
+		     " for the result");
+
 static void run_test(int fd, unsigned ring, unsigned flags);
 
 static void check_bo(int fd, uint32_t handle)
@@ -312,23 +315,33 @@ igt_main
 		igt_fork_hang_detector(fd);
 	}
 
+	igt_describe("checks normal condition before sending into suspend");
 	igt_subtest("basic")
 		run_test(fd, ALL_ENGINES, NOSLEEP);
+	igt_describe("system in idle state no operation");
 	igt_subtest("basic-S0")
 		run_test(fd, ALL_ENGINES, IDLE);
+	igt_describe("suspend-to-mem target state and resume with with some operation");
 	igt_subtest("basic-S3-devices")
 		run_test(fd, ALL_ENGINES, SUSPEND_DEVICES);
+	igt_describe("suspend-to-mem and resume with no operation");
 	igt_subtest("basic-S3")
 		run_test(fd, ALL_ENGINES, SUSPEND);
+	igt_describe("suspend-to-disk target state and resume with with some operation");
 	igt_subtest("basic-S4-devices")
 		run_test(fd, ALL_ENGINES, HIBERNATE_DEVICES);
+	igt_describe("suspend-to-disk and resume with no operation");
 	igt_subtest("basic-S4")
 		run_test(fd, ALL_ENGINES, HIBERNATE);
 
 	for (e = intel_execution_engines; e->name; e++) {
 		for (m = modes; m->suffix; m++) {
+			igt_describe("Test normal operation write and some reloc"
+				     " operation performed");
 			igt_subtest_f("%s-uncached%s", e->name, m->suffix)
 				run_test(fd, eb_ring(e), m->mode | UNCACHED);
+			igt_describe("Wraps the SET_CACHING ioctl and then performed"
+				     " write and reloc operation");
 			igt_subtest_f("%s-cached%s", e->name, m->suffix)
 				run_test(fd, eb_ring(e), m->mode | CACHED);
 		}
@@ -339,13 +352,19 @@ igt_main
 		hang = igt_allow_hang(fd, 0, 0);
 	}
 
+	igt_describe("Start a recursive call of batch on a ring and return structure"
+		     " with suspended state");
 	igt_subtest("hang-S3")
 		run_test(fd, 0, SUSPEND | HANG);
+	igt_describe("Start a recursive call of batch on a ring and return structure"
+		     " with hibernate state");
 	igt_subtest("hang-S4")
 		run_test(fd, 0, HIBERNATE | HANG);
 
+	igt_describe("Test is to report energy level");
 	igt_subtest("power-S0")
 		power_test(fd, 0, IDLE);
+	igt_describe("Test to report power consumed and discharge rate while suspended");
 	igt_subtest("power-S3")
 		power_test(fd, 0, SUSPEND);
 
Signature · 6 lines
2.26.2

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_suspend: Added test description for test case

== Series Details ==

== Series Details ==

Series: i915/gem_exec_suspend: Added test description for test case
URL : https://patchwork.freedesktop.org/series/79276/
State : success

== Summary ==

CI Bug Log - changes from IGT_5729 -> IGTPW_4752
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/index.html

Known issues
------------

Here are the changes found in IGTPW_4752 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-tgl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-tgl-u2/igt@[email protected]

* igt@gem_flink_basic@flink-lifetime:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-tgl-y/igt@[email protected]

* igt@i915_pm_backlight@basic-brightness:
- fi-whl-u: [PASS][5] -> [DMESG-WARN][6] ([i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-whl-u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-whl-u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-bsw-kefka/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-bsw-kefka/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-icl-u2/igt@kms_flip@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-icl-u2/igt@kms_flip@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][11] ([i915#1888]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-tgl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-tgl-u2/igt@[email protected]

* igt@gem_flink_basic@double-flink:
- fi-tgl-y: [DMESG-WARN][13] ([i915#402]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-tgl-y/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-tgl-y/igt@[email protected]

* igt@i915_module_load@reload:
- fi-byt-j1900: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-byt-j1900/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-byt-j1900/igt@[email protected]
- fi-apl-guc: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-apl-guc/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-apl-guc/igt@[email protected]
- fi-tgl-y: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-tgl-y/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-tgl-y/igt@[email protected]

* igt@i915_selftest@live@active:
- fi-icl-y: [DMESG-FAIL][21] ([i915#765]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-icl-y/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-icl-y/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-tgl-u2: [DMESG-WARN][23] ([i915#402]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-tgl-u2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-tgl-u2/igt@[email protected]

#### Warnings ####

* igt@debugfs_test@read_all_entries:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html

* igt@prime_vgem@basic-fence-flip:
- fi-kbl-x1275: [DMESG-WARN][27] ([i915#62] / [i915#92]) -> [DMESG-WARN][28] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/fi-kbl-x1275/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/fi-kbl-x1275/igt@[email protected]

[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#765]: https://gitlab.freedesktop.org/drm/intel/issues/765
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (44 -> 37)
------------------------------

Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5729 -> IGTPW_4752

CI-20190529: 20190529
CI_DRM_8717: 6e5ac4c72af4e86138f04cc2dd089b069bad873f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4752: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/index.html
IGT_5729: a048d54f58dd70b07dbeb4541b273ec230ddb586 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_suspend: Added test description for test case

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: i915/gem_exec_suspend: Added test description for test case
URL : https://patchwork.freedesktop.org/series/79276/
State : success

== Summary ==

CI Bug Log - changes from IGT_5729_full -> IGTPW_4752_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with IGTPW_4752_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4752_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4752_full:

### IGT changes ###

#### Warnings ####

* igt@gem_exec_reloc@basic-concurrent0:
- shard-tglb: [FAIL][1] ([i915#1930]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb6/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4752_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_shared@q-smoketest-all:
- shard-kbl: [PASS][3] -> [INCOMPLETE][4] ([i915#1159])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl6/igt@[email protected]

* igt@gem_exec_create@madvise:
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-glk8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-glk8/igt@[email protected]

* igt@gem_exec_fence@syncobj-unused-fence:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([i915#1635] / [i915#95]) +33 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl7/igt@[email protected]

* igt@gem_exec_flush@basic-batch-kernel-default-uc:
- shard-hsw: [PASS][9] -> [TIMEOUT][10] ([i915#1958] / [i915#2119]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-hsw4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-hsw6/igt@[email protected]
- shard-snb: [PASS][11] -> [TIMEOUT][12] ([i915#1958] / [i915#2119]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-snb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-snb5/igt@[email protected]

* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: [PASS][13] -> [INCOMPLETE][14] ([i915#155])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl4/igt@[email protected]

* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl7/igt@[email protected]
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-glk3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-glk2/igt@[email protected]
- shard-iclb: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-iclb5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-iclb7/igt@[email protected]

* igt@kms_color@pipe-a-ctm-green-to-red:
- shard-tglb: [PASS][21] -> [DMESG-WARN][22] ([i915#1149] / [i915#402])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-random:
- shard-kbl: [PASS][23] -> [DMESG-FAIL][24] ([i915#54] / [i915#95]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl3/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled:
- shard-apl: [PASS][25] -> [DMESG-FAIL][26] ([i915#1635] / [i915#54] / [i915#95])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl7/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled:
- shard-kbl: [PASS][27] -> [DMESG-FAIL][28] ([fdo#108145] / [i915#54] / [i915#95])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl7/igt@[email protected]
- shard-apl: [PASS][29] -> [DMESG-FAIL][30] ([fdo#108145] / [i915#1635] / [i915#54] / [i915#95])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl6/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([i915#180]) +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl4/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-kbl: [PASS][33] -> [DMESG-WARN][34] ([i915#93] / [i915#95]) +44 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: [PASS][35] -> [DMESG-WARN][36] ([i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen:
- shard-tglb: [PASS][37] -> [DMESG-WARN][38] ([i915#1982]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen.html

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][39] -> [DMESG-FAIL][40] ([i915#95]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl2/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-overlay-size-64:
- shard-apl: [PASS][41] -> [DMESG-FAIL][42] ([i915#1635] / [i915#95]) +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl6/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-primary-size-64:
- shard-tglb: [PASS][43] -> [DMESG-WARN][44] ([i915#402]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb3/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109441]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-iclb5/igt@kms_psr@psr2_cursor_render.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-tglb: [PASS][47] -> [DMESG-WARN][48] ([i915#1602] / [i915#1887])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb1/igt@[email protected]

#### Possible fixes ####

* igt@gem_userptr_blits@create-destroy-sync:
- shard-hsw: [TIMEOUT][49] ([i915#1958] / [i915#2119]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-hsw4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-hsw2/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][51] ([i915#454]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-iclb6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-iclb6/igt@[email protected]

* igt@i915_suspend@forcewake:
- shard-kbl: [INCOMPLETE][53] ([i915#155] / [i915#636]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl3/igt@[email protected]

* igt@kms_addfb_basic@addfb25-modifier-no-flag:
- shard-apl: [DMESG-WARN][55] ([i915#1635] / [i915#95]) -> [PASS][56] +35 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl7/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-apl: [DMESG-FAIL][57] ([i915#1635] / [i915#95]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl3/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl3/igt@[email protected]
- shard-kbl: [DMESG-FAIL][59] ([i915#95]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl2/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-glk: [DMESG-FAIL][61] ([i915#118] / [i915#95]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-glk8/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-glk6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x256-random:
- shard-snb: [TIMEOUT][63] ([i915#1958] / [i915#2119]) -> [PASS][64] +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-snb5/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-snb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-kbl: [DMESG-FAIL][65] ([i915#54] / [i915#95]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl3/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl2/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-render-ytiled:
- shard-apl: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl3/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl6/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][69] ([i915#1525]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl8/igt@[email protected]
- shard-kbl: [FAIL][71] ([i915#64]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl3/igt@[email protected]

* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [DMESG-WARN][73] ([i915#1982]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-glk1/igt@kms_flip@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-glk7/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl7/igt@kms_flip@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-tglb: [DMESG-WARN][77] ([i915#1602] / [i915#1887]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb7/igt@kms_flip@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-tglb: [INCOMPLETE][79] -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb7/igt@kms_flip@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb3/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-tglb: [DMESG-WARN][81] ([i915#1982]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-kbl: [DMESG-FAIL][83] ([fdo#108145] / [i915#95]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl3/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl4/igt@[email protected]
- shard-apl: [DMESG-FAIL][85] ([fdo#108145] / [i915#1635] / [i915#95]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl3/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl7/igt@[email protected]

* igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
- shard-tglb: [DMESG-WARN][87] ([i915#402]) -> [PASS][88] +5 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb5/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb7/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][89] ([fdo#109642] / [fdo#111068]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-iclb4/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][91] ([fdo#109441]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- shard-kbl: [DMESG-WARN][93] ([i915#93] / [i915#95]) -> [PASS][94] +41 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl4/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl3/igt@[email protected]

#### Warnings ####

* igt@gem_exec_reloc@basic-concurrent0:
- shard-apl: [FAIL][95] ([i915#1930]) -> [DMESG-FAIL][96] ([i915#1635] / [i915#95])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl7/igt@[email protected]

* igt@gem_exec_reloc@basic-spin-others@vcs0:
- shard-snb: [WARN][97] ([i915#2036]) -> [WARN][98] ([i915#2021])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-snb6/igt@gem_exec_reloc@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-snb2/igt@gem_exec_reloc@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][99] ([i915#588]) -> [SKIP][100] ([i915#658])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-iclb2/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-iclb8/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: [SKIP][101] ([fdo#109271] / [i915#1635] / [i915#1937]) -> [SKIP][102] ([fdo#109271] / [i915#1937])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl1/igt@i915_pm_lpsp@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl6/igt@i915_pm_lpsp@[email protected]

* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- shard-hsw: [SKIP][103] ([fdo#109271]) -> [TIMEOUT][104] ([i915#1958] / [i915#2119]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-hsw2/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-hsw6/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: [SKIP][105] ([fdo#109271] / [fdo#111827]) -> [SKIP][106] ([fdo#109271] / [fdo#111827] / [i915#1635]) +5 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl2/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-apl: [SKIP][107] ([fdo#109271] / [fdo#111827] / [i915#1635]) -> [SKIP][108] ([fdo#109271] / [fdo#111827]) +2 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl6/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl7/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-apl: [FAIL][109] ([fdo#110321]) -> [DMESG-FAIL][110] ([fdo#110321] / [i915#1635] / [i915#95])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl6/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][111] ([i915#93] / [i915#95]) -> [DMESG-WARN][112] ([i915#180])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl7/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-64x64-sliding:
- shard-apl: [SKIP][113] ([fdo#109271]) -> [SKIP][114] ([fdo#109271] / [i915#1635]) +11 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl1/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl1/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][115] ([fdo#109349]) -> [DMESG-WARN][116] ([i915#1226])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-iclb3/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-iclb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-hsw: [TIMEOUT][117] ([i915#1958] / [i915#2119]) -> [SKIP][118] ([fdo#109271])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack:
- shard-apl: [SKIP][119] ([fdo#109271] / [i915#1635]) -> [SKIP][120] ([fdo#109271]) +9 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl4/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl3/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [DMESG-WARN][121] ([i915#180]) -> [DMESG-WARN][122] ([i915#180] / [i915#93] / [i915#95])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl1/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: [FAIL][123] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][124] ([fdo#108145] / [i915#1635] / [i915#95])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-apl8/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-apl7/igt@[email protected]
- shard-kbl: [FAIL][125] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][126] ([fdo#108145] / [i915#95])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-kbl7/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-kbl2/igt@[email protected]

* igt@kms_vblank@pipe-d-query-forked-busy:
- shard-snb: [SKIP][127] ([fdo#109271]) -> [TIMEOUT][128] ([i915#1958] / [i915#2119]) +3 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-snb6/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-snb5/igt@[email protected]

* igt@runner@aborted:
- shard-tglb: ([FAIL][129], [FAIL][130], [FAIL][131]) ([i915#2110]) -> ([FAIL][132], [FAIL][133]) ([i915#1602] / [i915#2110])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb5/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb8/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5729/shard-tglb7/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb8/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/shard-tglb1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1159]: https://gitlab.freedesktop.org/drm/intel/issues/1159
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1525]: https://gitlab.freedesktop.org/drm/intel/issues/1525
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1887]: https://gitlab.freedesktop.org/drm/intel/issues/1887
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2021]: https://gitlab.freedesktop.org/drm/intel/issues/2021
[i915#2036]: https://gitlab.freedesktop.org/drm/intel/issues/2036
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#636]: https://gitlab.freedesktop.org/drm/intel/issues/636
[i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (8 -> 8)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5729 -> IGTPW_4752

CI-20190529: 20190529
CI_DRM_8717: 6e5ac4c72af4e86138f04cc2dd089b069bad873f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4752: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/index.html
IGT_5729: a048d54f58dd70b07dbeb4541b273ec230ddb586 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4752/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw
In reply to [email protected]
Quoted 15 lines · On Thu, Jul 09, 2020 at 10:01:55AM +0530, [email protected] wrote:

From: ranjeet kumar <[email protected]>

Added test description for subtest.

Cc Melkaveri, Arjun <[email protected]>
---
 tests/i915/gem_exec_suspend.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
tests/i915/gem_exec_suspend.c +0 -0
index d768db91..8c9258f5 100644

tests/i915/gem_exec_suspend.c line 54

Quoted 5 lines
tests/i915/gem_exec_suspend.c +2 -0
@@ -50,6 +50,9 @@
 #define CACHED (1<<8)
 #define HANG (2<<8)
 
+IGT_TEST_DESCRIPTION("executing batch buffer objects on suspend and then checks"
+		     " for the result");

This description looks similar but somehow opposite to what is added above in comment.

tests/i915/gem_exec_suspend.c igt_main · line 318

Quoted 9 lines
tests/i915/gem_exec_suspend.c +2 -0
+
 static void run_test(int fd, unsigned ring, unsigned flags);
 
 static void check_bo(int fd, uint32_t handle)
@@ -312,23 +315,33 @@ igt_main
 		igt_fork_hang_detector(fd);
 	}
 
+	igt_describe("checks normal condition before sending into suspend");

s/checks/Check/
s/sending/setting/

tests/i915/gem_exec_suspend.c igt_main · line 320

Quoted 2 lines
tests/i915/gem_exec_suspend.c +0 -0
 	igt_subtest("basic")
 		run_test(fd, ALL_ENGINES, NOSLEEP);

Please add new line between all testcases here - it will be more readable.

tests/i915/gem_exec_suspend.c igt_main · line 321

Quoted 1 line
tests/i915/gem_exec_suspend.c +1 -0
+	igt_describe("system in idle state no operation");

igt_describe("Put system to sleep state (freeze)");

tests/i915/gem_exec_suspend.c igt_main · line 324

Quoted 3 lines
tests/i915/gem_exec_suspend.c +1 -0
 	igt_subtest("basic-S0")
 		run_test(fd, ALL_ENGINES, IDLE);
+	igt_describe("suspend-to-mem target state and resume with with some operation");

igt_describe("Put system into suspend to mem and verify it still works after resume.");

tests/i915/gem_exec_suspend.c igt_main · line 327

Quoted 3 lines
tests/i915/gem_exec_suspend.c +1 -0
 	igt_subtest("basic-S3-devices")
 		run_test(fd, ALL_ENGINES, SUSPEND_DEVICES);
+	igt_describe("suspend-to-mem and resume with no operation");

WHat does no operation mean here? ^

Looking libraries this case is performing suspend to mem, suspend sequence is to be terminated when platfrom and devs are not suspended.

tests/i915/gem_exec_suspend.c igt_main · line 330

Quoted 3 lines
tests/i915/gem_exec_suspend.c +1 -0
 	igt_subtest("basic-S3")
 		run_test(fd, ALL_ENGINES, SUSPEND);
+	igt_describe("suspend-to-disk target state and resume with with some operation");

What is 'some operation'?

tests/i915/gem_exec_suspend.c igt_main · line 333

Quoted 3 lines
tests/i915/gem_exec_suspend.c +1 -0
 	igt_subtest("basic-S4-devices")
 		run_test(fd, ALL_ENGINES, HIBERNATE_DEVICES);
+	igt_describe("suspend-to-disk and resume with no operation");

What does 'no operation mean'?

tests/i915/gem_exec_suspend.c igt_main · line 335

Quoted 2 lines
tests/i915/gem_exec_suspend.c +0 -0
 	igt_subtest("basic-S4")
 		run_test(fd, ALL_ENGINES, HIBERNATE);

Please be more specific in above cases. We need clear explanation what test is doing. Please investigate lib/lib_aux.h and lib/lib_aux.c for more information.

tests/i915/gem_exec_suspend.c igt_main · line 346

Quoted 10 lines
tests/i915/gem_exec_suspend.c +4 -0
 	for (e = intel_execution_engines; e->name; e++) {
 		for (m = modes; m->suffix; m++) {
+			igt_describe("Test normal operation write and some reloc"
+				     " operation performed");
 			igt_subtest_f("%s-uncached%s", e->name, m->suffix)
 				run_test(fd, eb_ring(e), m->mode | UNCACHED);
+			igt_describe("Wraps the SET_CACHING ioctl and then performed"
+				     " write and reloc operation");
 			igt_subtest_f("%s-cached%s", e->name, m->suffix)
 				run_test(fd, eb_ring(e), m->mode | CACHED);

I think these 2 description are showing what code is doing but not explaining what for. Please dig IGT libraries and Linux kernel documentation to explain why we need these tests.

Quoted 1 line

}

tests/i915/gem_exec_suspend.c igt_main · line 356

Quoted 6 lines
tests/i915/gem_exec_suspend.c +2 -0
@@ -339,13 +352,19 @@ igt_main
 		hang = igt_allow_hang(fd, 0, 0);
 	}
 
+	igt_describe("Start a recursive call of batch on a ring and return structure"
+		     " with suspended state");

Here again functions are described, but what is test doing? If you will look at git blame you will see that these 2 cases are checkign if we can suspend GPU even if it is busy with indefinite loop.

tests/i915/gem_exec_suspend.c igt_main · line 363

Quoted 7 lines
tests/i915/gem_exec_suspend.c +2 -0
 	igt_subtest("hang-S3")
 		run_test(fd, 0, SUSPEND | HANG);
+	igt_describe("Start a recursive call of batch on a ring and return structure"
+		     " with hibernate state");
 	igt_subtest("hang-S4")
 		run_test(fd, 0, HIBERNATE | HANG);
 

And these below are about mesuring power consumption during suspend.

Whole aim of documenting is to show aim of test, not tools that are used. Kasia

Quoted 14 lines
tests/i915/gem_exec_suspend.c +2 -0
+	igt_describe("Test is to report energy level");
 	igt_subtest("power-S0")
 		power_test(fd, 0, IDLE);
+	igt_describe("Test to report power consumed and discharge rate while suspended");
 	igt_subtest("power-S3")
 		power_test(fd, 0, SUSPEND);
 
Signature · 6 lines
2.26.2

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev