Skip to contentSkip to conversation

7cb32086e5: kernel-selftests.x86.check_initial_reg_state_32.fail

selftests Shuah Khan 2 participants 4 messages Jul 9, 2020 – Jul 13, 2020 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20200709064946.GQ3874@shao2-debian

Shuah Khan

author
#1 lore raw
Quoted 8 lines · kernel test robot

Greeting,

FYI, we noticed the following commit (built with gcc-9):

commit: 7cb32086e59b514a832a3e11f5370d37e7cfe022 ("selftests: simplify run_tests")
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master

Thanks for the report. I will drop this patch for now from next.

Yauheni,

This patch broke x86 32-bit test run
make run_tests -C x86

Please resubmit the patch with the fix.

thanks,
-- Shuah

#2 lore raw
Quoted 11 lines · Shuah Khan
Quoted 8 lines · kernel test robot

Greeting,

FYI, we noticed the following commit (built with gcc-9):

commit: 7cb32086e59b514a832a3e11f5370d37e7cfe022 ("selftests: simplify run_tests")
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master

Quoted 8 lines

Thanks for the report. I will drop this patch for now from next.

Yauheni,

This patch broke x86 32-bit test run
make run_tests -C x86

Please resubmit the patch with the fix.

I did not check carefully the report, but isn't it expected that some tests are moved after the patch since they originally were placed incorrectly?

Signature · 1 line
WBR, Yauheni
author
#3 lore raw
Quoted 16 lines · Yauheni Kaliuta
Quoted 15 lines · Shuah Khan
Quoted 8 lines · kernel test robot

Greeting,

FYI, we noticed the following commit (built with gcc-9):

commit: 7cb32086e59b514a832a3e11f5370d37e7cfe022 ("selftests: simplify run_tests")
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master

Thanks for the report. I will drop this patch for now from next.

Yauheni,

Quoted 10 lines
Quoted 4 lines

This patch broke x86 32-bit test run
make run_tests -C x86

Please resubmit the patch with the fix.

I did not check carefully the report, but isn't it expected that some tests are moved after the patch since they originally were placed incorrectly?

The failure doesn't have anything to do with test being moved. You can reproduce this very easily by running make as shown below in x86 dir under tools/testing/selftests

make run_tests -C x86

I reproduced the problem with your and patch and verified that the problem tracks your patch. I dropped the patch from linux-next Your other two patches in the series are fine.

In any case, this patch isn't really adding any functionality and is a good cleanup. Let's do the cleanup right or not.

thanks,
-- Shuah

#4 lore raw

Hi, Shuah!

Quoted 34 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Shuah Khan
Quoted 17 lines · Yauheni Kaliuta
Quoted 16 lines · Shuah Khan
Quoted 9 lines · kernel test robot

Greeting,

FYI, we noticed the following commit (built with gcc-9):

commit: 7cb32086e59b514a832a3e11f5370d37e7cfe022 ("selftests:
simplify run_tests")
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master

Thanks for the report. I will drop this patch for now from next.

Yauheni,

Quoted 10 lines
Quoted 4 lines

This patch broke x86 32-bit test run
make run_tests -C x86

Please resubmit the patch with the fix.

I did not check carefully the report, but isn't it expected that some tests are moved after the patch since they originally were placed incorrectly?

The failure doesn't have anything to do with test being moved. You can reproduce this very easily by running make as shown below in x86 dir under tools/testing/selftests

Quoted 8 lines

make run_tests -C x86

I reproduced the problem with your and patch and verified that the problem tracks your patch. I dropped the patch from linux-next Your other two patches in the series are fine.

In any case, this patch isn't really adding any functionality and is a good cleanup. Let's do the cleanup right or not.

Checked.

That is because with the patch both lib.mk and x86/Makefile add the $(OUTPUT) prefix.

So the question is to agree about the convention, should lib.mk targets expect short test names for TEST_PROGS or full path from the subtests' Makefiles.

The existing code is hackish (incorrectly -- adding $(OUTPUT) only to the first list members -- tries to handle it only for out-of-tree build).

I can make the patch without adding $(OUTPUT). It will require to fix possible tests which provided only one test and rely on that behaviour for the OOT build. Do you have an easy way to get a list of such tests?

Signature · 2 lines
WBR,
Yauheni Kaliuta